Skip to contentSkip to conversation

x86: parocessor.h - use PAGE_SIZE instead of numeric constant

PATCH In review Cyrill Gorcunov 2 participants 3 messages Mar 12, 2008

lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 1/1 x86: parocessor.h - use PAGE_SIZE instead of numeric constant

This patch replaces numeric constant with an appropriate macro

Signed-off-by Cyrill Gorcunov <[email protected]>

---

include/asm-x86/processor.h +1 -1
Index: linux-2.6.git/include/asm-x86/processor.h
===================================================================
@@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
 /*
  * User space process size. 47bits minus one guard page.
  */
-#define TASK_SIZE64	(0x800000000000UL - 4096)
+#define TASK_SIZE64	(0x800000000000UL - PAGE_SIZE)
 
 /* This decides where the kernel will search for a free chunk of vm
  * space during mmap's.
#1 lore raw
Quoted 11 lines · Cyrill Gorcunov

This patch replaces numeric constant with an appropriate macro

Signed-off-by Cyrill Gorcunov <[email protected]>

---

Index: linux-2.6.git/include/asm-x86/processor.h
===================================================================

include/asm-x86/processor.h extern unsigned long thread_saved_pc(str · line 792

Quoted 8 lines
include/asm-x86/processor.h +1 -1
@@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
 /*
  * User space process size. 47bits minus one guard page.
  */
-#define TASK_SIZE64	(0x800000000000UL - 4096)
+#define TASK_SIZE64	(0x800000000000UL - PAGE_SIZE)
 
 /* This decides where the kernel will search for a free chunk of vm
  * space during mmap's.

Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)

-hpa

author
#2 lore raw

Yep, it wold be more elegant, i'll fix it tomorrow. (sorry for top-posting, i'm not on my local laptop now)

Quoted 27 lines · H. Peter Anvin
Quoted 9 lines · Cyrill Gorcunov

This patch replaces numeric constant with an appropriate macro

Signed-off-by Cyrill Gorcunov <[email protected]>

---

Index: linux-2.6.git/include/asm-x86/processor.h
===================================================================
--- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20

19:14:57.000000000 +0300

Quoted 1 line

+++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12

23:10:02.000000000 +0300

include/asm-x86/processor.h extern unsigned long thread_saved_pc(str · line 792

Quoted 9 lines
include/asm-x86/processor.h +1 -1
@@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
 /*
  * User space process size. 47bits minus one guard page.
  */
-#define TASK_SIZE64	(0x800000000000UL - 4096)
+#define TASK_SIZE64	(0x800000000000UL - PAGE_SIZE)
 
 /* This decides where the kernel will search for a free chunk of vm
  * space during mmap's.

Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)

-hpa