kernel/sched.c: remove double unlikely

PATCH In review Roel Kluin 2 participants 2 messages Mar 13, 2008 – Mar 21, 2008

lore

Share & tools

lore

Roel Kluin

author

2008-03-13 16:42 UTC #0 lore raw

PATCH 1/1 kernel/sched.c: remove double unlikely

Combine two unlikely's

Signed-off-by Roel Kluin <[email protected]>

---

kernel/sched.c +1 -1

index 1cb53fb..532a7f4 100644
@@ -3875,7 +3875,7 @@ need_resched_nonpreemptible:
 
 	if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
 		if (unlikely((prev->state & TASK_INTERRUPTIBLE) &&
-				unlikely(signal_pending(prev)))) {
+				signal_pending(prev))) {
 			prev->state = TASK_RUNNING;
 		} else {
 			deactivate_task(rq, prev, 1);

Ingo Molnar

2008-03-21 11:35 UTC #1 lore raw

kernel/sched.c need_resched_nonpreemptible: · line 3878

Quoted 4 lines · Roel Kluin

Combine two unlikely's
kernel/sched.c +1 -1
-				unlikely(signal_pending(prev)))) {
+				signal_pending(prev))) {

good catch - thanks, applied.

Ingo