Skip to contentSkip to conversation

MMC: OMAP: Remove some opcodes from host driver

PATCH In review Carlos Aguiar 3 participants 3 messages Mar 14, 2008 – Mar 25, 2008

Subsystems (2)
MMC, SD and SDIO OMAP MMC support
lore
Share & tools
lore

Carlos Aguiar

author
#0 lore raw

PATCH 1/18 MMC: OMAP: Remove some opcodes from host driver

From: Carlos Eduardo Aguiar <[email protected]>

This patch removes some opcodes from host driver so there's no need on putting '#include <linux/mmc/mmc.h>', that should not be needed in host drivers.

Signed-off-by Carlos Eduardo Aguiar <[email protected]>
---
 drivers/mmc/host/omap.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)
drivers/mmc/host/omap.c +3 -8
index c9dfeb1..eb7175a 100644
@@ -495,15 +495,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
 		if (status & OMAP_MMC_STAT_CMD_TOUT) {
 			/* Timeouts are routine with some commands */
 			if (host->cmd) {
-				if (host->cmd->opcode != MMC_ALL_SEND_CID &&
-						host->cmd->opcode !=
-						MMC_SEND_OP_COND &&
-						host->cmd->opcode !=
-						MMC_APP_CMD &&
-						!mmc_omap_cover_is_open(host))
+				if (!mmc_omap_cover_is_open(host))
 					dev_err(mmc_dev(host->mmc),
-						"command timeout, CMD %d\n",
-						host->cmd->opcode);
+					"command timeout, CMD %d\n",
+					host->cmd->opcode);
 				host->cmd->error = -ETIMEDOUT;
 				end_command = 1;
 			}

-- 1.5.3.GIT

#1 lore raw
Quoted 7 lines · On Fri, 14 Mar 2008 15:36:01 -0400 Carlos Aguiar <[email protected]>…

From: Carlos Eduardo Aguiar <[email protected]>

This patch removes some opcodes from host driver so there's no need on putting '#include <linux/mmc/mmc.h>', that should not be needed in host drivers.

Signed-off-by Carlos Eduardo Aguiar <[email protected]>

---

Looks good.

Signature · 5 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
#2 lore raw
In reply to Carlos Aguiar
Quoted 5 lines · Carlos Aguiar

From: Carlos Eduardo Aguiar <[email protected]>

This patch removes some opcodes from host driver so there's no need on putting '#include <linux/mmc/mmc.h>', that should not be needed in host drivers.

You should update this patch and remove the '#include <linux/mmc/mmc.h>' from omap.c

Quoted 36 lines
Signed-off-by Carlos Eduardo Aguiar <[email protected]>

---

  drivers/mmc/host/omap.c |   11 +++--------
  1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index c9dfeb1..eb7175a 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -495,15 +495,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)

                if (status & OMAP_MMC_STAT_CMD_TOUT) {
                        /* Timeouts are routine with some commands */
                        if (host->cmd) {
 -                               if (host->cmd->opcode != MMC_ALL_SEND_CID &&
 -                                               host->cmd->opcode !=
 -                                               MMC_SEND_OP_COND &&
 -                                               host->cmd->opcode !=
 -                                               MMC_APP_CMD &&
 -                                               !mmc_omap_cover_is_open(host))
 +                               if (!mmc_omap_cover_is_open(host))
                                        dev_err(mmc_dev(host->mmc),
 -                                               "command timeout, CMD %d\n",
 -                                               host->cmd->opcode);
 +                                       "command timeout, CMD %d\n",
 +                                       host->cmd->opcode);
                                host->cmd->error = -ETIMEDOUT;
                                end_command = 1;
                        }

-- 1.5.3.GIT

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 4 lines
Best Regards,

Felipe Balbi
[email protected]