Skip to contentSkip to conversation

bridge: fix error handling in br_add_if()

PATCH New Volodymyr G. Lukiianyk 1 participant 1 message Mar 18, 2008

Subsystems (2)
Networking Ethernet bridge
lore
Share & tools
lore

Volodymyr G. Lukiianyk

author
#0 lore raw

PATCH 1/1 bridge: fix error handling in br_add_if()

When device is added to bridge its refcnt is incremented (in new_nbp()), but if error occurs during further br_add_if() operations this counter is not decremented back. Fix it by adding dev_put() call in the error path.

Signed-off-by Volodymyr G Lukiianyk <[email protected]>
net/bridge/br_if.c +4 -1
index 298e0f4..77a981a 100644
@@ -411,9 +411,12 @@ err2:
 	br_fdb_delete_by_port(br, p, 1);
 err1:
 	kobject_del(&p->kobj);
-	return err;
+	goto put_back;
 err0:
 	kobject_put(&p->kobj);
+
+put_back:
+	dev_put(dev);
 	return err;
 }