Fix permissions of /proc/net
commit f205a545ee62e0f0f797c1e2b0bd2062d96414b3
Author: Andre Noll <[email protected]> Date: Wed Mar 19 11:39:55 2008 +0100
From: Andre Noll <[email protected]>
commit e9720ac ([NET]: Make /proc/net a symlink on /proc/self/net (v3)) broke ganglia and probably other applications that read /proc/net/dev.
This is due to the change of permissions of /proc/net that was introduced in that commit.
Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30 /proc/net
After: dr-xr--r-- 5 root root 0 Mar 19 11:29 /proc/self/net
This patch restores the permissions to the old value which makes ganglia happy again.
fs/proc/base.c +1 -1
@@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = { DIR("fd", S_IRUSR|S_IXUSR, fd), DIR("fdinfo", S_IRUSR|S_IXUSR, fdinfo),#ifdef CONFIG_NET -DIR ("net" ,S_IRUGO |S_IXUSR , net), +DIR ("net" ,S_IRUGO |S_IXUGO , net), #endifREG ("environ" ,S_IRUSR , environ), INF("auxv", S_IRUSR, pid_auxv),
Signature · 1 line
The only person who always got his work done by Friday was Robinson Crusoe
Pavel Emelyanov
Acked-byQuoted 8 lines · Andre Noll
commit
f205a545ee62e0f0f797c1e2b0bd2062d96414b3Author: Andre Noll <[email protected]> Date: Wed Mar 19 11:39:55 2008 +0100From: Andre Noll <[email protected]>
commit e9720ac ([NET]: Make
/proc/neta symlink on/proc/self/net(v3)) broke ganglia and probably other applications that read/proc/net/dev.
This also broke the postfix, as it was reported in bug #10286 and described in detail by Benjamin.
Quoted 8 lines
This is due to the change of permissions of
/proc/netthat was introduced in that commit.Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30
/proc/net
After: dr-xr--r-- 5 root root 0 Mar 19 11:29/proc/self/netThis patch restores the permissions to the old value which makes ganglia happy again.
And it fixes the problem reported by Benjamin.
Thanks, Andre!
Quoted 1 line
Signed-off-by Andre Noll <[email protected]>
Quoted 13 lines
fs/proc/base.c +1
-1@@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = { DIR("fd", S_IRUSR|S_IXUSR, fd), DIR("fdinfo", S_IRUSR|S_IXUSR, fdinfo),#ifdef CONFIG_NET -DIR ("net" ,S_IRUGO |S_IXUSR , net), +DIR ("net" ,S_IRUGO |S_IXUGO , net), #endifREG ("environ" ,S_IRUSR , environ), INF("auxv", S_IRUSR, pid_auxv),
David Miller
AppliedFrom: Pavel Emelyanov <[email protected]>
Date: Thu, 20 Mar 2008 10:56:31 +0300
Quoted 4 lines
Quoted 1 line · Andre Noll
Signed-off-by Andre Noll <[email protected]>Acked-by Pavel Emelyanov <[email protected]>
Applied, thanks everyone.