Skip to contentSkip to conversation

: nf_conntrack_h323: logical-bitwise & confusion in process_setup()

PATCH Applied Patrick McHardy 2 participants 2 messages Mar 20, 2008

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Patrick McHardy

author
#0 lore raw

PATCH 1/2 : nf_conntrack_h323: logical-bitwise & confusion in process_setup()

commit 3e760ed979f6dbf063ced2117328ffee56620bbd

Author: Roel Kluin <[email protected]>
Date:   Thu Mar 20 18:34:39 2008 +0100

[NETFILTER]: nf_conntrack_h323: logical-bitwise & confusion in process_setup()

logical-bitwise & confusion

Signed-off-by Roel Kluin <[email protected]>
Signed-off-by Patrick McHardy <[email protected]>
net/netfilter/nf_conntrack_h323_main.c +1 -1
index 6213787..898f192 100644
@@ -842,7 +842,7 @@ static int process_setup(struct sk_buff *skb, struct nf_conn *ct,
 
 	set_h225_addr = rcu_dereference(set_h225_addr_hook);
 	if ((setup->options & eSetup_UUIE_destCallSignalAddress) &&
-	    (set_h225_addr) && ct->status && IPS_NAT_MASK &&
+	    (set_h225_addr) && ct->status & IPS_NAT_MASK &&
 	    get_h225_addr(ct, *data, &setup->destCallSignalAddress,
 			  &addr, &port) &&
 	    memcmp(&addr, &ct->tuplehash[!dir].tuple.src.u3, sizeof(addr))) {