MMC: OMAP: Fix HSMMC driver name at host driver.
Subsystems (2)
PATCH 1/1 MMC: OMAP: Fix HSMMC driver name at host driver.
From: Carlos Eduardo Aguiar <[email protected]>
This patch fixes the HSMMC driver name at host driver.
--- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/omap_hsmmc.c +1 -1
@@ -92,7 +92,7 @@#define OMAP_MMC_DATADIR_WRITE 2#define MMC_TIMEOUT_MS 20#define OMAP_MMC_MASTER_CLOCK 96000000 -#define DRIVER_NAME "mmci-omap" +#define DRIVER_NAME "hsmmc-omap"/* * slot_id is device id - 1, device id is a static value * of 1 to represent device 1 etc..
-- 1.5.3.GIT
Quoted 14 lines · Carlos Aguiar
From: Carlos Eduardo Aguiar <[email protected]>
This patch fixes the HSMMC driver name at host driver.
Signed-off-by Carlos Eduardo Aguiar <[email protected]>--- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mmc/host/omap_hsmmc.c +0
-0
drivers/mmc/host/omap_hsmmc.c line 95
Quoted 5 lines
drivers/mmc/host/omap_hsmmc.c +1
-1@@ -92,7 +92,7 @@#define OMAP_MMC_DATADIR_WRITE 2#define MMC_TIMEOUT_MS 20#define OMAP_MMC_MASTER_CLOCK 96000000 -#define DRIVER_NAME "mmci-omap" +#define DRIVER_NAME "hsmmc-omap"
stupid question :-p
what does the 'i' means?
Signature · 5 lines
Best Regards, Felipe Balbi [email protected] http://blog.felipebalbi.com
Quoted 23 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Felipe Balbi
Sent: Friday, March 21, 2008 4:25 AM
To: Carlos Aguiar
Cc: Tony Lindgren; [email protected]
Subject: Re: [PATCH 1/1] MMC: OMAP: Fix HSMMC driver name at host driver.Review
Quoted 10 lines · Carlos Aguiar
From: Carlos Eduardo Aguiar <[email protected]>
This patch fixes the HSMMC driver name at host driver.
Signed-off-by Carlos Eduardo Aguiar <[email protected]>--- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/drivers/mmc/host/omap_hsmmc.c
Quoted 12 lines
drivers/mmc/host/omap_hsmmc.c line 95
Quoted 9 lines
index 047c64d..0e7ee20 100644
drivers/mmc/host/omap_hsmmc.c +1
-1@@ -92,7 +92,7 @@#define OMAP_MMC_DATADIR_WRITE 2#define MMC_TIMEOUT_MS 20#define OMAP_MMC_MASTER_CLOCK 96000000 -#define DRIVER_NAME "mmci-omap" +#define DRIVER_NAME "hsmmc-omap"stupid question :-p
what does the 'i' means?
I think it is a simple mistake. The change you have done makes sense for the HSMMC driver.
Quoted 13 lines
Signature · 11 lines
-- Best Regards, Felipe Balbi [email protected] http://blog.felipebalbi.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 40 lines · ext Madhusudhan Chikkature Rajashekar
Quoted 27 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Felipe Balbi
Sent: Friday, March 21, 2008 4:25 AM
To: Carlos Aguiar
Cc: Tony Lindgren; [email protected]
Subject: Re: [PATCH 1/1] MMC: OMAP: Fix HSMMC driver name at host driver.Review
Quoted 11 lines · Carlos Aguiar
From: Carlos Eduardo Aguiar <[email protected]>
This patch fixes the HSMMC driver name at host driver.
Signed-off-by Carlos Eduardo Aguiar <[email protected]>--- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/drivers/mmc/host/omap_hsmmc.cQuoted 13 lines
drivers/mmc/host/omap_hsmmc.c line 96
Quoted 10 lines
index 047c64d..0e7ee20 100644
drivers/mmc/host/omap_hsmmc.c +1
-1@@ -92,7 +92,7 @@#define OMAP_MMC_DATADIR_WRITE 2#define MMC_TIMEOUT_MS 20#define OMAP_MMC_MASTER_CLOCK 96000000 -#define DRIVER_NAME "mmci-omap" +#define DRIVER_NAME "hsmmc-omap"stupid question :-p
what does the 'i' means?
Quoted 19 lines
I think it is a simple mistake. The change you have done makes sense for the HSMMC driver.
Quoted 13 lines
Signature · 10 lines
Best Regards, Felipe Balbi [email protected] http://blog.felipebalbi.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tony,
Please, don't apply this patch into the tree due some conflicts with such driver host names for 2420 (mmci-omap) and 2430 and 3430 (hsmmc-omap) boards. Explaining: on arch/arm/plat-omap/devices.c, I sent a patch [1] that proposes the following change:
...
#if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX) #define OMAP_MMC_NAME "hsmmc-omap"
#define OMAP_MMC1_BASE 0x4809c000
#define OMAP_MMC1_END OMAP_MMC1_BASE + 0x1fc
#define OMAP_MMC1_INT INT_24XX_MMC_IRQ
#define OMAP_MMC2_BASE 0x480b4000
#define OMAP_MMC2_END OMAP_MMC2_BASE + 0x1fc
#define OMAP_MMC2_INT INT_24XX_MMC_IRQ
#else
#define OMAP_MMC_NAME "mmci-omap"
...
But, the host driver name is mmci-omap for 2420 boards (like N800), so that images compiled with this patch will not start the MMC slots :(
Anyway, I think for now let's keep all driver hosts with name 'mmci-omap' in order keep all working and I'm going to resend this patch removing the defines OMAP_MMC_NAME and make some corrections into such patch.
I hope I was clear and thanks for the comprehension.
BR,
Carlos.
[1] http://marc.info/?l=linux-omap&m=120602333813488&w=2
Signature · 7 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]
Quoted 87 lines · Carlos Aguiar
Quoted 40 lines · ext Madhusudhan Chikkature Rajashekar
Quoted 27 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Felipe Balbi
Sent: Friday, March 21, 2008 4:25 AM
To: Carlos Aguiar
Cc: Tony Lindgren; [email protected]
Subject: Re: [PATCH 1/1] MMC: OMAP: Fix HSMMC driver name at host driver.Review
Quoted 11 lines · Carlos Aguiar
From: Carlos Eduardo Aguiar <[email protected]>
This patch fixes the HSMMC driver name at host driver.
Signed-off-by Carlos Eduardo Aguiar <[email protected]>--- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/drivers/mmc/host/omap_hsmmc.cQuoted 13 lines
drivers/mmc/host/omap_hsmmc.c line 96
Quoted 10 lines
index 047c64d..0e7ee20 100644
drivers/mmc/host/omap_hsmmc.c +1
-1@@ -92,7 +92,7 @@#define OMAP_MMC_DATADIR_WRITE 2#define MMC_TIMEOUT_MS 20#define OMAP_MMC_MASTER_CLOCK 96000000 -#define DRIVER_NAME "mmci-omap" +#define DRIVER_NAME "hsmmc-omap"stupid question :-p
what does the 'i' means?Quoted 19 lines
I think it is a simple mistake. The change you have done makes sense for the HSMMC driver.
Quoted 13 lines
Signature · 10 lines
Best Regards, Felipe Balbi [email protected] http://blog.felipebalbi.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.htmlHi Tony,
Please, don't apply this patch into the tree due some conflicts with such driver host names for 2420 (mmci-omap) and 2430 and 3430 (hsmmc-omap) boards. Explaining: on
arch/arm/plat-omap/devices.c, I sent a patch [1] that proposes the following change:...
#ifdefined(CONFIG_ARCH_OMAP24XX)||defined(CONFIG_ARCH_OMAP34XX)#defineOMAP_MMC_NAME"hsmmc-omap"#define
OMAP_MMC1_BASE0x4809c000
#defineOMAP_MMC1_ENDOMAP_MMC1_BASE+0x1fc
#defineOMAP_MMC1_INTINT_24XX_MMC_IRQ#define
OMAP_MMC2_BASE0x480b4000
#defineOMAP_MMC2_ENDOMAP_MMC2_BASE+0x1fc
#defineOMAP_MMC2_INTINT_24XX_MMC_IRQ#else
#define
OMAP_MMC_NAME"mmci-omap"
...But, the host driver name is mmci-omap for 2420 boards (like N800), so that images compiled with this patch will not start the MMC slots :(
Quoted 6 lines
Anyway, I think for now let's keep all driver hosts with name 'mmci-omap' in order keep all working and I'm going to resend this patch removing the defines
OMAP_MMC_NAMEand make some corrections into such patch.I hope I was clear and thanks for the comprehension.
OK, so let's forget this patch then.
Tony
Quoted 16 lines
BR,
Carlos.
[1] http://marc.info/?l=linux-omap&m=120602333813488&w=2
Signature · 7 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]