Skip to contentSkip to conversation

add page flags values to vmcoreinfo

PATCH In review Ken'ichi Ohmichi 2 participants 2 messages Mar 28, 2008 – Apr 2, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add page flags values to vmcoreinfo

Hi,

This patch adds some values of page flags to the vmcoreinfo data.

The vmcoreinfo data has the minimum debugging information only for dump filtering. makedumpfile (dump filtering command) gets it to distinguish unnecessary pages, and makedumpfile creates a small dumpfile.

An old makedumpfile (v1.2.4 or before) had assumed some values of page flags internally, and this implementation could not follow the change of these values. For example, Christoph Lameter is changing these values by the follwing patch:
http://lkml.org/lkml/2008/2/29/463

So a new makedumpfile (v1.2.5) came to need these values and I created this patch to let the kernel output them. This patch is for linux-2.6.25-rc7.

---

kernel/kexec.c +3 -0
diff -rpuN linux-2.6.25-rc6.org/kernel/kexec.c linux-2.6.25-rc6/kernel/kexec.c
@@ -1406,6 +1406,9 @@ static int __init crash_save_vmcoreinfo_
 	VMCOREINFO_LENGTH(zone.free_area, MAX_ORDER);
 	VMCOREINFO_LENGTH(free_area.free_list, MIGRATE_TYPES);
 	VMCOREINFO_NUMBER(NR_FREE_PAGES);
+	VMCOREINFO_NUMBER(PG_lru);
+	VMCOREINFO_NUMBER(PG_private);
+	VMCOREINFO_NUMBER(PG_swapcache);
 
 	arch_crash_save_vmcoreinfo();
 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Ken'ichi Ohmichi

Hi,

This patch adds some values of page flags to the vmcoreinfo data.

The vmcoreinfo data has the minimum debugging information only for dump filtering. makedumpfile (dump filtering command) gets it to distinguish unnecessary pages, and makedumpfile creates a small dumpfile.

An old makedumpfile (v1.2.4 or before) had assumed some values of page flags internally, and this implementation could not follow the change of these values. For example, Christoph Lameter is changing these values by the follwing patch:
http://lkml.org/lkml/2008/2/29/463

So a new makedumpfile (v1.2.5) came to need these values and I created this patch to let the kernel output them. This patch is for linux-2.6.25-rc7.

---
diff -rpuN linux-2.6.25-rc6.org/kernel/kexec.c linux-2.6.25-rc6/kernel/kexec.c

kernel/kexec.c static int __init crash_save_vmcoreinfo_ · line 1412

Quoted 7 lines
kernel/kexec.c +3 -0
@@ -1406,6 +1406,9 @@ static int __init crash_save_vmcoreinfo_
 	VMCOREINFO_LENGTH(zone.free_area, MAX_ORDER);
 	VMCOREINFO_LENGTH(free_area.free_list, MIGRATE_TYPES);
 	VMCOREINFO_NUMBER(NR_FREE_PAGES);
+	VMCOREINFO_NUMBER(PG_lru);
+	VMCOREINFO_NUMBER(PG_private);
+	VMCOREINFO_NUMBER(PG_swapcache);
 

Looks good to me.

Thanks
Vivek

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec