Skip to contentSkip to conversation

get_vfatname

PATCH New michael 2 participants 8 messages Mar 27, 2008 – Apr 4, 2008

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 get_vfatname

Quoted 3 lines · In message <[email protected]> you wrote:

I find a problem related to the get_vfatname function. This is my proposal patch.

What exactly is the preoblem? Is there a test case that can reproduce the problem?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Never give in.  Never give in.  Never. Never. Never."
- Winston Churchill
author
#2 lore raw

PATCH 1/1 get_vfatname

Hi,

Quoted 9 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:

I find a problem related to the get_vfatname function. This is my proposal patch.

What exactly is the preoblem? Is there a test case that can reproduce the problem?

My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.

The problem is that the code doesn't look if the dir_slot contain a long name.
If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the
linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.

Regards Michael

author
#3 lore raw

PATCH 1/1 get_vfatname

In reply to Wolfgang Denk

Hi,

Quoted 9 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:

I find a problem related to the get_vfatname function. This is my proposal patch.

What exactly is the preoblem? Is there a test case that can reproduce the problem?

My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.

The problem is that the code doesn't look if the dir_slot contain a long name.
If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the
linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.

Regards Michael

#4 lore raw

PATCH 1/1 get_vfatname

Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 4 lines

What exactly is the preoblem? Is there a test case that can reproduce the problem?

My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.

The problem is that the code doesn't look if the dir_slot contain a long name. If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.

Well, maybe you can give me a test case?

Like some script to create the needed directories / files in a VFAT file system which provokes the error?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A direct quote from the Boss: "We passed over a lot of good people to
get the ones we hired."
author
#5 lore raw

PATCH 1/1 get_vfatname

Quoted 15 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines

What exactly is the preoblem? Is there a test case that can reproduce the problem?

Quoted 8 lines

My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.

The problem is that the code doesn't look if the dir_slot contain a long name. If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.

Quoted 10 lines

Well, maybe you can give me a test case?

Like some script to create the needed directories / files in a VFAT file system which provokes the error?

Best regards,

Wolfgang Denk

I can give you an image that you can write on ide disk or on a Compact Flash.
Is ok?

Michael

#6 lore raw

PATCH 1/1 get_vfatname

Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Like some script to create the needed directories / files in a VFAT file system which provokes the error?

...

Quoted 3 lines

I can give you an image that you can write on ide disk or on a Compact Flash.
Is ok?

Actually I'd prefer a script to create such an image, but if this is impossible (?) then an image will do, too.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vulcans never bluff.
	-- Spock, "The Doomsday Machine", stardate 4202.1
author
#7 lore raw

PATCH 1/1 get_vfatname

Hi,

Quoted 7 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Like some script to create the needed directories / files in a VFAT file system which provokes the error?

...

Quoted 8 lines
Quoted 4 lines

I can give you an image that you can write on ide disk or on a Compact Flash.
Is ok?

Actually I'd prefer a script to create such an image, but if this is impossible (?) then an image will do, too.

Do you receive the link?

Regards
Michael