Skip to contentSkip to conversation

libata: fix IDENTIFY order in ata_bus_probe()

PATCH Applied Tejun Heo 2 participants 2 messages Apr 2, 2008 – Apr 4, 2008 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: fix IDENTIFY order in ata_bus_probe()

From: Bartlomiej Zolnierkiewicz <[email protected]>

Commit f58229f8060055b08b34008ea08f31de1e2f003c accidentally made ata_bus_probe() not use reverse order probing. Fix it.

There currently isn't any PATA driver which uses obsolete ata_bus_probe() path, so this patch is mainly for correctness.

---
drivers/ata/libata-core.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-core.c +0 -0
index 4851988..2db5c9c 100644
@@ -2660,7 +2660,7 @@ int ata_bus_probe(struct ata_port *ap)

specific sequence bass-ackwards so that PDIAG- is released by the slave device */

- ata_link_for_each_dev(dev, &ap->link) {

+	ata_link_for_each_dev_reverse(dev, &ap->link) {
		if (tries[dev->devno])
			dev->class = classes[dev->devno];
Applied
#1 lore raw
Quoted 19 lines · Tejun Heo

From: Bartlomiej Zolnierkiewicz <[email protected]>

Commit f58229f8060055b08b34008ea08f31de1e2f003c accidentally made ata_bus_probe() not use reverse order probing. Fix it.

There currently isn't any PATA driver which uses obsolete ata_bus_probe() path, so this patch is mainly for correctness.

---
drivers/ata/libata-core.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-core.c +0 -0
index 4851988..2db5c9c 100644

drivers/ata/libata-core.c int ata_bus_probe(struct ata_port *ap) · line 2666

Quoted 8 lines
drivers/ata/libata-core.c +1 -1
@@ -2660,7 +2660,7 @@ int ata_bus_probe(struct ata_port *ap)
       specific sequence bass-ackwards so that PDIAG- is released by
       the slave device */
 
-    ata_link_for_each_dev(dev, &ap->link) {
+    ata_link_for_each_dev_reverse(dev, &ap->link) {
        if (tries[dev->devno])
            dev->class = classes[dev->devno];
 

applied