Skip to contentSkip to conversation

pata_scc: fix compile warning

PATCH Applied Tejun Heo 2 participants 2 messages Mar 27, 2008 – Apr 4, 2008 1 message not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Tejun Heo

author
#1 lore raw

PATCH 1/1 pata_scc: fix compile warning

Missed one during mass conversion (dc14c0c5). Fix it. Spotted by Stephen Rothwell.

Signed-off-by Tejun Heo <[email protected]>
Cc Stephen Rothwell <[email protected]>

---

Quoted 1 line · Stephen Rothwell

Hi Jeff, Tejun (Heo? I am sorry if I chose the wrong name),

Yeap, Tejun is fine.

Quoted 6 lines

Today's build of linux-next produces this warning:

drivers/ata/pata_scc.c:1002: warning: initialization discards qualifiers from pointer target type

Presumably caused by commit dc14c0c5012855bfc9a5f76056b92f198d52834c ("libata: implement and use ops inheritance").

Thanks for spotting this. I couldn't compile test platform specific ones. Hmm... pata_scc doesn't seem to have platform dependencies, maybe we can drop PPC_CELLEB dependency.

drivers/ata/pata_scc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_scc.c +0 -0
index 07f2d7a..f6a6ce1 100644
@@ -960,7 +960,7 @@ static struct scsi_host_template scc_sht = {

ATA_BMDMA_SHT(DRV_NAME),
};

-static const struct ata_port_operations scc_pata_ops = {

+static struct ata_port_operations scc_pata_ops = {
	.inherits		= &ata_bmdma_port_ops,

	.set_piomode		= scc_set_piomode,
Applied
#2 lore raw
Quoted 30 lines · Tejun Heo

Missed one during mass conversion (dc14c0c5). Fix it. Spotted by Stephen Rothwell.

Signed-off-by Tejun Heo <[email protected]>
Cc Stephen Rothwell <[email protected]>

---

Quoted 1 line · Stephen Rothwell

Hi Jeff, Tejun (Heo? I am sorry if I chose the wrong name),

Yeap, Tejun is fine.

Quoted 6 lines

Today's build of linux-next produces this warning:

drivers/ata/pata_scc.c:1002: warning: initialization discards qualifiers from pointer target type

Presumably caused by commit dc14c0c5012855bfc9a5f76056b92f198d52834c ("libata: implement and use ops inheritance").

Thanks for spotting this. I couldn't compile test platform specific ones. Hmm... pata_scc doesn't seem to have platform dependencies, maybe we can drop PPC_CELLEB dependency.

drivers/ata/pata_scc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_scc.c +0 -0
index 07f2d7a..f6a6ce1 100644

drivers/ata/pata_scc.c static struct scsi_host_template scc_sht = { · line 965

Quoted 7 lines
drivers/ata/pata_scc.c +1 -1
@@ -960,7 +960,7 @@ static struct scsi_host_template scc_sht = {
    ATA_BMDMA_SHT(DRV_NAME),
 };
 
-static const struct ata_port_operations scc_pata_ops = {
+static struct ata_port_operations scc_pata_ops = {
    .inherits        = &ata_bmdma_port_ops,

applied