Skip to contentSkip to conversation

PS3: Fix gelic net module dependency

PATCH In review Geoff Levand 2 participants 2 messages Apr 9, 2008 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PS3: Fix gelic net module dependency

The PS3 gelic network driver depends on the wake-on-lan support provided by the PS3 sys manager driver. Add that dependency to the GELIC_NET Kconfig option.

Prevents these build errors:

ps3_gelic_net.c:1277: undefined reference to .ps3_sys_manager_get_wol' ps3_gelic_net.c:1337: undefined reference to .ps3_sys_manager_set_wol'

CC Masakazu Mokuno <[email protected]>
CC Jeff Garzik <[email protected]>

---
Hi Paul,

This fixes an error introduced in my 2.6.26 WOL patches now queued in your powerpc tree. Please apply.

-Geoff

 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +1 -0
@@ -2358,6 +2358,7 @@ config TSI108_ETH
 config GELIC_NET
 	tristate "PS3 Gigabit Ethernet driver"
 	depends on PPC_PS3
+	select PS3_SYS_MANAGER
 	help
 	  This driver supports the network device on the PS3 game
 	  console.  This driver has built-in support for Ethernet.
#1 lore raw
Quoted 26 lines · Geoff Levand

The PS3 gelic network driver depends on the wake-on-lan support provided by the PS3 sys manager driver. Add that dependency to the GELIC_NET Kconfig option.

Prevents these build errors:

ps3_gelic_net.c:1277: undefined reference to .ps3_sys_manager_get_wol' ps3_gelic_net.c:1337: undefined reference to .ps3_sys_manager_set_wol'

CC Masakazu Mokuno <[email protected]>
CC Jeff Garzik <[email protected]>

---
Hi Paul,

This fixes an error introduced in my 2.6.26 WOL patches now queued in your powerpc tree. Please apply.

(quoted diff) +0 -1
-Geoff
 
 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)

drivers/net/Kconfig config TSI108_ETH · line 2364

Quoted 7 lines
drivers/net/Kconfig +1 -0
@@ -2358,6 +2358,7 @@ config TSI108_ETH
 config GELIC_NET
 	tristate "PS3 Gigabit Ethernet driver"
 	depends on PPC_PS3
+	select PS3_SYS_MANAGER
 	help
 	  This driver supports the network device on the PS3 game
 	  console.  This driver has built-in support for Ethernet.

looks sane to me, but I do not have enough knowledge to ACK. Thanks for the CC :)