sata_svw: 0x0241 has 8 ports not 4

PATCH In review Tejun Heo 4 participants 6 messages Apr 10, 2008 – Apr 12, 2008 libata

lore

Share & tools

lore

Tejun Heo

author

2008-04-10 00:55 UTC #0 lore raw

PATCH 1/1 sata_svw: 0x0241 has 8 ports not 4

From: Yohei Honda <[email protected]>

0x0241 has 8 ports not 4.

Reported by Yohei Honda on kernel bz 10424.

Signed-off-by Tejun Heo <[email protected]>

Cc Benjamin Herrenschmidt <[email protected]>

---
Benjamin, can you please verify this is correct?

drivers/ata/sata_svw.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

drivers/ata/sata_svw.c +0 -0

index 840d1c4..75c6853 100644
@@ -531,7 +531,7 @@ static int k2_sata_init_one(struct pci_dev *pdev, const struct pci_device_id *en
 * */

static const struct pci_device_id k2_sata_pci_tbl[] = {
	{ PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
-	{ PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
+	{ PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
	{ PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
	{ PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
	{ PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },

Benjamin Herrenschmidt

2008-04-10 01:22 UTC #1 lore raw

Quoted 10 lines · Tejun Heo

From: Yohei Honda <[email protected]>
0x0241 has 8 ports not 4.
Reported by Yohei Honda on kernel bz 10424.
Signed-off-by Tejun Heo <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
---
Benjamin, can you please verify this is correct?

I can't as I don't have any spec for these... All I can say is that the Apple one has 4 ports and is is 0x0240.

So If you are reasonably confident the 0x0241 has 8, then feel free to apply the patch.

Cheers,
Ben.

Quoted 16 lines

 drivers/ata/sata_svw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/ata/sata_svw.c +1 -1

index 840d1c4..75c6853 100644
@@ -531,7 +531,7 @@ static int k2_sata_init_one(struct pci_dev *pdev, const struct pci_device_id *en
  * */
 static const struct pci_device_id k2_sata_pci_tbl[] = {
 	{ PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
-	{ PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
+	{ PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
 	{ PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
 	{ PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
 	{ PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },

Tejun Heo

author

2008-04-10 01:46 UTC #2 lore raw

Quoted 12 lines · Benjamin Herrenschmidt

Quoted 10 lines · Tejun Heo
From: Yohei Honda <[email protected]>
0x0241 has 8 ports not 4.
Reported by Yohei Honda on kernel bz 10424.
Signed-off-by Tejun Heo <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
---
Benjamin, can you please verify this is correct?

Quoted 5 lines

I can't as I don't have any spec for these... All I can say is that the Apple one has 4 ports and is is 0x0240.
So If you are reasonably confident the 0x0241 has 8, then feel free to apply the patch.

Hmmm.. Honda apparently has the hardware and this change works for him.
I think that should be good enough. Jeff, can you please merge this?

Thanks.

Signature · 1 line

tejun

Jeff Garzik

2008-04-11 22:24 UTC #3 lore raw

In reply to Tejun Heo

Quoted 23 lines · Tejun Heo

From: Yohei Honda <[email protected]>
0x0241 has 8 ports not 4.
Reported by Yohei Honda on kernel bz 10424.
Signed-off-by Tejun Heo <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
---
Benjamin, can you please verify this is correct?
drivers/ata/sata_svw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_svw.c +0 -0
index 840d1c4..75c6853 100644
@@ -531,7 +531,7 @@ static int k2_sata_init_one(struct pci_dev *pdev, 
const struct pci_device_id *en
* */
static const struct pci_device_id k2_sata_pci_tbl[] = {
    { PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },

drivers/ata/sata_svw.c

Quoted 5 lines

drivers/ata/sata_svw.c +1 -1

-    { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
+    { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
    { PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
    { PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
    { PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },

This is wrong according to my docs.

Anantha, can you provide a definitive answer?

Does PCI ID 0x241 support 4 ports or 8 ports?

Thanks,

Jeff

Anantha Subramanyam

2008-04-12 01:10 UTC #4 lore raw

Quoted 43 lines

-----Original Message-----
From: Jeff Garzik [mailto:[email protected]]
Sent: Friday, April 11, 2008 3:25 PM
To: Tejun Heo
Cc: IDE/ATA development list; [email protected]; Benjamin Herrenschmidt; Anantha Subramanyam
Subject: Re: [PATCH] sata_svw: 0x0241 has 8 ports not 4
drivers/ata/sata_svw.c static int k2_sata_init_one(struct
Quoted 19 lines · Tejun Heo
From: Yohei Honda <[email protected]>
0x0241 has 8 ports not 4.
Reported by Yohei Honda on kernel bz 10424.
Signed-off-by Tejun Heo <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
---
Benjamin, can you please verify this is correct?
drivers/ata/sata_svw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_svw.c +0 -0
index 840d1c4..75c6853 100644
@@ -531,7 +531,7 @@ static int k2_sata_init_one(struct 
pci_dev *pdev,
drivers/ata/sata_svw.c
Quoted 9 lines
const struct pci_device_id *en
* */
static const struct pci_device_id k2_sata_pci_tbl[] = {
    { PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
drivers/ata/sata_svw.c +1 -1
-    { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
+    { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
    { PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
    { PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
    { PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },
This is wrong according to my docs.

Quoted 9 lines

Anantha, can you provide a definitive answer?
Does PCI ID 0x241 support 4 ports or 8 ports?
Thanks,
Jeff

0x241 is 8 ports
0x242 is 4 ports

Thanks,

Ananth

Jeff Garzik

2008-04-12 01:39 UTC #5 lore raw

Quoted 2 lines · Anantha Subramanyam

0x241 is 8 ports
0x242 is 4 ports

Thanks!

Jeff