Skip to contentSkip to conversation

UCB1400 IRQ Probe fix

PATCH Applied Vernon Sauder 2 participants 2 messages Apr 10, 2008 – Apr 21, 2008 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 UCB1400 IRQ Probe fix

The UCB1400 driver IRQ probe code fails to find an interrupt if all the interrupts in the range 0-31 are nonprobe-able. This patch removes the check of the return value so interrupts above 31 can be detected.

This change may also be useful in drivers/mfd/ucb1x0-core.c but I cannot test that on my hardware.

This patch is against 2.6.24.4. Tested on InHand Fingertip4 PXA270 board.

diff -ur linux.orig/drivers/input/touchscreen/ucb1400_ts.c linux.new/drivers/input/touchscreen/ucb1400_ts.c
--- linux.orig/drivers/input/touchscreen/ucb1400_ts.c 2008-03-24
14:49:18.000000000 -0400
+++ linux.new/drivers/input/touchscreen/ucb1400_ts.c 2008-04-03
21:40:43.000000000 -0400
@@ -429,10 +429,6 @@
unsigned long mask, timeout;

mask = probe_irq_on();
- if (!mask) {
- probe_irq_off(mask);
- return -EBUSY;
- }

  	/* Enable the ADC interrupt. */
  	ucb1400_reg_write(ucb, UCB_IE_RIS, UCB_IE_ADC);
#1 lore raw
Quoted 5 lines · Vernon Sauder

The UCB1400 driver IRQ probe code fails to find an interrupt if all the interrupts in the range 0-31 are nonprobe-able. This patch removes the check of the return value so interrupts above 31 can be detected.

Quoted 9 lines

This change may also be useful in drivers/mfd/ucb1x0-core.c but I cannot test that on my hardware.

This patch is against 2.6.24.4. Tested on InHand Fingertip4 PXA270 board.

Applied, thank you Vernon.

Signature · 1 line
Dmitry