Skip to contentSkip to conversation

Flash on LocalBus @ MPC8343

DISCUSSION Andre Schwarz 3 participants 9 messages Apr 11, 2008 – Apr 15, 2008

lore
Share & tools
lore

Andre Schwarz

author
#0 lore raw

Hi all,

I've been trying hard to make the mtd-partitions available via device tree on my MPC8343 local bus. No success so far ...

Everything works fine on my MPC5200B based system - flash layout definition is quite simple ....

To me it looks like there's a problem regarding the local bus in general.

Am I missing a "compatible" or anything else ? "reg" or "ranges" ?

The other boards use static map files or provide partition over command line args .... so suitable dts available.

Flash is 8MB size in 16-Bit configuration and should reside on 0xFF800000 at cs0.

Any hints ?

regards,
Andre Schwarz
Matrix Vision

dts syntax :

<snip>

       localbus@e0005000 {
               #address-cells = <2>;
               #size-cells = <1>;
               compatible = "fsl,mpc8343-localbus", "fsl,pq2pro-localbus";

               ranges = <0x0 0x0 0xff800000 0x00800000>;

               flash@0,0 {
                       compatible = "amd,s29gl64", "cfi-flash";
                       reg = <0 0 800000>;
                       #address-cells = <1>;
                       #size-cells = <1>;
                       bank-width = <2>;
                       device-width = <2>;

                       ppcboot_env@0 {
                               reg = <0x0 0x2000>;
                       };

<snip>

MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#1 lore raw
Quoted 32 lines · Andre Schwarz

Hi all,

I've been trying hard to make the mtd-partitions available via device tree on my MPC8343 local bus.
No success so far ...

Everything works fine on my MPC5200B based system - flash layout definition is quite simple ....

To me it looks like there's a problem regarding the local bus in general.

Am I missing a "compatible" or anything else ? "reg" or "ranges" ?

The other boards use static map files or provide partition over command line args .... so suitable dts available.

Flash is 8MB size in 16-Bit configuration and should reside on 0xFF800000 at cs0.

Any hints ?

regards,
Andre Schwarz
Matrix Vision

dts syntax :

<snip>

Quoted 10 lines
        localbus@e0005000 {
                #address-cells = <2>;
                #size-cells = <1>;
                compatible = "fsl,mpc8343-localbus", "fsl,pq2pro-localbus";

                ranges = <0x0 0x0 0xff800000 0x00800000>;

                flash@0,0 {
                        compatible = "amd,s29gl64", "cfi-flash";
                        reg = <0 0 800000>;

reg should be <0 0 0x800000>.

Quoted 8 lines
                        #address-cells = <1>;
                        #size-cells = <1>;
                        bank-width = <2>;
                        device-width = <2>;

                        ppcboot_env@0 {
                                reg = <0x0 0x2000>;
                        };
Signature · 9 lines
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75
#2 lore raw
In reply to Andre Schwarz
Quoted 3 lines · Andre Schwarz

To me it looks like there's a problem regarding the local bus in general.

Am I missing a "compatible" or anything else ? "reg" or "ranges" ?

Do you have an of_bus_ids[] entry that covers the localbus?

-Scott

author
#3 lore raw

Scott,

thanks for your help ... but

Quoted 10 lines · Scott Wood
Quoted 4 lines · Andre Schwarz

To me it looks like there's a problem regarding the local bus in general.

Am I missing a "compatible" or anything else ? "reg" or "ranges" ?

Do you have an of_bus_ids[] entry that covers the localbus?

what's this ?
Where do I need to define this ? In dts or platform code ?

Can you give an example ?

regards,
André

Quoted 6 lines

-Scott
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#4 lore raw
Quoted 9 lines · André Schwarz

Scott,

thanks for your help ... but

Quoted 4 lines · Scott Wood
Quoted 2 lines · Andre Schwarz

To me it looks like there's a problem regarding the local bus in general.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Am I missing a "compatible" or anything else ? "reg" or "ranges" ?

Do you have an of_bus_ids[] entry that covers the localbus?

what's this ?
Where do I need to define this ? In dts or platform code ?

Platform code.

Quoted 2 lines

Can you give an example ?

mpc8313erdb. simple-bus is listed as a compatible for the localbus in the dts, and it is listed of_bus_ids[] in the platform file.

-Scott

author
#5 lore raw

Scott,

thanks , but ... can't find "of_bus_ids[]" entry.
I'm obviously out of sync. My last git-pull from denx is 3 days old, now=20
- need to update on monday.

It seems hard for "normal" people to keep up these days !

Cheers,
Andr=C3=A9

Quoted 23 lines · Scott Wood
Quoted 10 lines · Andr=C3=A9 Schwarz wrote:

Scott,

thanks for your help ... but

Quoted 5 lines · Scott Wood

On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote:
=20

Quoted 3 lines

To me it looks like there's a problem regarding the local bus in=20 general.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Am I missing a "compatible" or anything else ? "reg" or "ranges" ?
=20

Do you have an of_bus_ids[] entry that covers the localbus?

=20

what's this ?
Where do I need to define this ? In dts or platform code ?

Platform code.

Quoted 1 line
Quoted 6 lines
Quoted 1 line

Can you give an example ?

mpc8313erdb. simple-bus is listed as a compatible for the localbus in=20 the dts, and it is listed of_bus_ids[] in the platform file.

-Scott

MATRIX VISION GmbH, Talstra=DFe 16, DE-71570 Oppenweiler - Registergeric=
ht: Amtsgericht Stuttgart, HRB 271090
Gesch=E4ftsf=FChrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#6 lore raw
Quoted 1 line · André Schwarz

thanks , but ... can't find "of_bus_ids[]" entry.

That means your platform likely isn't calling of_platform_bus_probe() at all. Look at other platforms, such as mpc831x_rdb, for an example.

Quoted 2 lines

I'm obviously out of sync. My last git-pull from denx is 3 days old, now
- need to update on monday.

For Denx-specific support, please contact Denx.

This certainly isn't something that was added in the past 3 days.

-Scott

author
#7 lore raw

Scott,

there has been a "compatible=soc" in my of_bus_id[] ... It was taken from mpc834x_mds some weeks ago.

I changed to :

static struct of_device_id __initdata of_bus_ids[] = {
       { .compatible = "fsl,pq2pro-localbus", },
       {},
};

now it works fine.

Thanks !

Andre

Quoted 15 lines · Scott Wood
Quoted 2 lines · André Schwarz

thanks , but ... can't find "of_bus_ids[]" entry.

That means your platform likely isn't calling of_platform_bus_probe() at all. Look at other platforms, such as mpc831x_rdb, for an example.

Quoted 3 lines

I'm obviously out of sync. My last git-pull from denx is 3 days old, now
- need to update on monday.

For Denx-specific support, please contact Denx.

Quoted 8 lines

This certainly isn't something that was added in the past 3 days.

-Scott
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#8 lore raw
Quoted 11 lines · Andre Schwarz

Scott,

there has been a "compatible=soc" in my of_bus_id[] ... It was taken from mpc834x_mds some weeks ago.

I changed to :

static struct of_device_id __initdata of_bus_ids[] = {
       { .compatible = "fsl,pq2pro-localbus", },
       {},
};

Don't get rid of the soc line, though -- both should be present.

-Scott