Skip to contentSkip to conversation

powerpc/perf: Disable trace_imc pmu

PATCH Applied Madhavan Srinivasan 3 participants 3 messages Nov 18, 2019 – Dec 9, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 powerpc/perf: Disable trace_imc pmu

When a root user or a user with CAP_SYS_ADMIN privilege use trace_imc performance monitoring unit events, to monitor application or KVM threads, may result in a checkstop (System crash). Reason being frequent switch of the "trace/accumulation" mode of In-Memory Collection hardware.
This patch disables trace_imc pmu unit, but will be re-enabled at a later stage with a fix patchset.

Fixes 012ae244845f1 ('powerpc/perf: Trace imc PMU functions')

---
Changelog v1:
- Added fixes and signed-off by.

 arch/powerpc/platforms/powernv/opal-imc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
arch/powerpc/platforms/powernv/opal-imc.c +6 -1
index e04b20625cb9..5790f078771f 100644
@@ -285,7 +285,12 @@ static int opal_imc_counters_probe(struct platform_device *pdev)
 			domain = IMC_DOMAIN_THREAD;
 			break;
 		case IMC_TYPE_TRACE:
-			domain = IMC_DOMAIN_TRACE;
+			/* Using trace_imc events to monitor
+			 * application or KVM thread performances
+			 * may result in a checkstop (system crash).
+			 * So disabling it for now.
+			 */
+			domain = -1;
 			break;
 		default:
 			pr_warn("IMC Unknown Device type \n");
Signature · 1 line
2.21.0
Tested-by Hariharan T.S. on v2 1/1
#1 lore raw
Quoted 11 lines · Madhavan Srinivasan

When a root user or a user with CAP_SYS_ADMIN privilege use trace_imc performance monitoring unit events, to monitor application or KVM threads, may result in a checkstop (System crash). Reason being frequent switch of the "trace/accumulation" mode of In-Memory Collection hardware.
This patch disables trace_imc pmu unit, but will be re-enabled at a later stage with a fix patchset.

Fixes 012ae244845f1 ('powerpc/perf: Trace imc PMU functions')
Quoted 25 lines

---
Changelog v1:
- Added fixes and signed-off by.

  arch/powerpc/platforms/powernv/opal-imc.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
arch/powerpc/platforms/powernv/opal-imc.c +6 -1
index e04b20625cb9..5790f078771f 100644
@@ -285,7 +285,12 @@ static int opal_imc_counters_probe(struct platform_device *pdev)
  			domain = IMC_DOMAIN_THREAD;
  			break;
  		case IMC_TYPE_TRACE:
-			domain = IMC_DOMAIN_TRACE;
+			/* Using trace_imc events to monitor
+			 * application or KVM thread performances
+			 * may result in a checkstop (system crash).
+			 * So disabling it for now.
+			 */
+			domain = -1;
  			break;
  		default:
  			pr_warn("IMC Unknown Device type \n");
#2 lore raw
In reply to Madhavan Srinivasan
Quoted 11 lines · Madhavan Srinivasan

When a root user or a user with CAP_SYS_ADMIN privilege use trace_imc performance monitoring unit events, to monitor application or KVM threads, may result in a checkstop (System crash). Reason being frequent switch of the "trace/accumulation" mode of In-Memory Collection hardware.
This patch disables trace_imc pmu unit, but will be re-enabled at a later stage with a fix patchset.

Fixes 012ae244845f1 ('powerpc/perf: Trace imc PMU functions')

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/249fad734a25889a4f23ed014d43634af6798063

cheers