tools/bpftool: fix error return value in build_btf_type_table()
Subsystems (4)
PATCH 1/1 tools/bpftool: fix error return value in build_btf_type_table()
An appropriate return value should be set on the failed path.
Reported-by Hulk Robot <[email protected]>
Signed-off-by Zhen Lei <[email protected]>
--- tools/bpf/bpftool/btf.c | 1 + 1 file changed, 1 insertion(+)
tools/bpf/bpftool/btf.c +1 -0
@@ -693,6 +693,7 @@ build_btf_type_table(struct btf_attach_table *tab, enum bpf_obj_type type, obj_node =calloc (1 ,sizeof (*obj_node));if (!obj_node) {p_err ("failed to allocate memory: %s" ,strerror (errno)); + err = -ENOMEM ; goto err_free; }
Signature · 1 line
2.26.0.106.g9fadedd
Quoted 4 lines · Zhen Lei
An appropriate return value should be set on the failed path.
Reported-by Hulk Robot <[email protected]>Signed-off-by Zhen Lei <[email protected]>
LGTM.
Acked-by Yonghong Song <[email protected]>
Also this is a bug fix. It should probably be targeted to bpf tree. So,
Fixes 4d374ba0bf30 ("tools: bpftool: implement "bpftool btf show|list"")
Quoted 17 lines
--- tools/bpf/bpftool/btf.c | 1 + 1 file changed, 1 insertion(+)tools/bpf/bpftool/btf.c +1
-0@@ -693,6 +693,7 @@ build_btf_type_table(struct btf_attach_table *tab, enum bpf_obj_type type, obj_node =calloc (1 ,sizeof (*obj_node));if (!obj_node) {p_err ("failed to allocate memory: %s" ,strerror (errno)); + err = -ENOMEM ; goto err_free; }
This patch was applied to bpf/bpf.git (refs/heads/master):
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
Quoted 7 lines · On Tue, 24 Nov 2020 18:41:00 +0800 you wrote:
An appropriate return value should be set on the failed path.
Reported-by Hulk Robot <[email protected]>Signed-off-by Zhen Lei <[email protected]>--- tools/bpf/bpftool/btf.c | 1 + 1 file changed, 1 insertion(+)
Here is the summary with links:
- [1/1] tools/bpftool: fix error return value in build_btf_type_table()
https://git.kernel.org/bpf/bpf/c/68878a5c5b85
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html