drm/sched: Add device pointer to drm_gpu_scheduler
Subsystems (8)
PATCH 1/1 drm/sched: Add device pointer to drm_gpu_scheduler
Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario.
v2: amend all calls of drm_sched_init()
v3: fill dev pointer for all drm_sched_init() calls
--- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- drivers/gpu/drm/etnaviv/etnaviv_sched.c | 2 +- drivers/gpu/drm/lima/lima_sched.c | 2 +- drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- drivers/gpu/drm/scheduler/sched_main.c | 9 +++++---- drivers/gpu/drm/v3d/v3d_sched.c | 10 +++++----- include/drm/gpu_scheduler.h | 3 ++- 7 files changed, 16 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +1 -1
@@ -502,7 +502,7 @@ int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring, r =drm_sched_init (&ring->sched, &amdgpu_sched_ops, num_hw_submission, amdgpu_job_hang_limit, - timeout,NULL , sched_score, ring->name); + timeout,NULL , sched_score, ring->name, adev->dev);if (r) {DRM_ERROR ("Failed to create scheduler on ring %s.\n" , ring->name);
drivers/gpu/drm/etnaviv/etnaviv_sched.c +1 -1
@@ -195,7 +195,7 @@ int etnaviv_sched_init(struct etnaviv_gpu *gpu) ret =drm_sched_init (&gpu->sched, &etnaviv_sched_ops, etnaviv_hw_jobs_limit, etnaviv_job_hang_limit,msecs_to_jiffies (500 ),NULL ,NULL , -dev_name (gpu->dev)); +dev_name (gpu->dev), gpu->dev);if (ret)return ret;
drivers/gpu/drm/lima/lima_sched.c +1 -1
@@ -490,7 +490,7 @@ int lima_sched_pipe_init(struct lima_sched_pipe *pipe, const char *name)return drm_sched_init (&pipe->base, &lima_sched_ops,1 , lima_job_hang_limit,msecs_to_jiffies (timeout),NULL , -NULL , name); +NULL , name, pipe->ldev->dev); }void lima_sched_pipe_fini (struct lima_sched_pipe *pipe)
drivers/gpu/drm/panfrost/panfrost_job.c +1 -1
@@ -812,7 +812,7 @@ int panfrost_job_init(struct panfrost_device *pfdev) nentries,0 ,msecs_to_jiffies (JOB_TIMEOUT_MS ), pfdev->reset.wq, - NULL, "pan_js"); + NULL, "pan_js", pfdev->dev);if (ret) {dev_err (pfdev->dev,"Failed to create scheduler: %d." , ret); goto err_sched;
drivers/gpu/drm/scheduler/sched_main.c +5 -4
@@ -491,7 +491,7 @@ void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery)if (r == -ENOENT )drm_sched_job_done (s_job);else if (r) -DRM_ERROR ("fence add callback failed (%d)\n" , +DRM_DEV_ERROR (sched->dev,"fence add callback failed (%d)\n" , r); }else drm_sched_job_done (s_job);
@@ -957,7 +957,7 @@ static int drm_sched_main(void *param)if (r == -ENOENT )drm_sched_job_done (sched_job);else if (r) -DRM_ERROR ("fence add callback failed (%d)\n" , +DRM_DEV_ERROR (sched->dev,"fence add callback failed (%d)\n" , r);dma_fence_put (fence); }else {
@@ -991,7 +991,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,const struct drm_sched_backend_ops *ops, unsigned hw_submission, unsigned hang_limit, long timeout, struct workqueue_struct *timeout_wq, - atomic_t *score, const char *name) + atomic_t *score, const char *name, struct device *dev) { int i, ret; sched->ops = ops;
@@ -1001,6 +1001,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, sched->timeout_wq = timeout_wq ? : system_wq; sched->hang_limit = hang_limit; sched->score = score ? score : &sched->_score; + sched->dev = dev;for (i =DRM_SCHED_PRIORITY_MIN ; i <DRM_SCHED_PRIORITY_COUNT ; i++)drm_sched_rq_init (sched, &sched->sched_rq[i]);
@@ -1018,7 +1019,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,if (IS_ERR (sched->thread)) { ret =PTR_ERR (sched->thread); sched->thread =NULL ; -DRM_ERROR ("Failed to create scheduler for %s.\n" , name); +DRM_DEV_ERROR (sched->dev,"Failed to create scheduler for %s.\n" , name);return ret; }
drivers/gpu/drm/v3d/v3d_sched.c +5 -5
@@ -391,7 +391,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_bin_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_bin"); + NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create bin scheduler: %d." , ret);return ret;
@@ -401,7 +401,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_render_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_render"); + NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create render scheduler: %d." , ret);
@@ -413,7 +413,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_tfu_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_tfu"); + NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create TFU scheduler: %d." , ret);
@@ -426,7 +426,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_csd_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_csd"); + NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create CSD scheduler: %d." , ret);
@@ -438,7 +438,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_cache_clean_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_cache_clean"); + NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create CACHE_CLEAN scheduler: %d." , ret);
include/drm/gpu_scheduler.h +2 -1
@@ -457,13 +457,14 @@ struct drm_gpu_scheduler {atomic_t _score;bool ready;bool free_guilty; +struct device *dev; };int drm_sched_init (struct drm_gpu_scheduler *sched,const struct drm_sched_backend_ops *ops,uint32_t hw_submission,unsigned hang_limit,long timeout,struct workqueue_struct *timeout_wq, -atomic_t *score,const char *name); +atomic_t *score,const char *name,struct device *dev);void drm_sched_fini (struct drm_gpu_scheduler *sched); int drm_sched_job_init(struct drm_sched_job *job,
Signature · 1 line
2.17.1
Am 21.02.22 um 10:57 schrieb Jiawei Gu:
Quoted 8 lines
Add device pointer so scheduler's printing can use
DRM_DEV_ERROR()instead, which makes life easier under multiple GPU scenario.v2: amend all calls of
drm_sched_init()
v3: fill dev pointer for alldrm_sched_init()callsSigned-off-by Jiawei Gu <[email protected]>
When Andrey is fine with that as well I think the best approach is to push this upstream through drm-misc-next since it touches multiple drivers.
We can merge it into the DKMS branch as well if necessary.
Regards,
Christian
Quoted 179 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- drivers/gpu/drm/etnaviv/etnaviv_sched.c | 2 +- drivers/gpu/drm/lima/lima_sched.c | 2 +- drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- drivers/gpu/drm/scheduler/sched_main.c | 9 +++++---- drivers/gpu/drm/v3d/v3d_sched.c | 10 +++++----- include/drm/gpu_scheduler.h | 3 ++- 7 files changed, 16 insertions(+), 14 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +1
-1@@ -502,7 +502,7 @@ int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring, r =drm_sched_init (&ring->sched, &amdgpu_sched_ops, num_hw_submission, amdgpu_job_hang_limit, - timeout,NULL , sched_score, ring->name); + timeout,NULL , sched_score, ring->name, adev->dev);if (r) {DRM_ERROR ("Failed to create scheduler on ring %s.\n" , ring->name);drivers/gpu/drm/etnaviv/etnaviv_sched.c +1
-1@@ -195,7 +195,7 @@ int etnaviv_sched_init(struct etnaviv_gpu *gpu) ret =drm_sched_init (&gpu->sched, &etnaviv_sched_ops, etnaviv_hw_jobs_limit, etnaviv_job_hang_limit,msecs_to_jiffies (500 ),NULL ,NULL , -dev_name (gpu->dev)); +dev_name (gpu->dev), gpu->dev);if (ret)return ret;drivers/gpu/drm/lima/lima_sched.c +1
-1@@ -490,7 +490,7 @@ int lima_sched_pipe_init(struct lima_sched_pipe *pipe, const char *name)return drm_sched_init (&pipe->base, &lima_sched_ops,1 , lima_job_hang_limit,msecs_to_jiffies (timeout),NULL , -NULL , name); +NULL , name, pipe->ldev->dev); }void lima_sched_pipe_fini (struct lima_sched_pipe *pipe)drivers/gpu/drm/panfrost/panfrost_job.c +1
-1@@ -812,7 +812,7 @@ int panfrost_job_init(struct panfrost_device *pfdev) nentries,0 ,msecs_to_jiffies (JOB_TIMEOUT_MS ), pfdev->reset.wq, - NULL, "pan_js"); + NULL, "pan_js", pfdev->dev);if (ret) {dev_err (pfdev->dev,"Failed to create scheduler: %d." , ret); goto err_sched;drivers/gpu/drm/scheduler/sched_main.c +5
-4@@ -491,7 +491,7 @@ void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery)if (r == -ENOENT )drm_sched_job_done (s_job);else if (r) -DRM_ERROR ("fence add callback failed (%d)\n" , +DRM_DEV_ERROR (sched->dev,"fence add callback failed (%d)\n" , r); }else drm_sched_job_done (s_job);@@ -957,7 +957,7 @@ static int drm_sched_main(void *param)if (r == -ENOENT )drm_sched_job_done (sched_job);else if (r) -DRM_ERROR ("fence add callback failed (%d)\n" , +DRM_DEV_ERROR (sched->dev,"fence add callback failed (%d)\n" , r);dma_fence_put (fence); }else {@@ -991,7 +991,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,const struct drm_sched_backend_ops *ops, unsigned hw_submission, unsigned hang_limit, long timeout, struct workqueue_struct *timeout_wq, - atomic_t *score, const char *name) + atomic_t *score, const char *name, struct device *dev) { int i, ret; sched->ops = ops;@@ -1001,6 +1001,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, sched->timeout_wq = timeout_wq ? : system_wq; sched->hang_limit = hang_limit; sched->score = score ? score : &sched->_score; + sched->dev = dev;for (i =DRM_SCHED_PRIORITY_MIN ; i <DRM_SCHED_PRIORITY_COUNT ; i++)drm_sched_rq_init (sched, &sched->sched_rq[i]);@@ -1018,7 +1019,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,if (IS_ERR (sched->thread)) { ret =PTR_ERR (sched->thread); sched->thread =NULL ; -DRM_ERROR ("Failed to create scheduler for %s.\n" , name); +DRM_DEV_ERROR (sched->dev,"Failed to create scheduler for %s.\n" , name);return ret; }drivers/gpu/drm/v3d/v3d_sched.c +5
-5@@ -391,7 +391,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_bin_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_bin"); + NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create bin scheduler: %d." , ret);return ret;@@ -401,7 +401,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_render_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_render"); + NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create render scheduler: %d." , ret);@@ -413,7 +413,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_tfu_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_tfu"); + NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create TFU scheduler: %d." , ret);@@ -426,7 +426,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_csd_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_csd"); + NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create CSD scheduler: %d." , ret);@@ -438,7 +438,7 @@ v3d_sched_init(struct v3d_dev *v3d) &v3d_cache_clean_sched_ops, hw_jobs_limit, job_hang_limit,msecs_to_jiffies (hang_limit_ms),NULL , - NULL, "v3d_cache_clean"); + NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev));if (ret) {dev_err (v3d->drm.dev,"Failed to create CACHE_CLEAN scheduler: %d." , ret);include/drm/gpu_scheduler.h +2
-1@@ -457,13 +457,14 @@ struct drm_gpu_scheduler {atomic_t _score;bool ready;bool free_guilty; +struct device *dev; };int drm_sched_init (struct drm_gpu_scheduler *sched,const struct drm_sched_backend_ops *ops,uint32_t hw_submission,unsigned hang_limit,long timeout,struct workqueue_struct *timeout_wq, -atomic_t *score,const char *name); +atomic_t *score,const char *name,struct device *dev);void drm_sched_fini (struct drm_gpu_scheduler *sched); int drm_sched_job_init(struct drm_sched_job *job,
kernel test robot
build botThank you for the patch! Yet something to improve:
Hi Jiawei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 base: git://anongit.freedesktop.org/drm/drm drm-next config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220221/[email protected]/config) compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9fdafca855faca0a3b8f213f024985c4112fa0bb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818
git checkout 9fdafca855faca0a3b8f213f024985c4112fa0bb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/gpu/drm/msm/ drivers/gpu/drm/v3d/
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
drivers/gpu/drm/msm/msm_ringbuffer.c: In function 'msm_ringbuffer_new':
>> drivers/gpu/drm/msm/msm_ringbuffer.c:90:15: error: too few arguments to function 'drm_sched_init'
90 | ret = drm_sched_init(&ring->sched, &msm_sched_ops,
| ^~~~~~~~~~~~~~ In file included from drivers/gpu/drm/msm/msm_ringbuffer.h:10,
from drivers/gpu/drm/msm/msm_ringbuffer.c:7:
include/drm/gpu_scheduler.h:463:5: note: declared here
463 | int drm_sched_init(struct drm_gpu_scheduler *sched,
| ^~~~~~~~~~~~~~
--
In file included from drivers/gpu/drm/v3d/v3d_sched.c:23:
drivers/gpu/drm/v3d/v3d_sched.c: In function 'v3d_sched_init':
>> drivers/gpu/drm/v3d/v3d_drv.h:158:26: error: implicit declaration of function 'to_platform_device' [-Werror=implicit-function-declaration]
158 | #define v3d_to_pdev(v3d) to_platform_device((v3d)->drm.dev)
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/v3d/v3d_sched.c:394:49: note: in expansion of macro 'v3d_to_pdev'
394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev));
| ^~~~~~~~~~~
>> drivers/gpu/drm/v3d/v3d_sched.c:394:65: error: invalid type argument of '->' (have 'int')
394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev));
| ^~
drivers/gpu/drm/v3d/v3d_sched.c:404:68: error: invalid type argument of '->' (have 'int')
404 | NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev));
| ^~
drivers/gpu/drm/v3d/v3d_sched.c:416:65: error: invalid type argument of '->' (have 'int')
416 | NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev));
| ^~
drivers/gpu/drm/v3d/v3d_sched.c:429:73: error: invalid type argument of '->' (have 'int')
429 | NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev));
| ^~
drivers/gpu/drm/v3d/v3d_sched.c:441:81: error: invalid type argument of '->' (have 'int')
441 | NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev));
| ^~cc1: some warnings being treated as errors
vim +/drm_sched_init +90 drivers/gpu/drm/msm/msm_ringbuffer.c
1d8a5ca436ee4a Rob Clark 2021-07-27 47
f97decac5f4c2d Jordan Crouse 2017-10-20 48 struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id,
f97decac5f4c2d Jordan Crouse 2017-10-20 49 void *memptrs, uint64_t memptrs_iova)
7198e6b03155f6 Rob Clark 2013-07-19 50 {
7198e6b03155f6 Rob Clark 2013-07-19 51 struct msm_ringbuffer *ring;
1d8a5ca436ee4a Rob Clark 2021-07-27 52 long sched_timeout;
f97decac5f4c2d Jordan Crouse 2017-10-20 53 char name[32];
7198e6b03155f6 Rob Clark 2013-07-19 54 int ret;
7198e6b03155f6 Rob Clark 2013-07-19 55
f97decac5f4c2d Jordan Crouse 2017-10-20 56 /* We assume everwhere that MSM_GPU_RINGBUFFER_SZ is a power of 2 */
f97decac5f4c2d Jordan Crouse 2017-10-20 57 BUILD_BUG_ON(!is_power_of_2(MSM_GPU_RINGBUFFER_SZ));
7198e6b03155f6 Rob Clark 2013-07-19 58
7198e6b03155f6 Rob Clark 2013-07-19 59 ring = kzalloc(sizeof(*ring), GFP_KERNEL);
7198e6b03155f6 Rob Clark 2013-07-19 60 if (!ring) {
7198e6b03155f6 Rob Clark 2013-07-19 61 ret = -ENOMEM;
7198e6b03155f6 Rob Clark 2013-07-19 62 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 63 }
7198e6b03155f6 Rob Clark 2013-07-19 64
7198e6b03155f6 Rob Clark 2013-07-19 65 ring->gpu = gpu;
f97decac5f4c2d Jordan Crouse 2017-10-20 66 ring->id = id;
84c6127580c1ce Jordan Crouse 2018-11-07 67
f97decac5f4c2d Jordan Crouse 2017-10-20 68 ring->start = msm_gem_kernel_new(gpu->dev, MSM_GPU_RINGBUFFER_SZ,
604234f33658cd Jordan Crouse 2020-09-03 69 check_apriv(gpu, MSM_BO_WC | MSM_BO_GPU_READONLY),
604234f33658cd Jordan Crouse 2020-09-03 70 gpu->aspace, &ring->bo, &ring->iova);
8223286d62e296 Jordan Crouse 2017-07-27 71
69a834c28fb514 Rob Clark 2016-05-24 72 if (IS_ERR(ring->start)) {
69a834c28fb514 Rob Clark 2016-05-24 73 ret = PTR_ERR(ring->start);
375f9a63a66bae Rob Clark 2021-07-27 74 ring->start = NULL;
69a834c28fb514 Rob Clark 2016-05-24 75 goto fail;
69a834c28fb514 Rob Clark 2016-05-24 76 }
0815d7749a6852 Jordan Crouse 2018-11-07 77
0815d7749a6852 Jordan Crouse 2018-11-07 78 msm_gem_object_set_name(ring->bo, "ring%d", id);
0815d7749a6852 Jordan Crouse 2018-11-07 79
f97decac5f4c2d Jordan Crouse 2017-10-20 80 ring->end = ring->start + (MSM_GPU_RINGBUFFER_SZ >> 2);
4c7085a5d581a5 Jordan Crouse 2017-10-20 81 ring->next = ring->start;
7198e6b03155f6 Rob Clark 2013-07-19 82 ring->cur = ring->start;
7198e6b03155f6 Rob Clark 2013-07-19 83
f97decac5f4c2d Jordan Crouse 2017-10-20 84 ring->memptrs = memptrs;
f97decac5f4c2d Jordan Crouse 2017-10-20 85 ring->memptrs_iova = memptrs_iova;
f97decac5f4c2d Jordan Crouse 2017-10-20 86
1d8a5ca436ee4a Rob Clark 2021-07-27 87 /* currently managing hangcheck ourselves: */
1d8a5ca436ee4a Rob Clark 2021-07-27 88 sched_timeout = MAX_SCHEDULE_TIMEOUT;
1d8a5ca436ee4a Rob Clark 2021-07-27 89
1d8a5ca436ee4a Rob Clark 2021-07-27 @90 ret = drm_sched_init(&ring->sched, &msm_sched_ops,
1d8a5ca436ee4a Rob Clark 2021-07-27 91 num_hw_submissions, 0, sched_timeout,
f1b7996551a40a Dave Airlie 2021-07-30 92 NULL, NULL, to_msm_bo(ring->bo)->name);
1d8a5ca436ee4a Rob Clark 2021-07-27 93 if (ret) {
1d8a5ca436ee4a Rob Clark 2021-07-27 94 goto fail;
1d8a5ca436ee4a Rob Clark 2021-07-27 95 }
1d8a5ca436ee4a Rob Clark 2021-07-27 96
f97decac5f4c2d Jordan Crouse 2017-10-20 97 INIT_LIST_HEAD(&ring->submits);
77d205290aa944 Rob Clark 2020-10-23 98 spin_lock_init(&ring->submit_lock);
77c406038e830a Rob Clark 2020-10-23 99 spin_lock_init(&ring->preempt_lock);
f97decac5f4c2d Jordan Crouse 2017-10-20 100
f97decac5f4c2d Jordan Crouse 2017-10-20 101 snprintf(name, sizeof(name), "gpu-ring-%d", ring->id);
f97decac5f4c2d Jordan Crouse 2017-10-20 102
da3d378dec8634 Rob Clark 2021-07-26 103 ring->fctx = msm_fence_context_alloc(gpu->dev, &ring->memptrs->fence, name);
7198e6b03155f6 Rob Clark 2013-07-19 104
7198e6b03155f6 Rob Clark 2013-07-19 105 return ring;
7198e6b03155f6 Rob Clark 2013-07-19 106
7198e6b03155f6 Rob Clark 2013-07-19 107 fail:
7198e6b03155f6 Rob Clark 2013-07-19 108 msm_ringbuffer_destroy(ring);
7198e6b03155f6 Rob Clark 2013-07-19 109 return ERR_PTR(ret);
7198e6b03155f6 Rob Clark 2013-07-19 110 }
7198e6b03155f6 Rob Clark 2013-07-19 111 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Christian König
maintainerHi Jiawei,
can you take a look at this? The kernel build robots screaming that this breaks the V3D build. Probably just a typo or missing include.
I would rather like to push this sooner than later.
Thanks,
Christian.
Am 21.02.22 um 16:51 schrieb kernel test robot:
Quoted 138 lines
Hi Jiawei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-scm.com%2Fdocs%2Fgit-format-patch&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8Kj1h9%2BCR%2B8nDeUXW%2B%2FQOFbiavK5oHons0mRPyHhq%2F0%3D&reserved=0]url: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FJiawei-Gu%2Fdrm-sched-Add-device-pointer-to-drm_gpu_scheduler%2F20220221-175818&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KMrQ%2FsAoUV768eWdTF1FdmXo44kDPjWKnwoi4rvVnqs%3D&reserved=0 base: git://anongit.freedesktop.org/drm/drm drm-next config: ia64-allmodconfig (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownload.01.org%2F0day-ci%2Farchive%2F20220221%2F202202212330.nxcvFWEe-lkp%40intel.com%2Fconfig&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tLVbOkxAyxSD%2BVUHUmS6BT5RfOzO4q3sotVZ2YHGV9o%3D&reserved=0) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8QLSr7JTjK87bBGwgOLxU6AU4bCeHoWX2zyx7SGYL7M%3D&reserved=0 -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2F9fdafca855faca0a3b8f213f024985c4112fa0bb&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=W9HKTScDzhoA1DClCigH2QQUgcIzLStBS%2Bx9ieYPbK4%3D&reserved=0 git remote add linux-review https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FNJyugHVXenGmYqwgoK9kzKKjC3WGMia%2BNUduLNb0Pc%3D&reserved=0 git fetch --no-tags linux-review Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 git checkout 9fdafca855faca0a3b8f213f024985c4112fa0bb # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/gpu/drm/msm/ drivers/gpu/drm/v3d/If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>):
drivers/gpu/drm/msm/msm_ringbuffer.c: In function 'msm_ringbuffer_new':Quoted 1 line
Quoted 1 line
drivers/gpu/drm/msm/msm_ringbuffer.c:90:15: error: too few arguments to function 'drm_sched_init'90 | ret = drm_sched_init(&ring->sched,
&msm_sched_ops,
| ^~~~~~~~~~~~~~
In file included fromdrivers/gpu/drm/msm/msm_ringbuffer.h:10,
fromdrivers/gpu/drm/msm/msm_ringbuffer.c:7:
include/drm/gpu_scheduler.h:463:5: note: declared here
463 | int drm_sched_init(structdrm_gpu_scheduler*sched,
| ^~~~~~~~~~~~~~
--
In file included fromdrivers/gpu/drm/v3d/v3d_sched.c:23:
drivers/gpu/drm/v3d/v3d_sched.c: In function 'v3d_sched_init':Quoted 1 line
Quoted 1 line
drivers/gpu/drm/v3d/v3d_drv.h:158:26: error: implicit declaration of function 'to_platform_device' [-Werror=implicit-function-declaration]158 | #define v3d_to_pdev(v3d) to_platform_device((v3d)->drm.dev) | ^~~~~~~~~~~~~~~~~~ drivers/gpu/drm/v3d/v3d_sched.c:394:49: note: in expansion of macro 'v3d_to_pdev' 394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~~~~~~~~~~Quoted 1 line
Quoted 1 line
drivers/gpu/drm/v3d/v3d_sched.c:394:65: error: invalid type argument of '->' (have 'int')394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:404:68: error: invalid type argument of '->' (have 'int') 404 | NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:416:65: error: invalid type argument of '->' (have 'int') 416 | NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:429:73: error: invalid type argument of '->' (have 'int') 429 | NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:441:81: error: invalid type argument of '->' (have 'int') 441 | NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev)); | ^~ cc1: some warnings being treated as errorsvim +/drm_sched_init +90
drivers/gpu/drm/msm/msm_ringbuffer.c1d8a5ca436ee4a Rob Clark 2021-07-27 47 f97decac5f4c2d Jordan Crouse 2017-10-20 48 struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id, f97decac5f4c2d Jordan Crouse 2017-10-20 49 void *memptrs, uint64_t memptrs_iova) 7198e6b03155f6 Rob Clark 2013-07-19 50 { 7198e6b03155f6 Rob Clark 2013-07-19 51 struct msm_ringbuffer *ring; 1d8a5ca436ee4a Rob Clark 2021-07-27 52 long sched_timeout; f97decac5f4c2d Jordan Crouse 2017-10-20 53 char name[32]; 7198e6b03155f6 Rob Clark 2013-07-19 54 int ret; 7198e6b03155f6 Rob Clark 2013-07-19 55 f97decac5f4c2d Jordan Crouse 2017-10-20 56 /* We assume everwhere that MSM_GPU_RINGBUFFER_SZ is a power of 2 */ f97decac5f4c2d Jordan Crouse 2017-10-20 57 BUILD_BUG_ON(!is_power_of_2(MSM_GPU_RINGBUFFER_SZ)); 7198e6b03155f6 Rob Clark 2013-07-19 58 7198e6b03155f6 Rob Clark 2013-07-19 59 ring = kzalloc(sizeof(*ring), GFP_KERNEL); 7198e6b03155f6 Rob Clark 2013-07-19 60 if (!ring) { 7198e6b03155f6 Rob Clark 2013-07-19 61 ret = -ENOMEM; 7198e6b03155f6 Rob Clark 2013-07-19 62 goto fail; 7198e6b03155f6 Rob Clark 2013-07-19 63 } 7198e6b03155f6 Rob Clark 2013-07-19 64 7198e6b03155f6 Rob Clark 2013-07-19 65 ring->gpu = gpu; f97decac5f4c2d Jordan Crouse 2017-10-20 66 ring->id = id; 84c6127580c1ce Jordan Crouse 2018-11-07 67 f97decac5f4c2d Jordan Crouse 2017-10-20 68 ring->start = msm_gem_kernel_new(gpu->dev, MSM_GPU_RINGBUFFER_SZ, 604234f33658cd Jordan Crouse 2020-09-03 69 check_apriv(gpu, MSM_BO_WC | MSM_BO_GPU_READONLY), 604234f33658cd Jordan Crouse 2020-09-03 70 gpu->aspace, &ring->bo, &ring->iova); 8223286d62e296 Jordan Crouse 2017-07-27 71 69a834c28fb514 Rob Clark 2016-05-24 72 if (IS_ERR(ring->start)) { 69a834c28fb514 Rob Clark 2016-05-24 73 ret = PTR_ERR(ring->start); 375f9a63a66bae Rob Clark 2021-07-27 74 ring->start = NULL; 69a834c28fb514 Rob Clark 2016-05-24 75 goto fail; 69a834c28fb514 Rob Clark 2016-05-24 76 } 0815d7749a6852 Jordan Crouse 2018-11-07 77 0815d7749a6852 Jordan Crouse 2018-11-07 78 msm_gem_object_set_name(ring->bo, "ring%d", id); 0815d7749a6852 Jordan Crouse 2018-11-07 79 f97decac5f4c2d Jordan Crouse 2017-10-20 80 ring->end = ring->start + (MSM_GPU_RINGBUFFER_SZ >> 2); 4c7085a5d581a5 Jordan Crouse 2017-10-20 81 ring->next = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 82 ring->cur = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 83 f97decac5f4c2d Jordan Crouse 2017-10-20 84 ring->memptrs = memptrs; f97decac5f4c2d Jordan Crouse 2017-10-20 85 ring->memptrs_iova = memptrs_iova; f97decac5f4c2d Jordan Crouse 2017-10-20 86 1d8a5ca436ee4a Rob Clark 2021-07-27 87 /* currently managing hangcheck ourselves: */ 1d8a5ca436ee4a Rob Clark 2021-07-27 88 sched_timeout = MAX_SCHEDULE_TIMEOUT; 1d8a5ca436ee4a Rob Clark 2021-07-27 89 1d8a5ca436ee4a Rob Clark 2021-07-27 @90 ret = drm_sched_init(&ring->sched, &msm_sched_ops, 1d8a5ca436ee4a Rob Clark 2021-07-27 91 num_hw_submissions, 0, sched_timeout, f1b7996551a40a Dave Airlie 2021-07-30 92 NULL, NULL, to_msm_bo(ring->bo)->name); 1d8a5ca436ee4a Rob Clark 2021-07-27 93 if (ret) { 1d8a5ca436ee4a Rob Clark 2021-07-27 94 goto fail; 1d8a5ca436ee4a Rob Clark 2021-07-27 95 } 1d8a5ca436ee4a Rob Clark 2021-07-27 96 f97decac5f4c2d Jordan Crouse 2017-10-20 97 INIT_LIST_HEAD(&ring->submits); 77d205290aa944 Rob Clark 2020-10-23 98 spin_lock_init(&ring->submit_lock); 77c406038e830a Rob Clark 2020-10-23 99 spin_lock_init(&ring->preempt_lock); f97decac5f4c2d Jordan Crouse 2017-10-20 100 f97decac5f4c2d Jordan Crouse 2017-10-20 101 snprintf(name, sizeof(name), "gpu-ring-%d", ring->id); f97decac5f4c2d Jordan Crouse 2017-10-20 102 da3d378dec8634 Rob Clark 2021-07-26 103 ring->fctx = msm_fence_context_alloc(gpu->dev, &ring->memptrs->fence, name); 7198e6b03155f6 Rob Clark 2013-07-19 104 7198e6b03155f6 Rob Clark 2013-07-19 105 return ring; 7198e6b03155f6 Rob Clark 2013-07-19 106 7198e6b03155f6 Rob Clark 2013-07-19 107 fail: 7198e6b03155f6 Rob Clark 2013-07-19 108 msm_ringbuffer_destroy(ring); 7198e6b03155f6 Rob Clark 2013-07-19 109 return ERR_PTR(ret); 7198e6b03155f6 Rob Clark 2013-07-19 110 } 7198e6b03155f6 Rob Clark 2013-07-19 111---
0-DAY CI Kernel Test Service, Intel Corporation
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JTbXE%2Fv85yMSdX1zm4Em1aUZ32N29bf3FrllBkr%2BsMQ%3D&reserved=0
[AMD Official Use Only]
Hi Christian,
I noticed that and it has been fixed with the latest patch. And I pushed it to amd-staging-drm-next already.
Best regards,
Jiawei
-----Original Message-----
From: Koenig, Christian <[email protected]>
Sent: Wednesday, February 23, 2022 3:12 PM
To: kernel test robot <[email protected]>; Gu, JiaWei (Will) <[email protected]>; dri-devel(a)lists.freedesktop.org; amd-gfx(a)lists.freedesktop.org; Grodzovsky, Andrey <[email protected]>; Liu, Monk <[email protected]>; Deng, Emily <[email protected]>; Chen, Horace <[email protected]>
Cc: kbuild-all(a)lists.01.org
Subject: Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler
Hi Jiawei,
can you take a look at this? The kernel build robots screaming that this breaks the V3D build. Probably just a typo or missing include.
I would rather like to push this sooner than later.
Thanks,
Christian.
Am 21.02.22 um 16:51 schrieb kernel test robot:
Quoted 162 lines
Hi Jiawei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-
scm.com%2Fdocs%2Fgit-format-patch&data=04%7C01%7CChristian.Koenig% 40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82 d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjo iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000& ;sdata=8Kj1h9%2BCR%2B8nDeUXW%2B%2FQOFbiavK5oHons0mRPyHhq%2F0%3D&re served=0]url: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FJiawei-Gu%2Fdrm-sched-Add-device-pointer-to-drm_gpu_scheduler%2F20220221-175818&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KMrQ%2FsAoUV768eWdTF1FdmXo44kDPjWKnwoi4rvVnqs%3D&reserved=0 base: git://anongit.freedesktop.org/drm/drm drm-next config: ia64-allmodconfig(https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdow
nload.01.org%2F0day-ci%2Farchive%2F20220221%2F202202212330.nxcvFWEe-lk p%40intel.com%2Fconfig&data=04%7C01%7CChristian.Koenig%40amd.com%7 C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7 C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tLVb OkxAyxSD%2BVUHUmS6BT5RfOzO4q3sotVZ2YHGV9o%3D&reserved=0)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8QLSr7JTjK87bBGwgOLxU6AU4bCeHoWX2zyx7SGYL7M%3D&reserved=0 -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2F9fdafca855faca0a3b8f213f024985c4112fa0bb&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=W9HKTScDzhoA1DClCigH2QQUgcIzLStBS%2Bx9ieYPbK4%3D&reserved=0 git remote add linux-review https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FNJyugHVXenGmYqwgoK9kzKKjC3WGMia%2BNUduLNb0Pc%3D&reserved=0 git fetch --no-tags linux-review Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 git checkout 9fdafca855faca0a3b8f213f024985c4112fa0bb # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
drivers/gpu/drm/msm/drivers/gpu/drm/v3d/If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>):
drivers/gpu/drm/msm/msm_ringbuffer.c: In function 'msm_ringbuffer_new':Quoted 1 line
Quoted 1 line
drivers/gpu/drm/msm/msm_ringbuffer.c:90:15: error: too few arguments to function 'drm_sched_init'90 | ret = drm_sched_init(&ring->sched,
&msm_sched_ops,
| ^~~~~~~~~~~~~~
In file included fromdrivers/gpu/drm/msm/msm_ringbuffer.h:10,
fromdrivers/gpu/drm/msm/msm_ringbuffer.c:7:
include/drm/gpu_scheduler.h:463:5: note: declared here
463 | int drm_sched_init(structdrm_gpu_scheduler*sched,
| ^~~~~~~~~~~~~~
--
In file included fromdrivers/gpu/drm/v3d/v3d_sched.c:23:
drivers/gpu/drm/v3d/v3d_sched.c: In function 'v3d_sched_init':Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/v3d/v3d_drv.h:158:26: error: implicit declaration of function 'to_platform_device' [-Werror=implicit-function-declaration]158 | #define v3d_to_pdev(v3d) to_platform_device((v3d)->drm.dev) | ^~~~~~~~~~~~~~~~~~ drivers/gpu/drm/v3d/v3d_sched.c:394:49: note: in expansion of macro 'v3d_to_pdev' 394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~~~~~~~~~~Quoted 2 lines
Quoted 2 lines
drivers/gpu/drm/v3d/v3d_sched.c:394:65: error: invalid type argument of '->' (have 'int')394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:404:68: error: invalid type argument of '->' (have 'int') 404 | NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:416:65: error: invalid type argument of '->' (have 'int') 416 | NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:429:73: error: invalid type argument of '->' (have 'int') 429 | NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:441:81: error: invalid type argument of '->' (have 'int') 441 | NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev)); | ^~ cc1: some warnings being treated as errorsvim +/drm_sched_init +90
drivers/gpu/drm/msm/msm_ringbuffer.c1d8a5ca436ee4a Rob Clark 2021-07-27 47 f97decac5f4c2d Jordan Crouse 2017-10-20 48 struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id, f97decac5f4c2d Jordan Crouse 2017-10-20 49 void *memptrs, uint64_t memptrs_iova) 7198e6b03155f6 Rob Clark 2013-07-19 50 { 7198e6b03155f6 Rob Clark 2013-07-19 51 struct msm_ringbuffer *ring; 1d8a5ca436ee4a Rob Clark 2021-07-27 52 long sched_timeout; f97decac5f4c2d Jordan Crouse 2017-10-20 53 char name[32]; 7198e6b03155f6 Rob Clark 2013-07-19 54 int ret; 7198e6b03155f6 Rob Clark 2013-07-19 55 f97decac5f4c2d Jordan Crouse 2017-10-20 56 /* We assume everwhere that MSM_GPU_RINGBUFFER_SZ is a power of 2 */ f97decac5f4c2d Jordan Crouse 2017-10-20 57 BUILD_BUG_ON(!is_power_of_2(MSM_GPU_RINGBUFFER_SZ)); 7198e6b03155f6 Rob Clark 2013-07-19 58 7198e6b03155f6 Rob Clark 2013-07-19 59 ring = kzalloc(sizeof(*ring), GFP_KERNEL); 7198e6b03155f6 Rob Clark 2013-07-19 60 if (!ring) { 7198e6b03155f6 Rob Clark 2013-07-19 61 ret = -ENOMEM; 7198e6b03155f6 Rob Clark 2013-07-19 62 goto fail; 7198e6b03155f6 Rob Clark 2013-07-19 63 } 7198e6b03155f6 Rob Clark 2013-07-19 64 7198e6b03155f6 Rob Clark 2013-07-19 65 ring->gpu = gpu; f97decac5f4c2d Jordan Crouse 2017-10-20 66 ring->id = id; 84c6127580c1ce Jordan Crouse 2018-11-07 67 f97decac5f4c2d Jordan Crouse 2017-10-20 68 ring->start = msm_gem_kernel_new(gpu->dev, MSM_GPU_RINGBUFFER_SZ, 604234f33658cd Jordan Crouse 2020-09-03 69 check_apriv(gpu, MSM_BO_WC | MSM_BO_GPU_READONLY), 604234f33658cd Jordan Crouse 2020-09-03 70 gpu->aspace, &ring->bo, &ring->iova); 8223286d62e296 Jordan Crouse 2017-07-27 71 69a834c28fb514 Rob Clark 2016-05-24 72 if (IS_ERR(ring->start)) { 69a834c28fb514 Rob Clark 2016-05-24 73 ret = PTR_ERR(ring->start); 375f9a63a66bae Rob Clark 2021-07-27 74 ring->start = NULL; 69a834c28fb514 Rob Clark 2016-05-24 75 goto fail; 69a834c28fb514 Rob Clark 2016-05-24 76 } 0815d7749a6852 Jordan Crouse 2018-11-07 77 0815d7749a6852 Jordan Crouse 2018-11-07 78 msm_gem_object_set_name(ring->bo, "ring%d", id); 0815d7749a6852 Jordan Crouse 2018-11-07 79 f97decac5f4c2d Jordan Crouse 2017-10-20 80 ring->end = ring->start + (MSM_GPU_RINGBUFFER_SZ >> 2); 4c7085a5d581a5 Jordan Crouse 2017-10-20 81 ring->next = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 82 ring->cur = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 83 f97decac5f4c2d Jordan Crouse 2017-10-20 84 ring->memptrs = memptrs; f97decac5f4c2d Jordan Crouse 2017-10-20 85 ring->memptrs_iova = memptrs_iova; f97decac5f4c2d Jordan Crouse 2017-10-20 86 1d8a5ca436ee4a Rob Clark 2021-07-27 87 /* currently managing hangcheck ourselves: */ 1d8a5ca436ee4a Rob Clark 2021-07-27 88 sched_timeout = MAX_SCHEDULE_TIMEOUT; 1d8a5ca436ee4a Rob Clark 2021-07-27 89 1d8a5ca436ee4a Rob Clark 2021-07-27 @90 ret = drm_sched_init(&ring->sched, &msm_sched_ops, 1d8a5ca436ee4a Rob Clark 2021-07-27 91 num_hw_submissions, 0, sched_timeout, f1b7996551a40a Dave Airlie 2021-07-30 92 NULL, NULL, to_msm_bo(ring->bo)->name); 1d8a5ca436ee4a Rob Clark 2021-07-27 93 if (ret) { 1d8a5ca436ee4a Rob Clark 2021-07-27 94 goto fail; 1d8a5ca436ee4a Rob Clark 2021-07-27 95 } 1d8a5ca436ee4a Rob Clark 2021-07-27 96 f97decac5f4c2d Jordan Crouse 2017-10-20 97 INIT_LIST_HEAD(&ring->submits); 77d205290aa944 Rob Clark 2020-10-23 98 spin_lock_init(&ring->submit_lock); 77c406038e830a Rob Clark 2020-10-23 99 spin_lock_init(&ring->preempt_lock); f97decac5f4c2d Jordan Crouse 2017-10-20 100 f97decac5f4c2d Jordan Crouse 2017-10-20 101 snprintf(name, sizeof(name), "gpu-ring-%d", ring->id); f97decac5f4c2d Jordan Crouse 2017-10-20 102 da3d378dec8634 Rob Clark 2021-07-26 103 ring->fctx = msm_fence_context_alloc(gpu->dev, &ring->memptrs->fence, name); 7198e6b03155f6 Rob Clark 2013-07-19 104 7198e6b03155f6 Rob Clark 2013-07-19 105 return ring; 7198e6b03155f6 Rob Clark 2013-07-19 106 7198e6b03155f6 Rob Clark 2013-07-19 107 fail: 7198e6b03155f6 Rob Clark 2013-07-19 108 msm_ringbuffer_destroy(ring); 7198e6b03155f6 Rob Clark 2013-07-19 109 return ERR_PTR(ret); 7198e6b03155f6 Rob Clark 2013-07-19 110 } 7198e6b03155f6 Rob Clark 2013-07-19 111---
0-DAY CI Kernel Test Service, Intel Corporation
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
s.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7 C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C 3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknow n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC JXVCI6Mn0%3D%7C3000&sdata=JTbXE%2Fv85yMSdX1zm4Em1aUZ32N29bf3FrllBk r%2BsMQ%3D&reserved=0
Christian König
maintainerWell that's bad. This should not be pushed to amd-staging-drm-next at all.
This patch is touching multiple drivers and therefore needs to go upstream through drm-misc-next.
Alex can you drop that one before you send out a pull request? I'm going to cherry-pick it over to drm-misc-next.
Thanks,
Christian.
Am 23.02.22 um 08:15 schrieb Gu, JiaWei (Will):
Quoted 190 lines
[AMD Official Use Only]
Hi Christian,
I noticed that and it has been fixed with the latest patch. And I pushed it to amd-staging-drm-next already.
Best regards,
Jiawei-----Original Message-----
From: Koenig, Christian <[email protected]>
Sent: Wednesday, February 23, 2022 3:12 PM
To: kernel test robot <[email protected]>; Gu, JiaWei (Will) <[email protected]>; dri-devel(a)lists.freedesktop.org; amd-gfx(a)lists.freedesktop.org; Grodzovsky, Andrey <[email protected]>; Liu, Monk <[email protected]>; Deng, Emily <[email protected]>; Chen, Horace <[email protected]>
Cc: kbuild-all(a)lists.01.org
Subject: Re: [PATCH] drm/sched: Add device pointer todrm_gpu_schedulerHi Jiawei,
can you take a look at this? The kernel build robots screaming that this breaks the V3D build. Probably just a typo or missing include.
I would rather like to push this sooner than later.
Thanks,
Christian.Am 21.02.22 um 16:51 schrieb kernel test robot:
Quoted 162 lines
Hi Jiawei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-
scm.com%2Fdocs%2Fgit-format-patch&data=04%7C01%7CChristian.Koenig% 40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82 d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjo iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000& ;sdata=8Kj1h9%2BCR%2B8nDeUXW%2B%2FQOFbiavK5oHons0mRPyHhq%2F0%3D&re served=0]url: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FJiawei-Gu%2Fdrm-sched-Add-device-pointer-to-drm_gpu_scheduler%2F20220221-175818&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KMrQ%2FsAoUV768eWdTF1FdmXo44kDPjWKnwoi4rvVnqs%3D&reserved=0 base: git://anongit.freedesktop.org/drm/drm drm-next config: ia64-allmodconfig(https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdow
nload.01.org%2F0day-ci%2Farchive%2F20220221%2F202202212330.nxcvFWEe-lk p%40intel.com%2Fconfig&data=04%7C01%7CChristian.Koenig%40amd.com%7 C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7 C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tLVb OkxAyxSD%2BVUHUmS6BT5RfOzO4q3sotVZ2YHGV9o%3D&reserved=0)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8QLSr7JTjK87bBGwgOLxU6AU4bCeHoWX2zyx7SGYL7M%3D&reserved=0 -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2F9fdafca855faca0a3b8f213f024985c4112fa0bb&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=W9HKTScDzhoA1DClCigH2QQUgcIzLStBS%2Bx9ieYPbK4%3D&reserved=0 git remote add linux-review https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FNJyugHVXenGmYqwgoK9kzKKjC3WGMia%2BNUduLNb0Pc%3D&reserved=0 git fetch --no-tags linux-review Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 git checkout 9fdafca855faca0a3b8f213f024985c4112fa0bb # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
drivers/gpu/drm/msm/drivers/gpu/drm/v3d/If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>):
drivers/gpu/drm/msm/msm_ringbuffer.c: In function 'msm_ringbuffer_new':Quoted 1 line
Quoted 1 line
drivers/gpu/drm/msm/msm_ringbuffer.c:90:15: error: too few arguments to function 'drm_sched_init'90 | ret = drm_sched_init(&ring->sched,
&msm_sched_ops,
| ^~~~~~~~~~~~~~
In file included fromdrivers/gpu/drm/msm/msm_ringbuffer.h:10,
fromdrivers/gpu/drm/msm/msm_ringbuffer.c:7:
include/drm/gpu_scheduler.h:463:5: note: declared here
463 | int drm_sched_init(structdrm_gpu_scheduler*sched,
| ^~~~~~~~~~~~~~
--
In file included fromdrivers/gpu/drm/v3d/v3d_sched.c:23:
drivers/gpu/drm/v3d/v3d_sched.c: In function 'v3d_sched_init':Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/v3d/v3d_drv.h:158:26: error: implicit declaration of function 'to_platform_device' [-Werror=implicit-function-declaration]158 | #define v3d_to_pdev(v3d) to_platform_device((v3d)->drm.dev) | ^~~~~~~~~~~~~~~~~~ drivers/gpu/drm/v3d/v3d_sched.c:394:49: note: in expansion of macro 'v3d_to_pdev' 394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~~~~~~~~~~Quoted 2 lines
Quoted 2 lines
drivers/gpu/drm/v3d/v3d_sched.c:394:65: error: invalid type argument of '->' (have 'int')394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:404:68: error: invalid type argument of '->' (have 'int') 404 | NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:416:65: error: invalid type argument of '->' (have 'int') 416 | NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:429:73: error: invalid type argument of '->' (have 'int') 429 | NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:441:81: error: invalid type argument of '->' (have 'int') 441 | NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev)); | ^~ cc1: some warnings being treated as errorsvim +/drm_sched_init +90
drivers/gpu/drm/msm/msm_ringbuffer.c1d8a5ca436ee4a Rob Clark 2021-07-27 47 f97decac5f4c2d Jordan Crouse 2017-10-20 48 struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id, f97decac5f4c2d Jordan Crouse 2017-10-20 49 void *memptrs, uint64_t memptrs_iova) 7198e6b03155f6 Rob Clark 2013-07-19 50 { 7198e6b03155f6 Rob Clark 2013-07-19 51 struct msm_ringbuffer *ring; 1d8a5ca436ee4a Rob Clark 2021-07-27 52 long sched_timeout; f97decac5f4c2d Jordan Crouse 2017-10-20 53 char name[32]; 7198e6b03155f6 Rob Clark 2013-07-19 54 int ret; 7198e6b03155f6 Rob Clark 2013-07-19 55 f97decac5f4c2d Jordan Crouse 2017-10-20 56 /* We assume everwhere that MSM_GPU_RINGBUFFER_SZ is a power of 2 */ f97decac5f4c2d Jordan Crouse 2017-10-20 57 BUILD_BUG_ON(!is_power_of_2(MSM_GPU_RINGBUFFER_SZ)); 7198e6b03155f6 Rob Clark 2013-07-19 58 7198e6b03155f6 Rob Clark 2013-07-19 59 ring = kzalloc(sizeof(*ring), GFP_KERNEL); 7198e6b03155f6 Rob Clark 2013-07-19 60 if (!ring) { 7198e6b03155f6 Rob Clark 2013-07-19 61 ret = -ENOMEM; 7198e6b03155f6 Rob Clark 2013-07-19 62 goto fail; 7198e6b03155f6 Rob Clark 2013-07-19 63 } 7198e6b03155f6 Rob Clark 2013-07-19 64 7198e6b03155f6 Rob Clark 2013-07-19 65 ring->gpu = gpu; f97decac5f4c2d Jordan Crouse 2017-10-20 66 ring->id = id; 84c6127580c1ce Jordan Crouse 2018-11-07 67 f97decac5f4c2d Jordan Crouse 2017-10-20 68 ring->start = msm_gem_kernel_new(gpu->dev, MSM_GPU_RINGBUFFER_SZ, 604234f33658cd Jordan Crouse 2020-09-03 69 check_apriv(gpu, MSM_BO_WC | MSM_BO_GPU_READONLY), 604234f33658cd Jordan Crouse 2020-09-03 70 gpu->aspace, &ring->bo, &ring->iova); 8223286d62e296 Jordan Crouse 2017-07-27 71 69a834c28fb514 Rob Clark 2016-05-24 72 if (IS_ERR(ring->start)) { 69a834c28fb514 Rob Clark 2016-05-24 73 ret = PTR_ERR(ring->start); 375f9a63a66bae Rob Clark 2021-07-27 74 ring->start = NULL; 69a834c28fb514 Rob Clark 2016-05-24 75 goto fail; 69a834c28fb514 Rob Clark 2016-05-24 76 } 0815d7749a6852 Jordan Crouse 2018-11-07 77 0815d7749a6852 Jordan Crouse 2018-11-07 78 msm_gem_object_set_name(ring->bo, "ring%d", id); 0815d7749a6852 Jordan Crouse 2018-11-07 79 f97decac5f4c2d Jordan Crouse 2017-10-20 80 ring->end = ring->start + (MSM_GPU_RINGBUFFER_SZ >> 2); 4c7085a5d581a5 Jordan Crouse 2017-10-20 81 ring->next = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 82 ring->cur = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 83 f97decac5f4c2d Jordan Crouse 2017-10-20 84 ring->memptrs = memptrs; f97decac5f4c2d Jordan Crouse 2017-10-20 85 ring->memptrs_iova = memptrs_iova; f97decac5f4c2d Jordan Crouse 2017-10-20 86 1d8a5ca436ee4a Rob Clark 2021-07-27 87 /* currently managing hangcheck ourselves: */ 1d8a5ca436ee4a Rob Clark 2021-07-27 88 sched_timeout = MAX_SCHEDULE_TIMEOUT; 1d8a5ca436ee4a Rob Clark 2021-07-27 89 1d8a5ca436ee4a Rob Clark 2021-07-27 @90 ret = drm_sched_init(&ring->sched, &msm_sched_ops, 1d8a5ca436ee4a Rob Clark 2021-07-27 91 num_hw_submissions, 0, sched_timeout, f1b7996551a40a Dave Airlie 2021-07-30 92 NULL, NULL, to_msm_bo(ring->bo)->name); 1d8a5ca436ee4a Rob Clark 2021-07-27 93 if (ret) { 1d8a5ca436ee4a Rob Clark 2021-07-27 94 goto fail; 1d8a5ca436ee4a Rob Clark 2021-07-27 95 } 1d8a5ca436ee4a Rob Clark 2021-07-27 96 f97decac5f4c2d Jordan Crouse 2017-10-20 97 INIT_LIST_HEAD(&ring->submits); 77d205290aa944 Rob Clark 2020-10-23 98 spin_lock_init(&ring->submit_lock); 77c406038e830a Rob Clark 2020-10-23 99 spin_lock_init(&ring->preempt_lock); f97decac5f4c2d Jordan Crouse 2017-10-20 100 f97decac5f4c2d Jordan Crouse 2017-10-20 101 snprintf(name, sizeof(name), "gpu-ring-%d", ring->id); f97decac5f4c2d Jordan Crouse 2017-10-20 102 da3d378dec8634 Rob Clark 2021-07-26 103 ring->fctx = msm_fence_context_alloc(gpu->dev, &ring->memptrs->fence, name); 7198e6b03155f6 Rob Clark 2013-07-19 104 7198e6b03155f6 Rob Clark 2013-07-19 105 return ring; 7198e6b03155f6 Rob Clark 2013-07-19 106 7198e6b03155f6 Rob Clark 2013-07-19 107 fail: 7198e6b03155f6 Rob Clark 2013-07-19 108 msm_ringbuffer_destroy(ring); 7198e6b03155f6 Rob Clark 2013-07-19 109 return ERR_PTR(ret); 7198e6b03155f6 Rob Clark 2013-07-19 110 } 7198e6b03155f6 Rob Clark 2013-07-19 111---
0-DAY CI Kernel Test Service, Intel Corporation
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
s.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7 C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C 3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknow n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC JXVCI6Mn0%3D%7C3000&sdata=JTbXE%2Fv85yMSdX1zm4Em1aUZ32N29bf3FrllBk r%2BsMQ%3D&reserved=0
Quoted 8 lines · Christian König
Well that's bad. This should not be pushed to amd-staging-drm-next at all.
This patch is touching multiple drivers and therefore needs to go upstream through drm-misc-next.
Alex can you drop that one before you send out a pull request? I'm going to cherry-pick it over to drm-misc-next.
Yeah, no problem.
Alex
Quoted 196 lines
Thanks,
Christian.Am 23.02.22 um 08:15 schrieb Gu, JiaWei (Will):
Quoted 190 lines
[AMD Official Use Only]
Hi Christian,
I noticed that and it has been fixed with the latest patch. And I pushed it to amd-staging-drm-next already.
Best regards,
Jiawei-----Original Message-----
From: Koenig, Christian <[email protected]>
Sent: Wednesday, February 23, 2022 3:12 PM
To: kernel test robot <[email protected]>; Gu, JiaWei (Will) <JiaWei.Gu(a)amd.com>; dri-devel(a)lists.freedesktop.org; amd-gfx(a)lists.freedesktop.org; Grodzovsky, Andrey <[email protected]>; Liu, Monk <Monk.Liu(a)amd.com>; Deng, Emily <[email protected]>; Chen, Horace <[email protected]>
Cc: kbuild-all(a)lists.01.org
Subject: Re: [PATCH] drm/sched: Add device pointer todrm_gpu_schedulerHi Jiawei,
can you take a look at this? The kernel build robots screaming that this breaks the V3D build. Probably just a typo or missing include.
I would rather like to push this sooner than later.
Thanks,
Christian.Am 21.02.22 um 16:51 schrieb kernel test robot:
Quoted 162 lines
Hi Jiawei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-
scm.com%2Fdocs%2Fgit-format-patch&data=04%7C01%7CChristian.Koenig% 40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82 d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjo iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000& ;sdata=8Kj1h9%2BCR%2B8nDeUXW%2B%2FQOFbiavK5oHons0mRPyHhq%2F0%3D&re served=0]url: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FJiawei-Gu%2Fdrm-sched-Add-device-pointer-to-drm_gpu_scheduler%2F20220221-175818&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KMrQ%2FsAoUV768eWdTF1FdmXo44kDPjWKnwoi4rvVnqs%3D&reserved=0 base: git://anongit.freedesktop.org/drm/drm drm-next config: ia64-allmodconfig(https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdow
nload.01.org%2F0day-ci%2Farchive%2F20220221%2F202202212330.nxcvFWEe-lk p%40intel.com%2Fconfig&data=04%7C01%7CChristian.Koenig%40amd.com%7 C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7 C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tLVb OkxAyxSD%2BVUHUmS6BT5RfOzO4q3sotVZ2YHGV9o%3D&reserved=0)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8QLSr7JTjK87bBGwgOLxU6AU4bCeHoWX2zyx7SGYL7M%3D&reserved=0 -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2F9fdafca855faca0a3b8f213f024985c4112fa0bb&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=W9HKTScDzhoA1DClCigH2QQUgcIzLStBS%2Bx9ieYPbK4%3D&reserved=0 git remote add linux-review https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=04%7C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FNJyugHVXenGmYqwgoK9kzKKjC3WGMia%2BNUduLNb0Pc%3D&reserved=0 git fetch --no-tags linux-review Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 git checkout 9fdafca855faca0a3b8f213f024985c4112fa0bb # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
drivers/gpu/drm/msm/drivers/gpu/drm/v3d/If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>):
drivers/gpu/drm/msm/msm_ringbuffer.c: In function 'msm_ringbuffer_new':Quoted 1 line
Quoted 1 line
drivers/gpu/drm/msm/msm_ringbuffer.c:90:15: error: too few arguments to function 'drm_sched_init'90 | ret = drm_sched_init(&ring->sched,
&msm_sched_ops,
| ^~~~~~~~~~~~~~
In file included fromdrivers/gpu/drm/msm/msm_ringbuffer.h:10,
fromdrivers/gpu/drm/msm/msm_ringbuffer.c:7:
include/drm/gpu_scheduler.h:463:5: note: declared here
463 | int drm_sched_init(structdrm_gpu_scheduler*sched,
| ^~~~~~~~~~~~~~
--
In file included fromdrivers/gpu/drm/v3d/v3d_sched.c:23:
drivers/gpu/drm/v3d/v3d_sched.c: In function 'v3d_sched_init':Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/v3d/v3d_drv.h:158:26: error: implicit declaration of function 'to_platform_device' [-Werror=implicit-function-declaration]158 | #define v3d_to_pdev(v3d) to_platform_device((v3d)->drm.dev) | ^~~~~~~~~~~~~~~~~~ drivers/gpu/drm/v3d/v3d_sched.c:394:49: note: in expansion of macro 'v3d_to_pdev' 394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~~~~~~~~~~Quoted 2 lines
Quoted 2 lines
drivers/gpu/drm/v3d/v3d_sched.c:394:65: error: invalid type argument of '->' (have 'int')394 | NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:404:68: error: invalid type argument of '->' (have 'int') 404 | NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:416:65: error: invalid type argument of '->' (have 'int') 416 | NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:429:73: error: invalid type argument of '->' (have 'int') 429 | NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev)); | ^~ drivers/gpu/drm/v3d/v3d_sched.c:441:81: error: invalid type argument of '->' (have 'int') 441 | NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev)); | ^~ cc1: some warnings being treated as errorsvim +/drm_sched_init +90
drivers/gpu/drm/msm/msm_ringbuffer.c1d8a5ca436ee4a Rob Clark 2021-07-27 47 f97decac5f4c2d Jordan Crouse 2017-10-20 48 struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id, f97decac5f4c2d Jordan Crouse 2017-10-20 49 void *memptrs, uint64_t memptrs_iova) 7198e6b03155f6 Rob Clark 2013-07-19 50 { 7198e6b03155f6 Rob Clark 2013-07-19 51 struct msm_ringbuffer *ring; 1d8a5ca436ee4a Rob Clark 2021-07-27 52 long sched_timeout; f97decac5f4c2d Jordan Crouse 2017-10-20 53 char name[32]; 7198e6b03155f6 Rob Clark 2013-07-19 54 int ret; 7198e6b03155f6 Rob Clark 2013-07-19 55 f97decac5f4c2d Jordan Crouse 2017-10-20 56 /* We assume everwhere that MSM_GPU_RINGBUFFER_SZ is a power of 2 */ f97decac5f4c2d Jordan Crouse 2017-10-20 57 BUILD_BUG_ON(!is_power_of_2(MSM_GPU_RINGBUFFER_SZ)); 7198e6b03155f6 Rob Clark 2013-07-19 58 7198e6b03155f6 Rob Clark 2013-07-19 59 ring = kzalloc(sizeof(*ring), GFP_KERNEL); 7198e6b03155f6 Rob Clark 2013-07-19 60 if (!ring) { 7198e6b03155f6 Rob Clark 2013-07-19 61 ret = -ENOMEM; 7198e6b03155f6 Rob Clark 2013-07-19 62 goto fail; 7198e6b03155f6 Rob Clark 2013-07-19 63 } 7198e6b03155f6 Rob Clark 2013-07-19 64 7198e6b03155f6 Rob Clark 2013-07-19 65 ring->gpu = gpu; f97decac5f4c2d Jordan Crouse 2017-10-20 66 ring->id = id; 84c6127580c1ce Jordan Crouse 2018-11-07 67 f97decac5f4c2d Jordan Crouse 2017-10-20 68 ring->start = msm_gem_kernel_new(gpu->dev, MSM_GPU_RINGBUFFER_SZ, 604234f33658cd Jordan Crouse 2020-09-03 69 check_apriv(gpu, MSM_BO_WC | MSM_BO_GPU_READONLY), 604234f33658cd Jordan Crouse 2020-09-03 70 gpu->aspace, &ring->bo, &ring->iova); 8223286d62e296 Jordan Crouse 2017-07-27 71 69a834c28fb514 Rob Clark 2016-05-24 72 if (IS_ERR(ring->start)) { 69a834c28fb514 Rob Clark 2016-05-24 73 ret = PTR_ERR(ring->start); 375f9a63a66bae Rob Clark 2021-07-27 74 ring->start = NULL; 69a834c28fb514 Rob Clark 2016-05-24 75 goto fail; 69a834c28fb514 Rob Clark 2016-05-24 76 } 0815d7749a6852 Jordan Crouse 2018-11-07 77 0815d7749a6852 Jordan Crouse 2018-11-07 78 msm_gem_object_set_name(ring->bo, "ring%d", id); 0815d7749a6852 Jordan Crouse 2018-11-07 79 f97decac5f4c2d Jordan Crouse 2017-10-20 80 ring->end = ring->start + (MSM_GPU_RINGBUFFER_SZ >> 2); 4c7085a5d581a5 Jordan Crouse 2017-10-20 81 ring->next = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 82 ring->cur = ring->start; 7198e6b03155f6 Rob Clark 2013-07-19 83 f97decac5f4c2d Jordan Crouse 2017-10-20 84 ring->memptrs = memptrs; f97decac5f4c2d Jordan Crouse 2017-10-20 85 ring->memptrs_iova = memptrs_iova; f97decac5f4c2d Jordan Crouse 2017-10-20 86 1d8a5ca436ee4a Rob Clark 2021-07-27 87 /* currently managing hangcheck ourselves: */ 1d8a5ca436ee4a Rob Clark 2021-07-27 88 sched_timeout = MAX_SCHEDULE_TIMEOUT; 1d8a5ca436ee4a Rob Clark 2021-07-27 89 1d8a5ca436ee4a Rob Clark 2021-07-27 @90 ret = drm_sched_init(&ring->sched, &msm_sched_ops, 1d8a5ca436ee4a Rob Clark 2021-07-27 91 num_hw_submissions, 0, sched_timeout, f1b7996551a40a Dave Airlie 2021-07-30 92 NULL, NULL, to_msm_bo(ring->bo)->name); 1d8a5ca436ee4a Rob Clark 2021-07-27 93 if (ret) { 1d8a5ca436ee4a Rob Clark 2021-07-27 94 goto fail; 1d8a5ca436ee4a Rob Clark 2021-07-27 95 } 1d8a5ca436ee4a Rob Clark 2021-07-27 96 f97decac5f4c2d Jordan Crouse 2017-10-20 97 INIT_LIST_HEAD(&ring->submits); 77d205290aa944 Rob Clark 2020-10-23 98 spin_lock_init(&ring->submit_lock); 77c406038e830a Rob Clark 2020-10-23 99 spin_lock_init(&ring->preempt_lock); f97decac5f4c2d Jordan Crouse 2017-10-20 100 f97decac5f4c2d Jordan Crouse 2017-10-20 101 snprintf(name, sizeof(name), "gpu-ring-%d", ring->id); f97decac5f4c2d Jordan Crouse 2017-10-20 102 da3d378dec8634 Rob Clark 2021-07-26 103 ring->fctx = msm_fence_context_alloc(gpu->dev, &ring->memptrs->fence, name); 7198e6b03155f6 Rob Clark 2013-07-19 104 7198e6b03155f6 Rob Clark 2013-07-19 105 return ring; 7198e6b03155f6 Rob Clark 2013-07-19 106 7198e6b03155f6 Rob Clark 2013-07-19 107 fail: 7198e6b03155f6 Rob Clark 2013-07-19 108 msm_ringbuffer_destroy(ring); 7198e6b03155f6 Rob Clark 2013-07-19 109 return ERR_PTR(ret); 7198e6b03155f6 Rob Clark 2013-07-19 110 } 7198e6b03155f6 Rob Clark 2013-07-19 111---
0-DAY CI Kernel Test Service, Intel Corporation
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
s.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7 C01%7CChristian.Koenig%40amd.com%7C33c94d7ecffe465c671d08d9f5522651%7C 3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637810555454343325%7CUnknow n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC JXVCI6Mn0%3D%7C3000&sdata=JTbXE%2Fv85yMSdX1zm4Em1aUZ32N29bf3FrllBk r%2BsMQ%3D&reserved=0
kernel test robot
build botThank you for the patch! Yet something to improve:
Hi Jiawei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 base: git://anongit.freedesktop.org/drm/drm drm-next config: hexagon-randconfig-r004-20220221 (https://download.01.org/0day-ci/archive/20220222/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9fdafca855faca0a3b8f213f024985c4112fa0bb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 git checkout 9fdafca855faca0a3b8f213f024985c4112fa0bb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/v3d/
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/v3d/v3d_sched.c:394:28: error: implicit declaration of function 'to_platform_device' [-Werror,-Wimplicit-function-declaration]
NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev));
^
drivers/gpu/drm/v3d/v3d_drv.h:158:26: note: expanded from macro 'v3d_to_pdev'
#define v3d_to_pdev(v3d) to_platform_device((v3d)->drm.dev)
^
>> drivers/gpu/drm/v3d/v3d_sched.c:394:46: error: member reference type 'int' is not a pointer
NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev));
~~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/v3d/v3d_sched.c:404:49: error: member reference type 'int' is not a pointer
NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev));
~~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/v3d/v3d_sched.c:416:46: error: member reference type 'int' is not a pointer
NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev));
~~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/v3d/v3d_sched.c:429:47: error: member reference type 'int' is not a pointer
NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev));
~~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/v3d/v3d_sched.c:441:55: error: member reference type 'int' is not a pointer
NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev));
~~~~~~~~~~~~~~~~ ^6 errors generated.
vim +/to_platform_device +394 drivers/gpu/drm/v3d/v3d_sched.c
381
382 int
383 v3d_sched_init(struct v3d_dev *v3d)
384 {
385 int hw_jobs_limit = 1;
386 int job_hang_limit = 0;
387 int hang_limit_ms = 500;
388 int ret;
389
390 ret = drm_sched_init(&v3d->queue[V3D_BIN].sched,
391 &v3d_bin_sched_ops,
392 hw_jobs_limit, job_hang_limit,
393 msecs_to_jiffies(hang_limit_ms), NULL,
> 394 NULL, "v3d_bin", &(v3d_to_pdev(v3d)->dev));
395 if (ret) {
396 dev_err(v3d->drm.dev, "Failed to create bin scheduler: %d.", ret);
397 return ret;
398 }
399
400 ret = drm_sched_init(&v3d->queue[V3D_RENDER].sched,
401 &v3d_render_sched_ops,
402 hw_jobs_limit, job_hang_limit,
403 msecs_to_jiffies(hang_limit_ms), NULL,
404 NULL, "v3d_render", &(v3d_to_pdev(v3d)->dev));
405 if (ret) {
406 dev_err(v3d->drm.dev, "Failed to create render scheduler: %d.",
407 ret);
408 v3d_sched_fini(v3d);
409 return ret;
410 }
411
412 ret = drm_sched_init(&v3d->queue[V3D_TFU].sched,
413 &v3d_tfu_sched_ops,
414 hw_jobs_limit, job_hang_limit,
415 msecs_to_jiffies(hang_limit_ms), NULL,
416 NULL, "v3d_tfu", &(v3d_to_pdev(v3d)->dev));
417 if (ret) {
418 dev_err(v3d->drm.dev, "Failed to create TFU scheduler: %d.",
419 ret);
420 v3d_sched_fini(v3d);
421 return ret;
422 }
423
424 if (v3d_has_csd(v3d)) {
425 ret = drm_sched_init(&v3d->queue[V3D_CSD].sched,
426 &v3d_csd_sched_ops,
427 hw_jobs_limit, job_hang_limit,
428 msecs_to_jiffies(hang_limit_ms), NULL,
429 NULL, "v3d_csd", &(v3d_to_pdev(v3d)->dev));
430 if (ret) {
431 dev_err(v3d->drm.dev, "Failed to create CSD scheduler: %d.",
432 ret);
433 v3d_sched_fini(v3d);
434 return ret;
435 }
436
437 ret = drm_sched_init(&v3d->queue[V3D_CACHE_CLEAN].sched,
438 &v3d_cache_clean_sched_ops,
439 hw_jobs_limit, job_hang_limit,
440 msecs_to_jiffies(hang_limit_ms), NULL,
441 NULL, "v3d_cache_clean", &(v3d_to_pdev(v3d)->dev)); 442 if (ret) {
443 dev_err(v3d->drm.dev, "Failed to create CACHE_CLEAN scheduler: %d.",
444 ret);
445 v3d_sched_fini(v3d);
446 return ret;
447 }
448 }
449
450 return 0;
451 }
452
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
kernel test robot
build botThank you for the patch! Yet something to improve:
Hi Jiawei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 base: git://anongit.freedesktop.org/drm/drm drm-next config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20220222/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9fdafca855faca0a3b8f213f024985c4112fa0bb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 git checkout 9fdafca855faca0a3b8f213f024985c4112fa0bb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/msm/
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/msm/msm_ringbuffer.c:92:41: error: too few arguments to function call, expected 9, have 8
NULL, NULL, to_msm_bo(ring->bo)->name);
^
include/drm/gpu_scheduler.h:463:5: note: 'drm_sched_init' declared here
int drm_sched_init(struct drm_gpu_scheduler *sched,
^1 error generated.
vim +92 drivers/gpu/drm/msm/msm_ringbuffer.c
1d8a5ca436ee4a Rob Clark 2021-07-27 47
f97decac5f4c2d Jordan Crouse 2017-10-20 48 struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id,
f97decac5f4c2d Jordan Crouse 2017-10-20 49 void *memptrs, uint64_t memptrs_iova)
7198e6b03155f6 Rob Clark 2013-07-19 50 {
7198e6b03155f6 Rob Clark 2013-07-19 51 struct msm_ringbuffer *ring;
1d8a5ca436ee4a Rob Clark 2021-07-27 52 long sched_timeout;
f97decac5f4c2d Jordan Crouse 2017-10-20 53 char name[32];
7198e6b03155f6 Rob Clark 2013-07-19 54 int ret;
7198e6b03155f6 Rob Clark 2013-07-19 55
f97decac5f4c2d Jordan Crouse 2017-10-20 56 /* We assume everwhere that MSM_GPU_RINGBUFFER_SZ is a power of 2 */
f97decac5f4c2d Jordan Crouse 2017-10-20 57 BUILD_BUG_ON(!is_power_of_2(MSM_GPU_RINGBUFFER_SZ));
7198e6b03155f6 Rob Clark 2013-07-19 58
7198e6b03155f6 Rob Clark 2013-07-19 59 ring = kzalloc(sizeof(*ring), GFP_KERNEL);
7198e6b03155f6 Rob Clark 2013-07-19 60 if (!ring) {
7198e6b03155f6 Rob Clark 2013-07-19 61 ret = -ENOMEM;
7198e6b03155f6 Rob Clark 2013-07-19 62 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 63 }
7198e6b03155f6 Rob Clark 2013-07-19 64
7198e6b03155f6 Rob Clark 2013-07-19 65 ring->gpu = gpu;
f97decac5f4c2d Jordan Crouse 2017-10-20 66 ring->id = id;
84c6127580c1ce Jordan Crouse 2018-11-07 67
f97decac5f4c2d Jordan Crouse 2017-10-20 68 ring->start = msm_gem_kernel_new(gpu->dev, MSM_GPU_RINGBUFFER_SZ,
604234f33658cd Jordan Crouse 2020-09-03 69 check_apriv(gpu, MSM_BO_WC | MSM_BO_GPU_READONLY),
604234f33658cd Jordan Crouse 2020-09-03 70 gpu->aspace, &ring->bo, &ring->iova);
8223286d62e296 Jordan Crouse 2017-07-27 71
69a834c28fb514 Rob Clark 2016-05-24 72 if (IS_ERR(ring->start)) {
69a834c28fb514 Rob Clark 2016-05-24 73 ret = PTR_ERR(ring->start);
375f9a63a66bae Rob Clark 2021-07-27 74 ring->start = NULL;
69a834c28fb514 Rob Clark 2016-05-24 75 goto fail;
69a834c28fb514 Rob Clark 2016-05-24 76 }
0815d7749a6852 Jordan Crouse 2018-11-07 77
0815d7749a6852 Jordan Crouse 2018-11-07 78 msm_gem_object_set_name(ring->bo, "ring%d", id);
0815d7749a6852 Jordan Crouse 2018-11-07 79
f97decac5f4c2d Jordan Crouse 2017-10-20 80 ring->end = ring->start + (MSM_GPU_RINGBUFFER_SZ >> 2);
4c7085a5d581a5 Jordan Crouse 2017-10-20 81 ring->next = ring->start;
7198e6b03155f6 Rob Clark 2013-07-19 82 ring->cur = ring->start;
7198e6b03155f6 Rob Clark 2013-07-19 83
f97decac5f4c2d Jordan Crouse 2017-10-20 84 ring->memptrs = memptrs;
f97decac5f4c2d Jordan Crouse 2017-10-20 85 ring->memptrs_iova = memptrs_iova;
f97decac5f4c2d Jordan Crouse 2017-10-20 86
1d8a5ca436ee4a Rob Clark 2021-07-27 87 /* currently managing hangcheck ourselves: */
1d8a5ca436ee4a Rob Clark 2021-07-27 88 sched_timeout = MAX_SCHEDULE_TIMEOUT;
1d8a5ca436ee4a Rob Clark 2021-07-27 89
1d8a5ca436ee4a Rob Clark 2021-07-27 90 ret = drm_sched_init(&ring->sched, &msm_sched_ops,
1d8a5ca436ee4a Rob Clark 2021-07-27 91 num_hw_submissions, 0, sched_timeout,
f1b7996551a40a Dave Airlie 2021-07-30 @92 NULL, NULL, to_msm_bo(ring->bo)->name);
1d8a5ca436ee4a Rob Clark 2021-07-27 93 if (ret) {
1d8a5ca436ee4a Rob Clark 2021-07-27 94 goto fail;
1d8a5ca436ee4a Rob Clark 2021-07-27 95 }
1d8a5ca436ee4a Rob Clark 2021-07-27 96
f97decac5f4c2d Jordan Crouse 2017-10-20 97 INIT_LIST_HEAD(&ring->submits);
77d205290aa944 Rob Clark 2020-10-23 98 spin_lock_init(&ring->submit_lock);
77c406038e830a Rob Clark 2020-10-23 99 spin_lock_init(&ring->preempt_lock);
f97decac5f4c2d Jordan Crouse 2017-10-20 100
f97decac5f4c2d Jordan Crouse 2017-10-20 101 snprintf(name, sizeof(name), "gpu-ring-%d", ring->id);
f97decac5f4c2d Jordan Crouse 2017-10-20 102
da3d378dec8634 Rob Clark 2021-07-26 103 ring->fctx = msm_fence_context_alloc(gpu->dev, &ring->memptrs->fence, name);
7198e6b03155f6 Rob Clark 2013-07-19 104
7198e6b03155f6 Rob Clark 2013-07-19 105 return ring;
7198e6b03155f6 Rob Clark 2013-07-19 106
7198e6b03155f6 Rob Clark 2013-07-19 107 fail:
7198e6b03155f6 Rob Clark 2013-07-19 108 msm_ringbuffer_destroy(ring);
7198e6b03155f6 Rob Clark 2013-07-19 109 return ERR_PTR(ret);
7198e6b03155f6 Rob Clark 2013-07-19 110 }
7198e6b03155f6 Rob Clark 2013-07-19 111 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]