Skip to contentSkip to conversation

PM / devfreq: do some cleanup

PATCH In review Yangtao Li 4 participants 11 messages Feb 16, 2019 – Feb 20, 2019

Subsystems (4)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

cover PM / devfreq: do some cleanup

The informations come from the coccinelle tool.

drivers/devfreq/tegra-devfreq.c:577:5-8: Unneeded variable: "ret". Return "0" on line 603 drivers/devfreq/rk3399_dmc.c:325:2-3: Unneeded semicolon drivers/devfreq/event/rockchip-dfi.c:214:2-3: Unneeded semicolon

Yangtao Li (3):
PM / devfreq: rk3399_dmc: remove unneeded semicolon PM / devfreq: rockchip-dfi: remove unneeded semicolon PM / devfreq: tegra: remove unneeded variable

 drivers/devfreq/event/rockchip-dfi.c | 2 +-
 drivers/devfreq/rk3399_dmc.c         | 2 +-
 drivers/devfreq/tegra-devfreq.c      | 7 ++-----
 3 files changed, 4 insertions(+), 7 deletions(-)
Signature · 1 line
2.17.0
author
#1 lore raw

PATCH 1/3 PM / devfreq: rk3399_dmc: remove unneeded semicolon

The semicolon is unneeded, so remove it.

---
 drivers/devfreq/rk3399_dmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/rk3399_dmc.c +1 -1
index e795ad2b3f6b..a228dad2bee4 100644
@@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
 
 		dev_err(dev, "Cannot get the clk dmc_clk\n");
 		return PTR_ERR(data->dmc_clk);
-	};
+	}
 
 	data->edev = devfreq_event_get_edev_by_phandle(dev, 0);
 	if (IS_ERR(data->edev))
Signature · 1 line
2.17.0
maintainer Reviewed-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon

Hi,

Quoted 13 lines · Yangtao Li

The semicolon is unneeded, so remove it.

---
 drivers/devfreq/rk3399_dmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/rk3399_dmc.c +0 -0
index e795ad2b3f6b..a228dad2bee4 100644

drivers/devfreq/rk3399_dmc.c static int rk3399_dmcfreq_probe(struct platform_device *pdev) · line 328

Quoted 8 lines
drivers/devfreq/rk3399_dmc.c +1 -1
@@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
 
 		dev_err(dev, "Cannot get the clk dmc_clk\n");
 		return PTR_ERR(data->dmc_clk);
-	};
+	}
 
 	data->edev = devfreq_event_get_edev_by_phandle(dev, 0);
 	if (IS_ERR(data->edev))
Signature · 8 lines
Best Regards,
Chanwoo Choi
Samsung Electronics

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer Acked-by
#3 lore raw

Re: [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon

Quoted 22 lines · Chanwoo Choi

Hi,

Quoted 18 lines · Yangtao Li

The semicolon is unneeded, so remove it.

---
 drivers/devfreq/rk3399_dmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/rk3399_dmc.c +1 -1
index e795ad2b3f6b..a228dad2bee4 100644
@@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
 
              dev_err(dev, "Cannot get the clk dmc_clk\n");
              return PTR_ERR(data->dmc_clk);
-     };
+     }
 
Quoted 5 lines

drivers/devfreq/rk3399_dmc.c static int rk3399_dmcfreq_probe(struct platform_device *pdev) · line 328

Quoted 3 lines
drivers/devfreq/rk3399_dmc.c +0 -0
      data->edev = devfreq_event_get_edev_by_phandle(dev, 0);
      if (IS_ERR(data->edev))

Merged.

Quoted 5 lines

--
Best Regards,
Chanwoo Choi
Samsung Electronics

Signature · 2 lines
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics
author
#4 lore raw

PATCH 2/3 PM / devfreq: rockchip-dfi: remove unneeded semicolon

In reply to Yangtao Li

The semicolon is unneeded, so remove it.

---
 drivers/devfreq/event/rockchip-dfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/event/rockchip-dfi.c +1 -1
index 22b113363ffc..fcbf76ebf55d 100644
@@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
 	if (IS_ERR(data->clk)) {
 		dev_err(dev, "Cannot get the clk dmc_clk\n");
 		return PTR_ERR(data->clk);
-	};
+	}
 
 	/* try to find the optional reference to the pmu syscon */
 	node = of_parse_phandle(np, "rockchip,pmu", 0);
Signature · 1 line
2.17.0
maintainer Reviewed-by on v1 2/3
#5 lore raw

Re: [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon

Hi,

Quoted 13 lines · Yangtao Li

The semicolon is unneeded, so remove it.

---
 drivers/devfreq/event/rockchip-dfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/event/rockchip-dfi.c +0 -0
index 22b113363ffc..fcbf76ebf55d 100644

drivers/devfreq/event/rockchip-dfi.c static int rockchip_dfi_probe(struct platform_device *pdev) · line 217

Quoted 8 lines
drivers/devfreq/event/rockchip-dfi.c +1 -1
@@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
 	if (IS_ERR(data->clk)) {
 		dev_err(dev, "Cannot get the clk dmc_clk\n");
 		return PTR_ERR(data->clk);
-	};
+	}
 
 	/* try to find the optional reference to the pmu syscon */
 	node = of_parse_phandle(np, "rockchip,pmu", 0);
Signature · 8 lines
Best Regards,
Chanwoo Choi
Samsung Electronics

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer Acked-by
#6 lore raw

Re: [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon

Quoted 22 lines · Chanwoo Choi

Hi,

Quoted 18 lines · Yangtao Li

The semicolon is unneeded, so remove it.

---
 drivers/devfreq/event/rockchip-dfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/event/rockchip-dfi.c +1 -1
index 22b113363ffc..fcbf76ebf55d 100644
@@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
      if (IS_ERR(data->clk)) {
              dev_err(dev, "Cannot get the clk dmc_clk\n");
              return PTR_ERR(data->clk);
-     };
+     }
 
Quoted 5 lines

drivers/devfreq/event/rockchip-dfi.c static int rockchip_dfi_probe(struct platform_device *pdev) · line 217

Quoted 3 lines
drivers/devfreq/event/rockchip-dfi.c +0 -0
      /* try to find the optional reference to the pmu syscon */
      node = of_parse_phandle(np, "rockchip,pmu", 0);

Merged. Thanks.

Quoted 5 lines

--
Best Regards,
Chanwoo Choi
Samsung Electronics

Signature · 2 lines
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics
author
#7 lore raw

PATCH 3/3 PM / devfreq: tegra: remove unneeded variable

In reply to Yangtao Li

This variable is not used after initialization, so remove it. And in order to unify the code style, move the location where the dev_get_drvdata is called by the way.

---
 drivers/devfreq/tegra-devfreq.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/devfreq/tegra-devfreq.c +2 -5
index c59d2eee5d30..c89ba7b834ff 100644
@@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
 static int tegra_governor_event_handler(struct devfreq *devfreq,
 					unsigned int event, void *data)
 {
-	struct tegra_devfreq *tegra;
-	int ret = 0;
-
-	tegra = dev_get_drvdata(devfreq->dev.parent);
+	struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
 
 	switch (event) {
 	case DEVFREQ_GOV_START:
@@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
 		break;
 	}
 
-	return ret;
+	return 0;
 }
 
 static struct devfreq_governor tegra_devfreq_governor = {
Signature · 1 line
2.17.0
maintainer Reviewed-by on v1 3/3
#8 lore raw

Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable

Quoted 28 lines · Yangtao Li

This variable is not used after initialization, so remove it. And in order to unify the code style, move the location where the dev_get_drvdata is called by the way.

---
 drivers/devfreq/tegra-devfreq.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/devfreq/tegra-devfreq.c +1 -4
index c59d2eee5d30..c89ba7b834ff 100644
@@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
 static int tegra_governor_event_handler(struct devfreq *devfreq,
 					unsigned int event, void *data)
 {
-	struct tegra_devfreq *tegra;
-	int ret = 0;
-
-	tegra = dev_get_drvdata(devfreq->dev.parent);
+	struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
 
 	switch (event) {
 	case DEVFREQ_GOV_START:

drivers/devfreq/tegra-devfreq.c static int tegra_governor_event_handler(struct devfreq *devfreq, · line 603

Quoted 8 lines
drivers/devfreq/tegra-devfreq.c +1 -1
@@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
 		break;
 	}
 
-	return ret;
+	return 0;
 }
 
 static struct devfreq_governor tegra_devfreq_governor = {
Signature · 8 lines
Best Regards,
Chanwoo Choi
Samsung Electronics

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Acked-by
#9 lore raw

Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable

Quoted 31 lines · Chanwoo Choi
Quoted 30 lines · Yangtao Li

This variable is not used after initialization, so remove it. And in order to unify the code style, move the location where the dev_get_drvdata is called by the way.

---
 drivers/devfreq/tegra-devfreq.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/devfreq/tegra-devfreq.c +1 -4
index c59d2eee5d30..c89ba7b834ff 100644
@@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
 static int tegra_governor_event_handler(struct devfreq *devfreq,
 					unsigned int event, void *data)
 {
-	struct tegra_devfreq *tegra;
-	int ret = 0;
-
-	tegra = dev_get_drvdata(devfreq->dev.parent);
+	struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
 
 	switch (event) {
 	case DEVFREQ_GOV_START:
@@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
 		break;
 	}
 
Quoted 9 lines

drivers/devfreq/tegra-devfreq.c static int tegra_governor_event_handler(struct devfreq *devfreq, · line 603

Quoted 6 lines
drivers/devfreq/tegra-devfreq.c +1 -1
-	return ret;
+	return 0;
 }
 
 static struct devfreq_governor tegra_devfreq_governor = {

Thanks!
Jon

Signature · 1 line
nvpublic
maintainer Acked-by
#10 lore raw

Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable

Quoted 44 lines · Jon Hunter
Quoted 31 lines · Chanwoo Choi
Quoted 30 lines · Yangtao Li

This variable is not used after initialization, so remove it. And in order to unify the code style, move the location where the dev_get_drvdata is called by the way.

---
 drivers/devfreq/tegra-devfreq.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/devfreq/tegra-devfreq.c +1 -4
index c59d2eee5d30..c89ba7b834ff 100644
@@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
 static int tegra_governor_event_handler(struct devfreq *devfreq,
                                     unsigned int event, void *data)
 {
-    struct tegra_devfreq *tegra;
-    int ret = 0;
-
-    tegra = dev_get_drvdata(devfreq->dev.parent);
+    struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
 
     switch (event) {
     case DEVFREQ_GOV_START:
@@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
             break;
     }
 
Quoted 9 lines

drivers/devfreq/tegra-devfreq.c static int tegra_governor_event_handler(struct devfreq *devfreq, · line 603

Quoted 6 lines
drivers/devfreq/tegra-devfreq.c +1 -1
-    return ret;
+    return 0;
 }
 
 static struct devfreq_governor tegra_devfreq_governor = {
Quoted 4 lines

Thanks!
Jon

Merged. Thanks!

Quoted 3 lines

--
nvpublic

Signature · 2 lines
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics