vdpa/ifc: fix log info mismatch

PATCH Superseded Andy Pei 3 participants 9 messages Dec 13, 2021 – Jan 27, 2022 virtio core

lore

Share & tools

lore

Andy Pei

author

2021-12-13 05:15 UTC #0 lore raw

PATCH 1/3 vdpa/ifc: fix log info mismatch

fix log info mismatch.

Signed-off-by Andy Pei <[email protected]>

---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

drivers/vdpa/ifc/base/ifcvf.c +8 -6

index 721cb1d..d10c1fd 100644
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }

Signature · 1 line

1.8.3.1

Wang, Xiao W

2021-12-13 06:55 UTC #1 lore raw

Hi Andy,

Thanks for the patch.
You need to add the "Fixes: " line.

BRs,
Xiao

Quoted 42 lines

-----Original Message-----
From: Pei, Andy <[email protected]>
Sent: Monday, December 13, 2021 12:29 PM
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xia, Chenbo <[email protected]>; Wang, Xiao W <[email protected]>
Subject: [PATCH 1/3] vdpa/ifc: fix log info mismatch
fix log info mismatch.
Signed-off-by Andy Pei <[email protected]>
---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/vdpa/ifc/base/ifcvf.c +8 -7
index 721cb1d..d10c1fd 100644
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }
--
1.8.3.1

Pei, Andy

author

2021-12-13 07:26 UTC #2 lore raw

Hi Xiao,

"Fixes: " line will be added in V2.
Thanks for reply.

-----Original Message-----
From: Wang, Xiao W <[email protected]>
Sent: Monday, December 13, 2021 2:55 PM
To: Pei, Andy <[email protected]>; [email protected]
Cc: Xia, Chenbo <[email protected]>
Subject: RE: [PATCH 1/3] vdpa/ifc: fix log info mismatch

Hi Andy,

Thanks for the patch.
You need to add the "Fixes: " line.

BRs,
Xiao

Quoted 42 lines

-----Original Message-----
From: Pei, Andy <[email protected]>
Sent: Monday, December 13, 2021 12:29 PM
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xia, Chenbo <[email protected]>; Wang, Xiao W <[email protected]>
Subject: [PATCH 1/3] vdpa/ifc: fix log info mismatch
fix log info mismatch.
Signed-off-by Andy Pei <[email protected]>
---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
(quoted diff) +0 -0
b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644
drivers/vdpa/ifc/base/ifcvf.c +8 -7
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }
--
1.8.3.1

Andy Pei

author

2021-12-13 07:22 UTC #3 lore raw

PATCH v2 1/1 vdpa/ifc: fix log info mismatch

In reply to Andy Pei

fix log info mismatch.

Fixes a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")

Cc [email protected]

Signed-off-by Andy Pei <[email protected]>

---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

drivers/vdpa/ifc/base/ifcvf.c +8 -6

index 721cb1d..d10c1fd 100644
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }

Signature · 1 line

1.8.3.1

Wang, Xiao W

2021-12-13 07:29 UTC #4 lore raw

Hi Andy,

BRs,
Xiao

Quoted 9 lines

-----Original Message-----
From: Pei, Andy <[email protected]>
Sent: Monday, December 13, 2021 2:36 PM
To: [email protected]
Cc: Xia, Chenbo <[email protected]>; Wang, Xiao W <[email protected]>
Subject: [PATCH v2] vdpa/ifc: fix log info mismatch
fix log info mismatch.

Use "Fix".

Quoted 3 lines

Fixes a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc [email protected]

For fix patch, you need to Cc "[email protected]", not me.

Quoted 33 lines

Signed-off-by Andy Pei <[email protected]>

---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

drivers/vdpa/ifc/base/ifcvf.c +8 -7

index 721cb1d..d10c1fd 100644
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }
--

1.8.3.1

Pei, Andy

author

2021-12-13 07:36 UTC #5 lore raw

Hi Xiao,

Thanks for your reply.
I will send a V3 patch to address this.

-----Original Message-----
From: Wang, Xiao W <[email protected]>
Sent: Monday, December 13, 2021 3:30 PM
To: Pei, Andy <[email protected]>; [email protected]
Cc: Xia, Chenbo <[email protected]>
Subject: RE: [PATCH v2] vdpa/ifc: fix log info mismatch

Hi Andy,

BRs,
Xiao

Quoted 9 lines

-----Original Message-----
From: Pei, Andy <[email protected]>
Sent: Monday, December 13, 2021 2:36 PM
To: [email protected]
Cc: Xia, Chenbo <[email protected]>; Wang, Xiao W <[email protected]>
Subject: [PATCH v2] vdpa/ifc: fix log info mismatch
fix log info mismatch.

Use "Fix".

Quoted 3 lines

Fixes a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc [email protected]

For fix patch, you need to Cc "[email protected]", not me.

Quoted 33 lines

Signed-off-by Andy Pei <[email protected]>

---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

(quoted diff) +0 -0

b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644

drivers/vdpa/ifc/base/ifcvf.c +8 -7

@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }
--

1.8.3.1

Andy Pei

author

2021-12-13 07:46 UTC #6 lore raw

PATCH v3 1/1 vdpa/ifc: fix log info mismatch

In reply to Andy Pei

Fix log info mismatch.

Fixes a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")

Cc [email protected]

Signed-off-by Andy Pei <[email protected]>

---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

drivers/vdpa/ifc/base/ifcvf.c +8 -6

index 721cb1d..d10c1fd 100644
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }

Signature · 1 line

1.8.3.1

Xia, Chenbo

Reviewed-by on v3 1/1

2022-01-14 07:22 UTC #7 lore raw

Quoted 43 lines

-----Original Message-----
From: Pei, Andy <[email protected]>
Sent: Monday, December 13, 2021 3:01 PM
To: [email protected]
Cc: Xia, Chenbo <[email protected]>; [email protected]
Subject: [PATCH v3] vdpa/ifc: fix log info mismatch
Fix log info mismatch.
Fixes a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc [email protected]
Signed-off-by Andy Pei <[email protected]>
---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/vdpa/ifc/base/ifcvf.c +8 -7
index 721cb1d..d10c1fd 100644
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }
--

Quoted 1 line

1.8.3.1

Reviewed-by Chenbo Xia <[email protected]>

Xia, Chenbo

Applied

2022-01-27 05:14 UTC #8 lore raw

In reply to Andy Pei

Quoted 43 lines

-----Original Message-----
From: Pei, Andy <[email protected]>
Sent: Monday, December 13, 2021 3:01 PM
To: [email protected]
Cc: Xia, Chenbo <[email protected]>; [email protected]
Subject: [PATCH v3] vdpa/ifc: fix log info mismatch
Fix log info mismatch.
Fixes a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc [email protected]
Signed-off-by Andy Pei <[email protected]>
---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/vdpa/ifc/base/ifcvf.c +8 -7
index 721cb1d..d10c1fd 100644
@@ -94,12 +94,14 @@
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }
--

Quoted 1 line

1.8.3.1

Applied to next-virtio/main, thanks