microblaze: add Emaclite ethernet driver
A message that is not in the archive (sent off-list or not yet received): de470d32d7222874eac8134583889844c80e4bcb.1206711077.git.monstr@monstr.eu
PATCH 4/13 microblaze: add Emaclite ethernet driver
Quoted 4 lines · In message <de470d32d7222874eac8134583889844c80e4bcb.1206711077.git.monstr@mons…
From: Michal Simek <[email protected]>
Signed-off-by Michal Simek <[email protected]>
I see you sneaked this in via your microblaze custodian repo. This was a Bad Thing, and I ask you not to do such things. You were supposed to run this through the Net custodian.
Ditto for [PATCH 05/13] microblaze: add Emac ethernet driver
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You Don't Have To Be 'Damned' To Work Here, But It Helps!!!
- Terry Pratchett, _Eric_PATCH 4/13 microblaze: add Emaclite ethernet driver
Hi Wolfgang,
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
For Ben.
Can you look at drivers/net/xilinx_emac.c and xilinx_emaclite.c?
Quoted 5 lines
Quoted 1 line
Signed-off-by Michal Simek <[email protected]>I see you sneaked this in via your microblaze custodian repo. This was a Bad Thing, and I ask you not to do such things. You were supposed to run this through the Net custodian.
Sorry for that. Explanation is above.
Quoted 5 lines
Ditto for [PATCH 05/13] microblaze: add Emac ethernet driver
Best regards,
Wolfgang Denk
Best regards,
Michal Simek
PATCH 4/13 microblaze: add Emaclite ethernet driver
Dear Michal,
Quoted 3 lines · in message <[email protected]> you wrote:
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
Maybe, I don't remember the details. But if Ben had accepted the patch, he would have checked it into the u-boot-net custodian repository, where network stuff belongs to.
It should not go through other repositories normally (unless Ben gives his explicit permission).
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "The lesser of two evils -- is evil." - Seymour (Sy) Leon
PATCH 4/13 microblaze: add Emaclite ethernet driver
Quoted 8 lines · Wolfgang Denk
Dear Michal,
Quoted 3 lines · in message <[email protected]> you wrote:
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
Quoted 7 lines
Maybe, I don't remember the details. But if Ben had accepted the patch, he would have checked it into the u-boot-net custodian repository, where network stuff belongs to.
It should not go through other repositories normally (unless Ben gives his explicit permission).
I did see these patches, but haven't reviewed yet. I'll have a look in the next couple of days and will provide feedback.
regards,
Ben
PATCH 4/13 microblaze: add Emaclite ethernet driver
Hi Ben,
Quoted 15 lines
Quoted 7 lines
Dear Michal,
Quoted 3 lines · in message <[email protected]> you wrote:
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
Quoted 7 lines
Maybe, I don't remember the details. But if Ben had accepted the patch, he would have checked it into the u-boot-net custodian repository, where network stuff belongs to.
It should not go through other repositories normally (unless Ben gives his explicit permission).
Quoted 5 lines
I did see these patches, but haven't reviewed yet. I'll have a look in the next couple of days and will provide feedback.
regards,
Ben
Thanks for it,
Michal Simek