Skip to contentSkip to conversation

gfs2: gfs2_walk_metadata fix

PATCH Superseded Andreas Gruenbacher 2 participants 2 messages Aug 5, 2019 GFS2 file system

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Andreas Gruenbacher

author maintainer
#0 lore raw

PATCH 1/1 gfs2: gfs2_walk_metadata fix

In gfs2_walk_metadata, always reset mp->mp_list when decreasing the current height. Otherwise, gfs2_walk_metadata can end up skipping metadata.

---
 fs/gfs2/bmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/gfs2/bmap.c +1 -1
index 327efee82060..9fe1793ebf6f 100644
@@ -485,6 +485,7 @@ static int gfs2_walk_metadata(struct inode *inode, sector_t lblock,
 		}
 		brelse(mp->mp_bh[hgt]);
 		mp->mp_bh[hgt] = NULL;
+		mp->mp_list[hgt] = 0;
 		if (!hgt)
 			break;
 		hgt--;
@@ -495,7 +496,6 @@ static int gfs2_walk_metadata(struct inode *inode, sector_t lblock,
 		start = metapointer(hgt, mp);
 		end = metaend(hgt, mp);
 		if (start >= end) {
-			mp->mp_list[hgt] = 0;
 			if (!hgt)
 				break;
 			goto lower_metapath;
Signature · 1 line
2.20.1