ocfs2: Allow uid/gid/perm changes of symlinks
PATCH 1/1 ocfs2: Allow uid/gid/perm changes of symlinks
This patch adds the ability to change attributes of a symlink. Fixes oss bugzilla#963
http://oss.oracle.com/bugzilla/show_bug.cgi?id=963
--- fs/ocfs2/file.c | 4 ++++ fs/ocfs2/symlink.c | 2 ++ 2 files changed, 6 insertions(+), 0 deletions(-)
fs/ocfs2/file.c +4 -0
@@ -1048,6 +1048,10 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr)mlog_entry ("(0x%p, '%.*s')\n" , dentry, dentry->d_name.len, dentry->d_name.name); +/* ensuring we don't even attempt to truncate a symlink */ +if (S_ISLNK (inode->i_mode)) + attr->ia_valid &= ~ATTR_SIZE ; +if (attr->ia_valid &ATTR_MODE )mlog (0 ,"mode change: %d\n" , attr->ia_mode);if (attr->ia_valid &ATTR_UID )
fs/ocfs2/symlink.c +2 -0
@@ -167,9 +167,11 @@ const struct inode_operations ocfs2_symlink_inode_operations = { .readlink = page_readlink, .follow_link = ocfs2_follow_link, .getattr = ocfs2_getattr, + .setattr = ocfs2_setattr, };const struct inode_operations ocfs2_fast_symlink_inode_operations = { .readlink = ocfs2_readlink, .follow_link = ocfs2_follow_link, .getattr = ocfs2_getattr, + .setattr = ocfs2_setattr, };
Signature · 1 line
1.5.3.6
PATCH 1/1 ocfs2: Allow uid/gid/perm changes of symlinks
Quoted 3 lines · Sunil Mushran
This patch adds the ability to change attributes of a symlink. Fixes oss bugzilla#963
http://oss.oracle.com/bugzilla/show_bug.cgi?id=963
Ok, that looks good - thanks.
--Mark
--
Mark Fasheh
PATCH 1/1 ocfs2: Allow uid/gid/perm changes of symlinks
Hi Mark,
I have read all the materials. Just curious about why ocfs2 super block
don't support ->dirty_inode like ext3 does. If we support it and call ocfs2_make_inode_dirty in it, it should be OK. So is there any reason why we don't support ->dirty_inode?
Thanks.
Regards,
Tao
Quoted 15 lines · Mark Fasheh
Quoted 3 lines · Sunil Mushran
This patch adds the ability to change attributes of a symlink. Fixes oss bugzilla#963
http://oss.oracle.com/bugzilla/show_bug.cgi?id=963Ok, that looks good - thanks.
--Mark--
Mark Fasheh_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel