Skip to contentSkip to conversation

siimage: do clocking register posting earlier in setup_mmio_siimage()

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Apr 9, 2008 – Apr 19, 2008 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 1/3 siimage: do clocking register posting earlier in setup_mmio_siimage()

Do clocking register posting earlier in setup_mmio_siimage() to match code in init_chipset_siimage().

This is a preparation for the next patch which merges PCI and MMIO code paths together.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/pci/siimage.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/ide/pci/siimage.c +3 -3
Index: b/drivers/ide/pci/siimage.c
===================================================================
@@ -521,7 +521,9 @@ static unsigned int setup_mmio_siimage (
 			writeb(tmpbyte & ~0x20, ioaddr + 0x4A);
 			break;
 	}
-	
+
+	tmpbyte = readb(ioaddr + 0x4A);
+
 	writeb(      0x72, ioaddr + 0xA1);
 	writew(    0x328A, ioaddr + 0xA2);
 	writel(0x62DD62DD, ioaddr + 0xA4);

@@ -540,8 +542,6 @@ static unsigned int setup_mmio_siimage (
 		writel(0x00680000, ioaddr + 0x1C8);
 	}
 
-	tmpbyte = readb(ioaddr + 0x4A);
-
 	proc_reports_siimage(dev, (tmpbyte>>4), name);
 	return 1;
 }