Fix show_boot_progress prototype
PATCH 1/1 Fix show_boot_progress prototype
in commit fad634071 "make show_boot_progress () weak." show_boot_progress is supposed to be declared as weak but declare as inline instead of.
include/common.h +1 -1
@@ -661,7 +661,7 @@ int pcmcia_init (void);/* * Board-specific Platform code can reimplement show_boot_progress () if needed */ -void inline show_boot_progress (int val); +void __attribute__((weak))show_boot_progress (int val);#ifdef CONFIG_INIT_CRITICAL #error CONFIG_INIT_CRITICAL is deprecated!
Signature · 1 line
1.5.4.5
PATCH 1/1 image: remove inline for image_print_contents and image_print_contents_noindent
common/image.c +2 -2
@@ -366,12 +366,12 @@ static void __image_print_contents (image_header_t *hdr, const char *p) } } -inline void image_print_contents (image_header_t *hdr) +void image_print_contents (image_header_t *hdr) {__image_print_contents (hdr," " ); } -inline void image_print_contents_noindent (image_header_t *hdr) +void image_print_contents_noindent (image_header_t *hdr) {__image_print_contents (hdr,"" ); }
include/image.h +2 -2
@@ -392,8 +392,8 @@ ulong image_multi_count (image_header_t *hdr);void image_multi_getimg (image_header_t *hdr,ulong idx,ulong *data,ulong *len); -inline void image_print_contents (image_header_t *hdr); -inline void image_print_contents_noindent (image_header_t *hdr); +void image_print_contents (image_header_t *hdr); +void image_print_contents_noindent (image_header_t *hdr);#ifndef USE_HOSTCC static inline int image_check_target_arch (image_header_t *hdr)
Signature · 1 line
1.5.4.5
PATCH 1/1 image: remove inline for image_print_contents and image_print_contents_noindent
Quoted 1 line · In message <[email protected]> you wrote:
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Would you please explain *why* you are doing this?
Best regards,
Wolfgang Denk
Signature · 8 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The so-called "desktop metaphor" of today's workstations is instead
an "airplane-seat" metaphor. Anyone who has shuffled a lap full of
papers while seated between two portly passengers will recognize the
difference -- one can see only a very few things at once.
- Fred Brooks, Jr.PATCH 1/1 image: remove inline for image_print_contents and image_print_contents_noindent
In reply to Jean-Christophe PLAGNIOL-VILLARDQuoted 1 line · Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Hi Jean-Christophe,
Please have a look at my patch:
Date: Fri, 18 Apr 2008 12:39:23 +0200
Subject: [U-Boot-Users] [PATCH v2] Memory footprint optimizations
It rearranges image printing functions, in particular it removes the image_print_contents_noindent() function and changes the implementation of image_print_contents() making it non-inline among other things. So it seems that your changes will not be necessary eventually (apart from the rationale for them, which Wolfgang has already asked about).
Regards,
Bartlomiej
Wolfgang Denk
AppliedPATCH 1/1 Fix show_boot_progress prototype
In reply to Jean-Christophe PLAGNIOL-VILLARDinclude/common.h
Quoted 8 lines · In message <[email protected]> you wrote:
in commit
fad634071"makeshow_boot_progress() weak."show_boot_progressis supposed to be declared as weak but declare as inline instead of.Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>include/common.h +0
-0
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "What if" is a trademark of Hewlett Packard, so stop using it in your sentences without permission, or risk being sued.