Skip to contentSkip to conversation

mpc83xx: update the default load address for 837xemds board

PATCH New Dave Liu 3 participants 4 messages Apr 15, 2008 – Apr 22, 2008

lore
Share & tools
lore

Dave Liu

author
#0 lore raw

PATCH 1/3 mpc83xx: update the default load address for 837xemds board

Update the default load address. if not, the kernel image will be overwritten when u-boot boot the latest linux kernel.

Signed-off-by Dave Liu <[email protected]>
---
 include/configs/MPC837XEMDS.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/MPC837XEMDS.h +2 -2
index 7fc0f7e..b2b4aa1 100644
@@ -595,7 +595,7 @@
 
 #define CONFIG_BAUDRATE 115200
 
-#define CONFIG_LOADADDR 200000	/* default location for tftp and bootm */
+#define CONFIG_LOADADDR 2000000	/* default location for tftp and bootm */
 
 #define CONFIG_BOOTDELAY 6	/* -1 disables auto-boot */
 #undef CONFIG_BOOTARGS		/* the boot command will set bootargs */

@@ -605,7 +605,7 @@
    "consoledev=ttyS0\0"							\
    "ramdiskaddr=1000000\0"						\
    "ramdiskfile=ramfs.83xx\0"						\
-   "fdtaddr=400000\0"							\
+   "fdtaddr=3000000\0"							\
    "fdtfile=mpc8379_mds.dtb\0"						\
    ""
Signature · 1 line
1.5.4.rc4
#1 lore raw

PATCH 1/3 mpc83xx: update the default load address for 837xemds board

Quoted 22 lines · On Tue, 15 Apr 2008 13:10:29 +0800 Dave Liu <[email protected]> wrote:

Update the default load address. if not, the kernel image will be overwritten when u-boot boot the latest linux kernel.

Signed-off-by Dave Liu <[email protected]>
---
 include/configs/MPC837XEMDS.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/MPC837XEMDS.h +1 -1
index 7fc0f7e..b2b4aa1 100644
@@ -595,7 +595,7 @@
 
 #define CONFIG_BAUDRATE 115200
 
-#define CONFIG_LOADADDR 200000	/* default location for tftp and bootm */
+#define CONFIG_LOADADDR 2000000	/* default location for tftp and bootm */
 
 #define CONFIG_BOOTDELAY 6	/* -1 disables auto-boot */
 #undef CONFIG_BOOTARGS		/* the boot command will set bootargs */

include/configs/MPC837XEMDS.h line 608

Quoted 5 lines
include/configs/MPC837XEMDS.h +1 -1
@@ -605,7 +605,7 @@
    "consoledev=ttyS0\0"							\
    "ramdiskaddr=1000000\0"						\
    "ramdiskfile=ramfs.83xx\0"						\
-   "fdtaddr=400000\0"							\
+   "fdtaddr=3000000\0"							\

is such a drastic difference really necessary? how about we double them instead?

Kim

#2 lore raw

PATCH 1/3 mpc83xx: update the default load address for 837xemds board

Quoted 34 lines · Kim Phillips
Quoted 22 lines · On Tue, 15 Apr 2008 13:10:29 +0800 Dave Liu <[email protected]> wrote:

Update the default load address. if not, the kernel image will be overwritten when u-boot boot the latest linux kernel.

Signed-off-by Dave Liu <[email protected]>
---
 include/configs/MPC837XEMDS.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/MPC837XEMDS.h +1 -1
index 7fc0f7e..b2b4aa1 100644
@@ -595,7 +595,7 @@
 
 #define CONFIG_BAUDRATE 115200
 
-#define CONFIG_LOADADDR 200000	/* default location for tftp and bootm */
+#define CONFIG_LOADADDR 2000000	/* default location for tftp and bootm */
 
 #define CONFIG_BOOTDELAY 6	/* -1 disables auto-boot */
 #undef CONFIG_BOOTARGS		/* the boot command will set bootargs */

include/configs/MPC837XEMDS.h line 608

Quoted 5 lines
include/configs/MPC837XEMDS.h +1 -1
@@ -605,7 +605,7 @@
    "consoledev=ttyS0\0"							\
    "ramdiskaddr=1000000\0"						\
    "ramdiskfile=ramfs.83xx\0"						\
-   "fdtaddr=400000\0"							\
+   "fdtaddr=3000000\0"							\

is such a drastic difference really necessary? how about we double them instead?

Quoted 1 line

Kim

Hi Kim, Dave,

The current recommended practice on the denx.de wiki is to have a 12K FDT blob (0x3000). My latest personal convention for memory locations is to put the FDT blob at a semi-arbitrary base address and set the loadaddr 32K higher (could use 64K if we want to be paranoid about blob growth). The advantage is that the kernel can grow or shrink (ha!) fairly often, but the blob should remain fairly small and fairly constant.

This is better than dropping pieces all over memory.

This is what I've been running lately:
setenv fdtaddr 400000
setenv loadaddr 408000
setenv ramdiskaddr 1000000

Best regards,
gvb

author
#3 lore raw

PATCH 1/3 mpc83xx: update the default load address for 837xemds board

In reply to Kim Phillips
Quoted 19 lines
Quoted 19 lines

Update the default load address. if not, the kernel image will be overwritten when u-boot boot the latest linux kernel.

Signed-off-by Dave Liu <[email protected]>
---
 include/configs/MPC837XEMDS.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/MPC837XEMDS.h +1 -1
index 7fc0f7e..b2b4aa1 100644
@@ -595,7 +595,7 @@
 
 #define CONFIG_BAUDRATE 115200
 
-#define CONFIG_LOADADDR 200000	/* default location for tftp and bootm */
+#define CONFIG_LOADADDR 2000000	/* default location for tftp and bootm */
Quoted 11 lines

include/configs/MPC837XEMDS.h line 608

Quoted 8 lines
include/configs/MPC837XEMDS.h +1 -1
 #define CONFIG_BOOTDELAY 6	/* -1 disables auto-boot */
 #undef CONFIG_BOOTARGS		/* the boot command will set bootargs */

@@ -605,7 +605,7 @@
    "consoledev=ttyS0\0"							\
    "ramdiskaddr=1000000\0"						\
    "ramdiskfile=ramfs.83xx\0"						\
-   "fdtaddr=400000\0"							\
+   "fdtaddr=3000000\0"							\

is such a drastic difference really necessary? how about we double them instead?

Of course, double them is also OK.

I set them as sort. it's better to remember.

ramdiskaddr = 0x1000000
loadaddr = 0x2000000
fdtaddr = 0x3000000.

Thanks,
Dave