Skip to contentSkip to conversation

memcg: remove redundant initialization in mem_cgroup_create()

PATCH In review Li Zefan 3 participants 3 messages Apr 23, 2008

Subsystems (2)
Memory management memcg
lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 memcg: remove redundant initialization in mem_cgroup_create()

*mem has been zeroed, that means mem->info has already been filled with 0.

Signed-off-by Li Zefan <[email protected]>
---
 mm/memcontrol.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
mm/memcontrol.c +0 -2
index eefa750..020e8f5 100644
@@ -1014,8 +1014,6 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
 
 	res_counter_init(&mem->res);
 
-	memset(&mem->info, 0, sizeof(mem->info));
-
 	for_each_node_state(node, N_POSSIBLE)
 		if (alloc_mem_cgroup_per_zone_info(mem, node))
 			goto free_out;

-- 1.5.4.rc3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Acked-by
#2 lore raw
Quoted 9 lines · KAMEZAWA Hiroyuki
Quoted 3 lines · On Wed, 23 Apr 2008 10:26:26 +0800 Li Zefan <[email protected]> wrote:

*mem has been zeroed, that means mem->info has already been filled with 0.

maybe my mistake :(

Acked-by KAMEZAWA Hiroyuki <[email protected]>
Acked-by Balbir Singh <[email protected]>
Signature · 10 lines
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>