Add support for the ixp465 processor
PATCH 1/3 Add support for the ixp465 processor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: basic-ixp465-processor-support.patch
Type: text/x-patch
Size: 6108 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080428/39839d7c/attachment.bin
PATCH 1/3 Add support for the ixp465 processor
Quoted 2 lines · In message <[email protected]> you wrote:
This patch add basic support to the ixp465 cpu.
...
Quoted 15 lines
cpu/ixp/start.S +2
-1@@ -29,7 +29,8 @@ #include <config.h> #include <version.h> -#include <asm/arch/ixp425.h> + +#include <asm/arch/hardware.h> #define MMU_Control_M 0x001 /* Enable MMU */ #define MMU_Control_A 0x002 /* Enable address alignment faults */
cpu/ixp/start.S reset: · line 159
Quoted 1 line
cpu/ixp/start.S +0
-0@@ -158,6 +159,16 @@ reset: ldr r2, =IXP425_EXP_CS0
--------------------^^^^^^^^^^^^^^^^
Seems there is IXP425 specific stuff here. Please verify that this is correct. If it is correct, then probably the name should be changed.
Quoted 1 line
cpu/ixp/start.S +1
-0+#ifdef CONFIG_IXP465
...
Quoted 1 line
+#ifdef
CONFIG_IXP425
...
Quoted 1 line
+#ifdef
CONFIG_IXP465
...
Quoted 1 line
+#ifdef
CONFIG_IXP465
...
Quoted 1 line
+#else
...
Quoted 1 line
+#ifdef
CONFIG_IXP465
...
Quoted 1 line
+#ifdef
CONFIG_IXP465
...
Quoted 1 line
+#else
That's a pretty mess of #ifdef's.
Maybe we should split this into separate source files?
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If you hear an onion ring, answer it.
PATCH 1/3 Add support for the ixp465 processor
Hi,
thanks for your comment.
Quoted 25 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:
This patch add basic support to the ixp465 cpu.
...
Quoted 15 lines
cpu/ixp/start.S +2
-1@@ -29,7 +29,8 @@ #include <config.h> #include <version.h> -#include <asm/arch/ixp425.h> + +#include <asm/arch/hardware.h> #define MMU_Control_M 0x001 /* Enable MMU */ #define MMU_Control_A 0x002 /* Enable address alignment faults */cpu/ixp/start.S reset: · line 160
Quoted 2 lines
cpu/ixp/start.S +0
-0@@ -158,6 +159,16 @@ reset: ldr r2, =IXP425_EXP_CS0--------------------^^^^^^^^^^^^^^^^
Quoted 4 lines
Seems there is IXP425 specific stuff here. Please verify that this is correct. If it is correct, then probably the name should be changed.
I think about to merge the two includes file. Maybe I take it from linux and use that one.
There a lot of information shared. In linux the name is for example IXP4XX_ ...
What do you think about it?
Quoted 5 lines
Quoted 1 line
cpu/ixp/start.S +1
-0+#ifdef CONFIG_IXP465...
Quoted 2 lines
+#ifdef
CONFIG_IXP465
Quoted 10 lines
...
Quoted 2 lines
+#else
That's a pretty mess of #ifdef's.
Maybe we should split this into separate source files?
I try to write just one ifdef, and duplicate a little bit the code. Is good for you?
Quoted 5 lines
Best regards,
Wolfgang Denk
Michael