Add support for the ixdp465 evaluation board
PATCH 3/3 Add support for the ixdp465 evaluation board
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-ixdp465-basic-board-support.patch
Type: text/x-patch
Size: 18768 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080428/aa7cf769/attachment.bin
PATCH 3/3 Add support for the ixdp465 evaluation board
Quoted 5 lines · In message <[email protected]> you wrote:
Add support for the ixdp465 evaluation board
Signed-off-by Michael Trimarchi <[email protected]>
Quoted 15 lines
--- Makefile | 3 + board/ixdp465/Makefile | 47 ++++++++ board/ixdp465/config.mk | 3 + board/ixdp465/ixdp465.c | 62 ++++++++++ board/ixdp465/lowlevel_init.S | 129 +++++++++++++++++++++ board/ixdp465/u-boot.lds | 57 +++++++++ include/configs/ixdp465.h | 251 +++++++++++++++++++++++++++++++++++++++++ 7 files changed, 552 insertions(+), 0 deletions(-) create mode 100644 board/ixdp465/Makefile create mode 100644 board/ixdp465/config.mk create mode 100644 board/ixdp465/ixdp465.c create mode 100644 board/ixdp465/lowlevel_init.S create mode 100644 board/ixdp465/u-boot.lds create mode 100644 include/configs/ixdp465.h
Entries in README, MAINTAINERS and MAKEALL missing.
Quoted 2 lines
board/ixdp465/Makefile new file +0
-0
...
Quoted 5 lines
board/ixdp465/Makefile new file +5
-0+include $(TOPDIR)/config.mk + +LIB = lib$(BOARD).a + +OBJS := ixdp465.o
board/ixdp465/Makefile
Quoted 10 lines
board/ixdp465/Makefile new file +10
-0+SOBJS := lowlevel_init.o + +$(LIB): $(OBJS) $(SOBJS) + $(AR) crv $@ $^ + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend
Support for out-of-tree builds is missing completely.
Quoted 19 lines
board/ixdp465/config.mk new file +3
-0@@ -0,0 +1,3 @@ +TEXT_BASE = 0x01600000 +# include NPE ethernet driver +BOARDLIBS = $(obj)cpu/ixp/npe/libnpe.aboard/ixdp465/ixdp465.c new file +0
-0include/configs/ixdp465.h new file +0
-0
...
include/configs/ixdp465.h
Quoted 4 lines
include/configs/ixdp465.h new file +4
-0+/*#define CONFIG_ETHADDR 08:00:3e:26:0a:5b*/ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR 10.30.3.204 +#define CONFIG_SERVERIP 10.30.3.72
Please omit such network config data from thje config file; they are almost always wrong and a PITA to the end user.
include/configs/ixdp465.h
Quoted 3 lines
include/configs/ixdp465.h new file +3
-0+#define CONFIG_EXTRA_ENV_SETTINGS \ + "ethaddr=00:02:b3:01:01:01\0" \ + "eth1addr=00:02:b3:02:02:02\0"
Never do this.
Also, the MAC addresses above belong to the Intel Corporation; I doubt you have permissions to use these on your boards.
include/configs/ixdp465.h
Quoted 3 lines
include/configs/ixdp465.h new file +3
-0+#define CONFIG_NR_DRAM_BANKS 1/* we have 2 banks of DRAM */ +#define PHYS_SDRAM_1 0x00000000/* SDRAM Bank #1 */ +#define PHYS_SDRAM_1_SIZE 0x08000000/* 128 MB */
Please avoid hard-wired RAM sizes. Try to auto-adjust like most other boards are doing.
include/configs/ixdp465.h
Quoted 4 lines
include/configs/ixdp465.h new file +4
-0+#define PHYS_FLASH_1 0x50000000/* Flash Bank #1 */ +#define PHYS_FLASH_SIZE 0x02000000/* 32 MB */ +#define PHYS_FLASH_BANK_SIZE 0x02000000/* 32 MB Banks */ +#define PHYS_FLASH_SECT_SIZE 0x00020000/* 128 KB sectors (x1) */
Ditto here.
include/configs/ixdp465.h
Quoted 2 lines
include/configs/ixdp465.h new file +2
-0+#define CFG_DRAM_BASE 0x00000000 +#define CFG_DRAM_SIZE 0x08000000
Is this SDRAM or DRAM ? Seems to be a bit redundant here...
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Any time things appear to be going better, you have overlooked some- thing.
PATCH 3/3 Add support for the ixdp465 evaluation board
Hi
Quoted 10 lines
Ditto here.
Review
Quoted 3 lines
(quoted diff) +2
-0+#define CFG_DRAM_BASE 0x00000000 +#define CFG_DRAM_SIZE 0x08000000Is this SDRAM or DRAM ? Seems to be a bit redundant here...
Quoted 5 lines
Best regards,
Wolfgang Denk
Ok for all
Regards Michael