Skip to contentSkip to conversation

net: eepro autoport typo

PATCH Applied Harvey Harrison 2 participants 2 messages Apr 27, 2008 – Apr 29, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Harvey Harrison

author
#0 lore raw

PATCH 1/1 net: eepro autoport typo

Found by sparse dubious !x & y warning...hidden in the GetBit macro why !Word doesn't make any sense.

Signed-off-by Harvey Harrison <[email protected]>
---
 drivers/net/eepro.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/eepro.c +1 -1
index 83bda6c..56f5049 100644
@@ -633,7 +633,7 @@ static void __init printEEPROMInfo(struct net_device *dev)
 		printk(KERN_DEBUG " PC: %d\n", GetBit(Word,ee_PC));
 		printk(KERN_DEBUG " TPE/AUI: %d\n", GetBit(Word,ee_TPE_AUI));
 		printk(KERN_DEBUG " Jabber: %d\n", GetBit(Word,ee_Jabber));
-		printk(KERN_DEBUG " AutoPort: %d\n", GetBit(!Word,ee_Jabber));
+		printk(KERN_DEBUG " AutoPort: %d\n", !GetBit(Word,ee_AutoPort));
 		printk(KERN_DEBUG " Duplex: %d\n", GetBit(Word,ee_Duplex));
 	}
Signature · 1 line
1.5.5.1.270.g89765
Applied
#1 lore raw
Quoted 13 lines · Harvey Harrison

Found by sparse dubious !x & y warning...hidden in the GetBit macro why !Word doesn't make any sense.

Signed-off-by Harvey Harrison <[email protected]>
---
 drivers/net/eepro.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/eepro.c +0 -0
index 83bda6c..56f5049 100644

drivers/net/eepro.c static void __init printEEPROMInfo(struct net_device *dev) · line 637

Quoted 6 lines
drivers/net/eepro.c +1 -1
@@ -633,7 +633,7 @@ static void __init printEEPROMInfo(struct net_device *dev)
 		printk(KERN_DEBUG " PC: %d\n", GetBit(Word,ee_PC));
 		printk(KERN_DEBUG " TPE/AUI: %d\n", GetBit(Word,ee_TPE_AUI));
 		printk(KERN_DEBUG " Jabber: %d\n", GetBit(Word,ee_Jabber));
-		printk(KERN_DEBUG " AutoPort: %d\n", GetBit(!Word,ee_Jabber));
+		printk(KERN_DEBUG " AutoPort: %d\n", !GetBit(Word,ee_AutoPort));
 		printk(KERN_DEBUG " Duplex: %d\n", GetBit(Word,ee_Duplex));

applied