Skip to contentSkip to conversation

drivers/net EtherExpress 16 : IPv6 not working with this driver

PATCH New Bruce Robson 1 participant 1 message Apr 30, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Bruce Robson

author
#0 lore raw

PATCH 1/1 drivers/net EtherExpress 16 : IPv6 not working with this driver

From: Bruce Robson <[email protected]>

Corrects loading of multi-cast addresses. Thereby allowing IPv6 neighbour discovery to work.

Signed-off-by Bruce Robson <[email protected]>

---

The driver sources file eexpress.c contains an approximately 30 line function eexp_setup_filter used when loading multicast addresses. There were 3 problems in this function
1) It wrote the number of multicast addresses to the card instead of the number of bytes in the multicast addresses.
2) When loading multiple multicast addresses it loaded the first one provided multiple times instead of loading each one once.
3) The setting of pointer 'data' from 'dmi->dmi_addr' occured before the test for the error situation of 'dmi' being NULL.

There is some information on the Intel EtherExpress 16 at
http://www.intel.com/support/etherexpress/vintage/sb/cs-013500.htm
Datasheet for the Intel 82586 ethernet controller used by the card
http://www.datasheetcatalog.com/datasheets_pdf/8/2/5/8/82586.shtml

net/eexpress.c renamed from net/eexpress.c.000 +6 -5
@@ -201,9 +201,9 @@ static unsigned short start_code[] = {
 
 	0x0000,Cmd_MCast,
 	0x0076,                 /* link to next command */
 #define CONF_NR_MULTICAST 0x44
-	0x0000,                 /* number of multicast addresses */
+	0x0000,                 /* number of bytes in multicast address(es) */
 #define CONF_MULTICAST 0x46
 	0x0000, 0x0000, 0x0000, /* some addresses */
 	0x0000, 0x0000, 0x0000,
 	0x0000, 0x0000, 0x0000,

@@ -1568,9 +1568,9 @@ static void eexp_hw_init586(struct net_d
 }
 
 static void eexp_setup_filter(struct net_device *dev)
 {
-	struct dev_mc_list *dmi = dev->mc_list;
+	struct dev_mc_list *dmi;
 	unsigned short ioaddr = dev->base_addr;
 	int count = dev->mc_count;
 	int i;
 	if (count > 8) {

@@ -1579,19 +1579,20 @@ static void eexp_setup_filter(struct net
 		count = 8;
 	}
 
 	outw(CONF_NR_MULTICAST & ~31, ioaddr+SM_PTR);
-	outw(count, ioaddr+SHADOW(CONF_NR_MULTICAST));
-	for (i = 0; i < count; i++) {
-		unsigned short *data = (unsigned short *)dmi->dmi_addr;
+	outw(6*count, ioaddr+SHADOW(CONF_NR_MULTICAST));
+	for (i = 0, dmi = dev->mc_list; i < count; i++, dmi = dmi->next) {
+		unsigned short *data;
 		if (!dmi) {
 			printk(KERN_INFO "%s: too few multicast addresses\n", dev->name);
 			break;
 		}
 		if (dmi->dmi_addrlen != ETH_ALEN) {
 			printk(KERN_INFO "%s: invalid multicast address length given.\n", dev->name);
 			continue;
 		}
+		data = (unsigned short *)dmi->dmi_addr;
 		outw((CONF_MULTICAST+(6*i)) & ~31, ioaddr+SM_PTR);
 		outw(data[0], ioaddr+SHADOW(CONF_MULTICAST+(6*i)));
 		outw((CONF_MULTICAST+(6*i)+2) & ~31, ioaddr+SM_PTR);
 		outw(data[1], ioaddr+SHADOW(CONF_MULTICAST+(6*i)+2));