Fix of_i2c include for module compilation
Subsystems (2)
PATCH 1/1 Fix of_i2c include for module compilation
Now that of_i2c may be compiled as module, the header must be exported for module compilation, as well.
--- include/linux/of_i2c.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/of_i2c.h +1 -1
@@ -14,7 +14,7 @@#include <linux/i2c.h> -#ifdef CONFIG_OF_I2C +#if defined(CONFIG_OF_I2C ) || defined(CONFIG_OF_I2C_MODULE )void of_register_i2c_devices (struct i2c_adapter *adap,struct device_node *adap_node);
Signature · 1 line
1.5.5.1
include/linux/of_i2c.h line 20
Quoted 5 lines · Jochen Friedrich
include/linux/of_i2c.h +1
-1-#ifdef CONFIG_OF_I2C +#if defined(CONFIG_OF_I2C ) || defined(CONFIG_OF_I2C_MODULE )void of_register_i2c_devices (struct i2c_adapter *adap,struct device_node *adap_node);
Why do we have that ifdef there at all? There's only that one external declaration within it, so the #ifdef and #endif could just be removed. If the ifdef hadn't been there in the first place we wouldn't have had this problem.
Paul.
Hi Paul,
Quoted 10 lines
include/linux/of_i2c.h line 20
Quoted 5 lines
include/linux/of_i2c.h +1
-1-#ifdef CONFIG_OF_I2C +#if defined(CONFIG_OF_I2C ) || defined(CONFIG_OF_I2C_MODULE )void of_register_i2c_devices (struct i2c_adapter *adap,struct device_node *adap_node);Why do we have that ifdef there at all? There's only that one external declaration within it, so the #ifdef and #endif could just be removed. If the ifdef hadn't been there in the first place we wouldn't have had this problem.
You're right. I mainly copied from of_gpio.h without too much thinking :(. I'll resend.
Thanks,
Jochen