Skip to contentSkip to conversation

: Consolidate error paths in br_add_bridge().

PATCH Applied Pavel Emelyanov 2 participants 2 messages May 4, 2008 – May 5, 2008

Subsystems (3)
Networking Network drivers Ethernet bridge
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 2/2 : Consolidate error paths in br_add_bridge().

This actually had to be merged with the patch #1, but I decided not to mix two changes in one patch.

There are already two calls to free_netdev() in there, so merge them into one.

Signed-off-by Pavel Emelyanov <[email protected]>
---
 net/bridge/br_if.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)
net/bridge/br_if.c +8 -8
index bff0f5b..c2397f5 100644
@@ -273,17 +273,13 @@ int br_add_bridge(const char *name)
 	rtnl_lock();
 	if (strchr(dev->name, '%')) {
 		ret = dev_alloc_name(dev, dev->name);
-		if (ret < 0) {
-			free_netdev(dev);
-			goto out;
-		}
+		if (ret < 0)
+			goto out_free;
 	}
 
 	ret = register_netdevice(dev);
-	if (ret) {
-		free_netdev(dev);
-		goto out;
-	}
+	if (ret)
+		goto out_free;
 
 	ret = br_sysfs_addbr(dev);
 	if (ret)

@@ -291,6 +287,10 @@ int br_add_bridge(const char *name)
  out:
 	rtnl_unlock();
 	return ret;
+
+out_free:
+	free_netdev(dev);
+	goto out;
 }
 
 int br_del_bridge(const char *name)
Signature · 1 line
1.5.3.4
maintainer
#1 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Sun, 04 May 2008 10:49:21 +0400

Quoted 7 lines

This actually had to be merged with the patch #1, but I decided not to mix two changes in one patch.

There are already two calls to free_netdev() in there, so merge them into one.

Signed-off-by Pavel Emelyanov <[email protected]>

Looks good, applied.