add config options for VSC8601 RGMII PHY - 2nd try
PATCH 1/1 add config options for VSC8601 RGMII PHY - 2nd try
The Vitesse VSC8601 RGMII PHY has internal delay for both Rx and Tx clock lines. They are configured using 2 bits in extended register 0x17.
Therefore CFG_VSC8601_SKEW_TX and CFG_VSC8601_SKEW_RX have been introduced with valid values 0-3 giving 0.0, 1.4,1.7 and 2.0ns delay.
--
drivers/net/tsec.c | 6 ++++++ drivers/net/tsec.h | 3 +++ 2 files changed, 9 insertions(+), 0 deletions(-)
drivers/net/tsec.c +6 -0
@@ -1277,6 +1277,12 @@ struct phy_info phy_info_VSC8601 = { {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init}, #ifdef CFG_VSC8601_SKEWFIX {MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL}, +#if defined(CFG_VSC8601_SKEW_TX) && defined(CFG_VSC8601_SKEW_RX) + {MIIM_EXT_PAGE_ACCESS,1,NULL}, +#define VSC8101_SKEW (CFG_VSC8601_SKEW_TX<<14)|(CFG_VSC8601_SKEW_RX<<12) + {MIIM_VSC8601_SKEW_CTRL,VSC8101_SKEW,NULL}, + {MIIM_EXT_PAGE_ACCESS,0,NULL}, +#endif #endif {miim_end,}
},
drivers/net/tsec.h +3 -0
@@ -112,6 +112,8 @@#define MIIM_GBIT_CONTROL 0x9#define MIIM_GBIT_CONTROL_INIT 0xe00 +#define MIIM_EXT_PAGE_ACCESS 0x1f +/* Broadcom BCM54xx -- taken from linux sungem_phy */ #define MIIM_BCM54xx_AUXSTATUS 0x19#define MIIM_BCM54xx_AUXSTATUS_LINKMODE_MASK 0x0700
@@ -163,6 +165,7 @@/* Vitesse VSC8601 Extended PHY Control Register 1 */ #define MIIM_VSC8601_EPHY_CON 0x17#define MIIM_VSC8601_EPHY_CON_INIT_SKEW 0x1120 +#define MIIM_VSC8601_SKEW_CTRL 0x1c/* 88E1011 PHY Status Register */ #define MIIM_88E1011_PHY_STATUS 0x11
MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
PATCH 1/1 add config options for VSC8601 RGMII PHY - 2nd try
Quoted 7 lines · Andre Schwarz
The Vitesse VSC8601 RGMII PHY has internal delay for both Rx
and Tx clock lines. They are configured using 2 bits in extended register0x17.
ThereforeCFG_VSC8601_SKEW_TXandCFG_VSC8601_SKEW_RXhave been introduced with valid values 0-3 giving 0.0, 1.4,1.7 and 2.0ns delay.Signed-off-by Andre Schwarz <[email protected]>
PATCH 1/1 add config options for VSC8601 RGMII PHY - 2nd try
In reply to Andre SchwarzQuoted 8 lines · Andre Schwarz
The Vitesse VSC8601 RGMII PHY has internal delay for both Rx and Tx clock lines. They are configured using 2 bits in extended register
0x17.
ThereforeCFG_VSC8601_SKEW_TXandCFG_VSC8601_SKEW_RXhave been introduced with valid values 0-3 giving 0.0, 1.4,1.7 and 2.0ns delay.Signed-off-by Andre Schwarz <[email protected]>
Quoted 4 lines
--
Wolfgang - please apply directly. I believe this one was on your list of outstanding patches.
Quoted 49 lines
drivers/net/tsec.c | 6 ++++++ drivers/net/tsec.h | 3 +++ 2 files changed, 9 insertions(+), 0 deletions(-)drivers/net/tsec.c +6
-0@@ -1277,6 +1277,12 @@ struct phy_info phy_info_VSC8601 = { {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init}, #ifdef CFG_VSC8601_SKEWFIX {MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL}, +#if defined(CFG_VSC8601_SKEW_TX) && defined(CFG_VSC8601_SKEW_RX) + {MIIM_EXT_PAGE_ACCESS,1,NULL}, +#define VSC8101_SKEW (CFG_VSC8601_SKEW_TX<<14)|(CFG_VSC8601_SKEW_RX<<12) + {MIIM_VSC8601_SKEW_CTRL,VSC8101_SKEW,NULL}, + {MIIM_EXT_PAGE_ACCESS,0,NULL}, +#endif #endif {miim_end,}},drivers/net/tsec.h +3
-0@@ -112,6 +112,8 @@#define MIIM_GBIT_CONTROL 0x9#define MIIM_GBIT_CONTROL_INIT 0xe00 +#define MIIM_EXT_PAGE_ACCESS 0x1f +/* Broadcom BCM54xx -- taken from linux sungem_phy */ #define MIIM_BCM54xx_AUXSTATUS 0x19#define MIIM_BCM54xx_AUXSTATUS_LINKMODE_MASK 0x0700@@ -163,6 +165,7 @@/* Vitesse VSC8601 Extended PHY Control Register 1 */ #define MIIM_VSC8601_EPHY_CON 0x17#define MIIM_VSC8601_EPHY_CON_INIT_SKEW 0x1120 +#define MIIM_VSC8601_SKEW_CTRL 0x1c/* 88E1011 PHY Status Register */ #define MIIM_88E1011_PHY_STATUS 0x11MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
Wolfgang Denk
AppliedPATCH 1/1 add config options for VSC8601 RGMII PHY - 2nd try
In reply to Andre SchwarzQuoted 7 lines · In message <[email protected]> you wrote:
The Vitesse VSC8601 RGMII PHY has internal delay for both Rx and Tx clock lines. They are configured using 2 bits in extended register
0x17.
ThereforeCFG_VSC8601_SKEW_TXandCFG_VSC8601_SKEW_RXhave been introduced with valid values 0-3 giving 0.0, 1.4,1.7 and 2.0ns delay.Signed-off-by Andre Schwarz <[email protected]>
Applied, but manually - please fix your Thunderbird configuration, or even better, use git-send-mail to send patches. This is what I get:
Applying add config options for VSC8601 RGMII PHY - 2nd try
error: patch failed: drivers/net/tsec.c:1277
error: drivers/net/tsec.c: patch does not apply
error: patch failed: drivers/net/tsec.h:112
error: drivers/net/tsec.h: patch does not apply Using index info to reconstruct a base tree...
error: patch failed: drivers/net/tsec.c:1277
error: drivers/net/tsec.c: patch does not apply
error: patch failed: drivers/net/tsec.h:112
error: drivers/net/tsec.h: patch does not apply Did you hand edit your patch?
It does not apply to blobs recorded in its index. Cannot fall back to three-way merge.
Patch failed at 0001.
The patch was sent white-space corrupted...
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Prediction is very difficult, especially of the future. - Niels Bohr
PATCH 1/1 add config options for VSC8601 RGMII PHY - 2nd try
Wolfgang,
I'm sorry for that.
Unfortunately I'm stuck to Thunderbird due to company rules.
Thunderbird is configured according to to the kernel-doc page. Obviously there's something going wrong during copy+paste ...
I'll try to find a solution to send correct patches in the future.
Thanks again,
Andr?
Quoted 30 lines · Wolfgang Denk
Quoted 8 lines · In message <[email protected]> you wrote:
The Vitesse VSC8601 RGMII PHY has internal delay for both Rx and Tx clock lines. They are configured using 2 bits in extended register
0x17.
ThereforeCFG_VSC8601_SKEW_TXandCFG_VSC8601_SKEW_RXhave been introduced with valid values 0-3 giving 0.0, 1.4,1.7 and 2.0ns delay.Signed-off-by Andre Schwarz <[email protected]>Applied, but manually - please fix your Thunderbird configuration, or even better, use git-send-mail to send patches. This is what I get:
Applying add config options for VSC8601 RGMII PHY - 2nd try
error: patch failed:drivers/net/tsec.c:1277
error:drivers/net/tsec.c: patch does not apply
error: patch failed:drivers/net/tsec.h:112
error:drivers/net/tsec.h: patch does not apply Using index info to reconstruct a base tree...
error: patch failed:drivers/net/tsec.c:1277
error:drivers/net/tsec.c: patch does not apply
error: patch failed:drivers/net/tsec.h:112
error:drivers/net/tsec.h: patch does not apply Did you hand edit your patch?
It does not apply to blobs recorded in its index. Cannot fall back to three-way merge.
Patch failed at 0001.
Quoted 7 lines
The patch was sent white-space corrupted...
Best regards,
Wolfgang Denk
MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080504/6b71a005/attachment.htm
PATCH 1/1 add config options for VSC8601 RGMII PHY - 2nd try
Quoted 2 lines · On Sun, 04 May 2008 12:19:32 +0200 Andr? Schwarz…
Thunderbird is configured according to to the kernel-doc page. Obviously there's something going wrong during copy+paste ...
according to this:
http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
you might be able to get away with mailing the patch as an attachment.
Can you do this and try sending me the mvblm7 patch again? I'll tell you if it applies.
Kim