: Fake MSR_K7 performance counters
PATCH 1/1 : Fake MSR_K7 performance counters
Attached is a patch that fixes a guest crash when booting older Linux kernels. The problem stems from the fact that we are currently emulating MSR_K7_EVNTSEL[0-3], but not emulating MSR_K7_PERFCTR[0-3]. Because of this, setup_k7_watchdog() in the Linux kernel receives a GPF when it attempts to write into MSR_K7_PERFCTR, which causes an OOPs.
The patch fixes it by just "fake" emulating the appropriate MSRs, throwing away the data in the process. This causes the NMI watchdog to not actually work, but it's not such a big deal in a virtualized environment.
When we get a write to one of these counters, we printk_ratelimit() a warning. I decided to print it out for all writes, even if the data is 0; it doesn't seem to make sense to me to special case when data == 0.
Tested by myself on a RHEL-4 guest, and Joerg Roedel on a Windows XP 64-bit guest.
arch/x86/kvm/svm.c +9 -6
@@ -1312,16 +1312,19 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 data)case MSR_K7_EVNTSEL1 :case MSR_K7_EVNTSEL2 :case MSR_K7_EVNTSEL3 : +case MSR_K7_PERFCTR0 : +case MSR_K7_PERFCTR1 : +case MSR_K7_PERFCTR2 : +case MSR_K7_PERFCTR3 :/* -* only support writing 0 to the performance counters for now -* to make Windows happy. Should be replaced by a real -* performance counter emulation later. +* Just discard all writes to the performance counters; this +* should keep both older linux and windows 64-bit guests +* happy */ -if (data !=0 ) - goto unhandled; +pr_unimpl (vcpu,"unimplemented perfctr wrmsr: 0x%x data 0x%llx\n" , ecx, data); +break ;default : - unhandled:return kvm_set_msr_common (vcpu, ecx, data); }return 0 ;
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel
Avi Kivity
AppliedQuoted 10 lines · Chris Lalancette
Attached is a patch that fixes a guest crash when booting older Linux kernels. The problem stems from the fact that we are currently emulating MSR_K7_EVNTSEL[0-3], but not emulating MSR_K7_PERFCTR[0-3]. Because of this,
setup_k7_watchdog()in the Linux kernel receives a GPF when it attempts to write intoMSR_K7_PERFCTR, which causes an OOPs.The patch fixes it by just "fake" emulating the appropriate MSRs, throwing away the data in the process. This causes the NMI watchdog to not actually work, but it's not such a big deal in a virtualized environment.
Quoted 6 lines
When we get a write to one of these counters, we
printk_ratelimit()a warning. I decided to print it out for all writes, even if the data is 0; it doesn't seem to make sense to me to special case when data == 0.Tested by myself on a RHEL-4 guest, and Joerg Roedel on a Windows XP 64-bit guest.
Applied, thanks.
Signature · 8 lines
Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone