x86: remove printk compiling warning
PATCH 1/1 x86: remove printk compiling warning
Since size is unsigned long, the format string is changed from zd to lu.
--- arch/x86/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/setup.c +1 -1
@@ -95,7 +95,7 @@ void __init setup_per_cpu_areas(void)/* Copy section for each CPU (we discard the original) */ size =PERCPU_ENOUGH_ROOM ; -printk (KERN_INFO "PERCPU: Allocating %zd bytes of per cpu data\n" , +printk (KERN_INFO "PERCPU: Allocating %lu bytes of per cpu data\n" , size);for_each_possible_cpu (i) {
Signature · 1 line
1.5.4.1
Quoted 13 lines · Shen Feng
Since size is unsigned long, the format string is changed from zd to lu.
Signed-off-by Shen Feng <[email protected]>--- arch/x86/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/x86/kernel/setup.c +0
-0
arch/x86/kernel/setup.c void __init setup_per_cpu_areas(void) · line 101
Quoted 8 lines
arch/x86/kernel/setup.c +1
-1@@ -95,7 +95,7 @@ void __init setup_per_cpu_areas(void)/* Copy section for each CPU (we discard the original) */ size =PERCPU_ENOUGH_ROOM ; -printk (KERN_INFO "PERCPU: Allocating %zd bytes of per cpu data\n" , +printk (KERN_INFO "PERCPU: Allocating %lu bytes of per cpu data\n" , size);for_each_possible_cpu (i) {
Let me figure out this.
Commit 0fc5035fc66d26776bebd45c508a9bce3611f388 in linux-next changed 'size' from unsigned long to ssize_t, causing a compile warning, and then Randy posted a patch to fix it:
http://marc.info/?l=linux-kernel&m=120958902125650&w=2
But this patch was wrongly merged into mainline, causing the compile warning you described here.
So we should revert Randy's patch and re-apply it to linux-next ?
Quoted 30 lines · On Wed, 07 May 2008 16:27:11 +0800 Li Zefan wrote:
CC Randy Dunlap <[email protected]>Quoted 13 lines · Shen Feng
Since size is unsigned long, the format string is changed from zd to lu.
Signed-off-by Shen Feng <[email protected]>--- arch/x86/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/x86/kernel/setup.c +0
-0arch/x86/kernel/setup.c void __init setup_per_cpu_areas(void) · line 101
Quoted 8 lines
arch/x86/kernel/setup.c +1
-1@@ -95,7 +95,7 @@ void __init setup_per_cpu_areas(void)/* Copy section for each CPU (we discard the original) */ size =PERCPU_ENOUGH_ROOM ; -printk (KERN_INFO "PERCPU: Allocating %zd bytes of per cpu data\n" , +printk (KERN_INFO "PERCPU: Allocating %lu bytes of per cpu data\n" , size);for_each_possible_cpu (i) {Let me figure out this.
Commit
0fc5035fc66d26776bebd45c508a9bce3611f388in linux-next changed 'size' from unsigned long tossize_t, causing a compile warning, and then Randy posted a patch to fix it:
Quoted 6 lines
http://marc.info/?l=linux-kernel&m=120958902125650&w=2But this patch was wrongly merged into mainline, causing the compile warning you described here.
So we should revert Randy's patch and re-apply it to linux-next ?
Hi,
Thanks for the detective work. I hadn't looked into this yet.
Yes, my patch was sent for linux-next. How are we supposed to keep this straightened out?
---
~Randy
Quoted 30 lines · Li Zefan
CC Randy Dunlap <[email protected]>Quoted 13 lines · Shen Feng
Since size is unsigned long, the format string is changed from zd to lu.
Signed-off-by Shen Feng <[email protected]>--- arch/x86/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/x86/kernel/setup.c +0
-0arch/x86/kernel/setup.c void __init setup_per_cpu_areas(void) · line 101
Quoted 8 lines
arch/x86/kernel/setup.c +1
-1@@ -95,7 +95,7 @@ void __init setup_per_cpu_areas(void)/* Copy section for each CPU (we discard the original) */ size =PERCPU_ENOUGH_ROOM ; -printk (KERN_INFO "PERCPU: Allocating %zd bytes of per cpu data\n" , +printk (KERN_INFO "PERCPU: Allocating %lu bytes of per cpu data\n" , size);for_each_possible_cpu (i) {Let me figure out this.
Commit
0fc5035fc66d26776bebd45c508a9bce3611f388in linux-next changed 'size' from unsigned long tossize_t, causing a compile warning, and then Randy posted a patch to fix it:
Quoted 6 lines
http://marc.info/?l=linux-kernel&m=120958902125650&w=2But this patch was wrongly merged into mainline, causing the compile warning you described here.
So we should revert Randy's patch and re-apply it to linux-next ?
Yes, this came via Andrew and we did not notice that it was for linux-next.
Thanks,
tglx