Skip to contentSkip to conversation

NET: Remove PACKET_FASTROUTE

PATCH In review Wang Chen 2 participants 3 messages May 7, 2008

Subsystems (2)
lore
Share & tools
lore

Wang Chen

author
#0 lore raw

PATCH 1/1 NET: Remove PACKET_FASTROUTE

Since we do not support fastroute anymore, remove macro PACKET_FASTROUTE.

---
 include/linux/if_packet.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/if_packet.h +0 -1
index ad09609..d109a0f 100644
@@ -30,7 +30,6 @@ struct sockaddr_ll
 #define PACKET_OUTGOING		4		/* Outgoing of any type */
 /* These ones are invisible by user level */
 #define PACKET_LOOPBACK		5		/* MC/BRD frame looped back */
-#define PACKET_FASTROUTE	6		/* Fastrouted frame	*/
 
 /* Packet socket options */
 
Signature · 1 line
1.5.3.4
maintainer
#1 lore raw

From: Wang Chen <[email protected]>
Date: Wed, 07 May 2008 17:07:10 +0800

Quoted 3 lines

Since we do not support fastroute anymore, remove macro PACKET_FASTROUTE.

We should leave it there so that this value is not accidently allocatod to another purpose.

If you really really want to remove it, at least add a comment there that value "6" used to be allocated to PACKET_FASTROUTE, and therefore cannot be reused.

But, to be honest, keeping the define there serves that purpose just as well.

author
#2 lore raw

David Miller said the following on 2008-5-7 17:35:

Quoted 10 lines

From: Wang Chen <[email protected]>
Date: Wed, 07 May 2008 17:07:10 +0800

Quoted 3 lines

Since we do not support fastroute anymore, remove macro PACKET_FASTROUTE.

We should leave it there so that this value is not accidently allocatod to another purpose.

Quoted 7 lines

If you really really want to remove it, at least add a comment there that value "6" used to be allocated to PACKET_FASTROUTE, and therefore cannot be reused.

But, to be honest, keeping the define there serves that purpose just as well.

Yes. I agree. So leave it there.