Skip to contentSkip to conversation

gitk: Allow toggling of checkboxes by clicking on the label

PATCH New Jean-Luc Herren 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gitk: Allow toggling of checkboxes by clicking on the label

---
I hope this makes any sense, since I do not know any tcl/tk at all. I think being able to click on the label of checkboxes is good manner, since otherwise you have to click into a fairly small area. However, this patch unfortunately also reduces the size of the checkbox itself, proably because it adapts itself to the small optionfont. I don't know how to fix this other than increasing the size of optionfont, so I'll let someone else do this, if this is desired.

gitk-git/gitk | 24 ++++++++++++------------

1 files changed, 12 insertions(+), 12 deletions(-)
gitk-git/gitk +12 -12
index 9a4d9c4..ef8dcc0 100644
@@ -8015,14 +8015,14 @@ proc doprefs {} {
    spinbox $top.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct
    grid x $top.maxpctl $top.maxpct -sticky w
    frame $top.showlocal
-    label $top.showlocal.l -text [mc "Show local changes"] -font optionfont
-    checkbutton $top.showlocal.b -variable showlocalchanges
-    pack $top.showlocal.b $top.showlocal.l -side left
+    checkbutton $top.showlocal.b -variable showlocalchanges \
+	-text [mc "Show local changes"] -font optionfont
+    pack $top.showlocal.b -side left
    grid x $top.showlocal -sticky w
    frame $top.autoselect
-    label $top.autoselect.l -text [mc "Auto-select SHA1"] -font optionfont
-    checkbutton $top.autoselect.b -variable autoselect
-    pack $top.autoselect.b $top.autoselect.l -side left
+    checkbutton $top.autoselect.b -variable autoselect \
+	-text [mc "Auto-select SHA1"] -font optionfont
+    pack $top.autoselect.b -side left
    grid x $top.autoselect -sticky w
 
    label $top.ddisp -text [mc "Diff display options"]
@@ -8031,14 +8031,14 @@ proc doprefs {} {
    spinbox $top.tabstop -from 1 -to 20 -width 4 -textvariable tabstop
    grid x $top.tabstopl $top.tabstop -sticky w
    frame $top.ntag
-    label $top.ntag.l -text [mc "Display nearby tags"] -font optionfont
-    checkbutton $top.ntag.b -variable showneartags
-    pack $top.ntag.b $top.ntag.l -side left
+    checkbutton $top.ntag.b -variable showneartags \
+	-text [mc "Display nearby tags"] -font optionfont
+    pack $top.ntag.b -side left
    grid x $top.ntag -sticky w
    frame $top.ldiff
-    label $top.ldiff.l -text [mc "Limit diffs to listed paths"] -font optionfont
-    checkbutton $top.ldiff.b -variable limitdiffs
-    pack $top.ldiff.b $top.ldiff.l -side left
+    checkbutton $top.ldiff.b -variable limitdiffs \
+	-text [mc "Limit diffs to listed paths"] -font optionfont
+    pack $top.ldiff.b -side left
    grid x $top.ldiff -sticky w
 
    label $top.cdisp -text [mc "Colors: press to choose"]
Signature · 1 line
1.5.5.1