commit a4b69b7f1809898c87bdc11502ca258a8f16a220 breaks parallel builds

	CC unpack.c
	CC unparse.c
	CC uuid_time.c
	GEN_LIB libuuid.a
	GEN_LIB ../../lib/libuuid.a

/bin/ln: creating hard link ../../../lib/libuuid.a' to ../../lib/libuuid.a': No such file or directory make[2]: *** [../../lib/libuuid.a] Error 1 make[2]: Leaving directory /tmp/e2fsprogs-1.41/lib/uuid' make[1]: *** [all-libs-recursive] Error 1 make[1]: Leaving directory /tmp/e2fsprogs-1.41'
make: *** [all] Error 2

I tried looking into this, but I'm at a bit of a loss as to what the change was trying to do, so not sure how to fix it... but from e2fsprogs/lib/uuid/ it would appear that the addition of $(LIB)/$(LIBRARY).a here has got us backing up one ".." too far :)

$(LIB)/$(LIBRARY).a $(LIBRARY).a: $(OBJS)

        @echo " GEN_LIB $@"
        @(if test -r $@; then $(RM) -f [email protected] && $(MV) $@ [email protected]; fi)
        @$(ARGEN) $@ $(OBJS)
        -@$(RANLIB) $@
        @$(RM) -f ../$@
        @$(LN) $@ ../$@

-Eric

Here's the fix which I've checked into the git repository.

- Ted

From: Theodore Ts'o <[email protected]>
Date: Sun, 11 May 2008 20:34:12 -0400
Subject: [PATCH] Fix parallel build problem

Problem was introduced by commit a4b69b7f1809898c87bdc11502ca258a8f16a220

Thanks to Eric Sandeen from Red Hat for pointing out this problem.

---
 lib/Makefile.library |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

index 52f28bb..7d9e99f 100644
@@ -13,7 +13,7 @@ subdirs:: Makefile
 clean::
 	@$(RM) -f subdirs
 
-$(LIB)/$(LIBRARY).a $(LIBRARY).a: $(OBJS)
+$(LIBRARY).a: $(OBJS)
 	@echo "	GEN_LIB $@"
 	@(if test -r $@; then $(RM) -f [email protected] && $(MV) $@ [email protected]; fi)
 	@$(ARGEN) $@ $(OBJS)

@@ -21,3 +21,4 @@ $(LIB)/$(LIBRARY).a $(LIBRARY).a: $(OBJS)
 	@$(RM) -f ../$@
 	@$(LN) $@ ../$@
 
+$(LIB)/$(LIBRARY).a: $(LIBRARY).a

1.5.4.1.144.gdfee-dirty