Skip to contentSkip to conversation

only print pages' mfn-s in dump_pageframe_info()

PATCH New Jan Beulich 1 participant 1 message May 9, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 only print pages' mfn-s in dump_pageframe_info()

Printing page_to_maddr() and page_to_mfn() of the same page is redundant, and _p(page_to_maddr(page)) is even incorrect on x86/PAE.

xen/arch/x86/domain.c +4 -4
Index: 2008-05-08/xen/arch/x86/domain.c
===================================================================
@@ -138,16 +138,16 @@ void dump_pageframe_info(struct domain *
     {
         list_for_each_entry ( page, &d->page_list, list )
         {
-            printk("    DomPage %p: mfn=%p, caf=%08x, taf=%" PRtype_info "\n",
-                   _p(page_to_maddr(page)), _p(page_to_mfn(page)),
+            printk("    DomPage %p: caf=%08x, taf=%" PRtype_info "\n",
+                   _p(page_to_mfn(page)),
                    page->count_info, page->u.inuse.type_info);
         }
     }
 
     list_for_each_entry ( page, &d->xenpage_list, list )
     {
-        printk("    XenPage %p: mfn=%p, caf=%08x, taf=%" PRtype_info "\n",
-               _p(page_to_maddr(page)), _p(page_to_mfn(page)),
+        printk("    XenPage %p: caf=%08x, taf=%" PRtype_info "\n",
+               _p(page_to_mfn(page)),
                page->count_info, page->u.inuse.type_info);
     }
 }