Skip to contentSkip to conversation

Latest git will not boot on MacBook

Bisected Tejun Heo 2 participants 2 messages May 13, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Tejun Heo

author
#1 lore raw
Quoted 27 lines · Harald Arnesen

See attached photo of screen.
git bisect gives this:

78ab88f04f44bed566d51dce0c7cbfeff6449a06 is first bad commit commit 78ab88f04f44bed566d51dce0c7cbfeff6449a06

Author: Tejun Heo <[email protected]>
Date:   Thu May 1 23:41:41 2008 +0900

libata: improve post-reset device ready test

Some controllers (jmb and inic162x) use 0x77 and 0x7f to indicate that the device isn't ready yet. It looks like they use 0xff if device presence is detected but connection isn't established. 0x77 or 0x7f after connection is established and use the value from signature FIS after receiving it.

This patch implements ata_check_ready(), which takes TF status value and determines whether the port is ready or not considering the above and other conditions, and use it in @check_ready() functions. This is safe as both 0x77 and 0x7f aren't valid ready status value even though they have BSY bit cleared.

This fixes hot plug detection failures which can be triggered with certain drives if they aren't already spun up when the data connector is hot plugged.

Quoted 5 lines

Tested on sil, sil24, ahci (jmb/ich), piix and inic162x combined with eight drives from all major vendors.

The change was reverted and I'm trying to come up with a better version.
Thanks.

Signature · 1 line
tejun
#2 lore raw
Quoted 5 lines · Tejun Heo
Quoted 4 lines · Harald Arnesen

See attached photo of screen.
git bisect gives this:

Quoted 7 lines
Quoted 4 lines

78ab88f04f44bed566d51dce0c7cbfeff6449a06 is first bad commit commit 78ab88f04f44bed566d51dce0c7cbfeff6449a06

Author: Tejun Heo <[email protected]>
Date:   Thu May 1 23:41:41 2008 +0900

The change was reverted and I'm trying to come up with a better version. Thanks.

If you want me to test a new version on my MacBook, let me know.

Signature · 1 line
Hilsen Harald.