: Do not free not yet unregistered net device.

PATCH Applied Pavel Emelyanov 2 participants 2 messages May 13, 2008 – May 14, 2008

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Pavel Emelyanov

author

2008-05-13 15:33 UTC #0 lore raw

PATCH 1/1 : Do not free not yet unregistered net device.

An error path in ppp_create_interface() lacks one and may BUG in free_netdev() checking for proper dev->reg_state.

Signed-off-by Pavel Emelyanov <[email protected]>

---

drivers/net/ppp_generic.c +1 -0

index d3207c0..1f4ca2b 100644
@@ -2458,6 +2458,7 @@ ppp_create_interface(int unit, int *retp)
 
 out3:
 	atomic_dec(&ppp_unit_count);
+	unregister_netdev(dev);
 out2:
 	mutex_unlock(&all_ppp_mutex);
 	free_netdev(dev);

David Miller

maintainer Applied

2008-05-14 06:51 UTC #1 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Tue, 13 May 2008 19:30:50 +0400

Quoted 4 lines

An error path in ppp_create_interface() lacks one and may BUG in free_netdev() checking for proper dev->reg_state.
Signed-off-by Pavel Emelyanov <[email protected]>

Applied, thanks a lot Pavel.