fec_mpc52xx: MPC52xx_MESSAGES_DEFAULT: 2nd NETIF_MSG_IFDOWN => IFUP

PATCH In review Roel Kluin 2 participants 2 messages May 14, 2008 2 messages not in the archive

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Roel Kluin

author

2008-05-14 08:10 UTC #2 lore raw

PATCH 1/1 fec_mpc52xx: MPC52xx_MESSAGES_DEFAULT: 2nd NETIF_MSG_IFDOWN => IFUP

Quoted 10 lines · Sylvain Munaut

Quoted 9 lines · Roel Kluin
in drivers/net/fec_mpc52xx.c:81 it reads:
#define MPC52xx_MESSAGES_DEFAULT ( NETIF_MSG_DRV | NETIF_MSG_PROBE | \
NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFDOWN )
should this maybe be
NETIF_MSG_IFUP | NETIF_MSG_IFDOWN )

Quoted 7 lines

Quoted 3 lines
?
Yes but I remember seeing a patch for this already ... What kernel version / revision do you have ?
Sylvain

Indeed I already sent the patch, see http://lkml.org/lkml/2008/1/30/252 (my emailaddress changed), but there was no response and the patch isn't included in current Linus' git. maybe if you could add your ack?
---
duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/fec_mpc52xx.c +1 -1

index 5f9c42e..329edd9 100644
@@ -78,7 +78,7 @@ module_param_array_named(mac, mpc52xx_fec_mac_addr, byte, NULL, 0);
 MODULE_PARM_DESC(mac, "six hex digits, ie. 0x1,0x2,0xc0,0x01,0xba,0xbe");
 
 #define MPC52xx_MESSAGES_DEFAULT ( NETIF_MSG_DRV | NETIF_MSG_PROBE | \
-		NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFDOWN )
+		NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFUP)
 static int debug = -1;	/* the above default */
 module_param(debug, int, 0);
 MODULE_PARM_DESC(debug, "debugging messages level");

Sylvain Munaut

Acked-by on v1 1/1

2008-05-14 08:30 UTC #3 lore raw

Quoted 10 lines · Roel Kluin

Quoted 5 lines
Yes but I remember seeing a patch for this already ... What kernel version / revision do you have ?
Sylvain
Indeed I already sent the patch, see http://lkml.org/lkml/2008/1/30/252 (my emailaddress changed), but there was no response and the patch isn't included in current Linus' git. maybe if you could add your ack?

Sure thing.

Acked-by Sylvain Munaut <[email protected]>

Quoted 20 lines

---
duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/fec_mpc52xx.c +1 -1

index 5f9c42e..329edd9 100644
@@ -78,7 +78,7 @@ module_param_array_named(mac, mpc52xx_fec_mac_addr, byte, NULL, 0);
 MODULE_PARM_DESC(mac, "six hex digits, ie. 0x1,0x2,0xc0,0x01,0xba,0xbe");
 
 #define MPC52xx_MESSAGES_DEFAULT ( NETIF_MSG_DRV | NETIF_MSG_PROBE | \
-		NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFDOWN )
+		NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFUP)
 static int debug = -1;	/* the above default */
 module_param(debug, int, 0);
 MODULE_PARM_DESC(debug, "debugging messages level");