Skip to contentSkip to conversation

Fix breakpoints coming into KVM that are corrupted from qemu

PATCH Applied Jerone Young 2 participants 2 messages May 22, 2008 – May 25, 2008 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix breakpoints coming into KVM that are corrupted from qemu

1 file changed, 2 insertions(+)

qemu/qemu-kvm.c | 2 ++

Bad breakpoints are being passed down to KVM due to the fact that breakpoint structure in the kvm_debug_guest structure are not being initialized. This fixes this.

This fix can also be found in the RFC patches that Jan Kiszka has sent for adding soft breakpoints.

qemu/qemu-kvm.c +2 -0
@@ -704,6 +704,8 @@ int kvm_update_debugger(CPUState *env)
     struct kvm_debug_guest dbg;
     int i;
 
+    memset(dbg.breakpoints, 0, sizeof(dbg.breakpoints));
+
     dbg.enabled = 0;
     if (env->nb_breakpoints || env->singlestep_enabled) {
 	dbg.enabled = 1;
Applied
#1 lore raw
Quoted 5 lines · Jerone Young

Bad breakpoints are being passed down to KVM due to the fact that breakpoint structure in the kvm_debug_guest structure are not being initialized. This fixes this.

This fix can also be found in the RFC patches that Jan Kiszka has sent for adding soft breakpoints.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function