Skip to contentSkip to conversation

Fix XendAPI VM_migrate parameters

PATCH In review Zhigang Wang 2 participants 2 messages May 26, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix XendAPI VM_migrate parameters

Hi,

This patch removes unused resource parameter and fixes the default value for domain_migrate. Also removes tab indent in XendOptions.py.

regards,

zhigang

Fix XendAPI VM_migrate parameters

This patch removes unused resource parameter and fixes the default value for domain_migrate. Also removes tab indent in XendOptions.py.

tools/python/xen/xend/XendAPI.py +3 -4
diff -Nurap xen-unstable.orig/tools/python/xen/xend/XendAPI.py xen-unstable/tools/python/xen/xend/XendAPI.py
@@ -1759,13 +1759,12 @@ class XendAPI(object):
         xendom = XendDomain.instance()
         xeninfo = xendom.get_vm_by_uuid(vm_ref)
 
-        resource = other_config.get("resource", 0)
         port = other_config.get("port", 0)
-        node = other_config.get("node", 0)
-        ssl = other_config.get("ssl", 0)
+        node = other_config.get("node", -1)
+        ssl = other_config.get("ssl", None)
         
         xendom.domain_migrate(xeninfo.getDomid(), destination_url,
-                              bool(live), resource, port, node, ssl)
+                              bool(live), port, node, ssl)
         return xen_api_success_void()
 
     def VM_save(self, _, vm_ref, dest, checkpoint):
tools/python/xen/xend/XendOptions.py +1 -1
diff -Nurap xen-unstable.orig/tools/python/xen/xend/XendOptions.py xen-unstable/tools/python/xen/xend/XendOptions.py
@@ -222,7 +222,7 @@ class XendOptions:
                                    self.xend_relocation_port_default)
 
     def get_xend_relocation_ssl_port(self):
-	"""Get the port xend listens at for ssl connection to its relocation
+        """Get the port xend listens at for ssl connection to its relocation
         server.
         """
         return self.get_config_int('xend-relocation-ssl-port',

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw

Hi Zhigang,

Thanks for your work. I think it's good.

Kan

Quoted 16 lines · Zhigang Wang

Hi,

This patch removes unused resource parameter and fixes the default value for domain_migrate. Also removes tab indent in XendOptions.py.

regards,

zhigang

-------------------------------text/plain-------------------------------
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel