Skip to contentSkip to conversation

scsi/libiscsi.c: return -errno rather than errno

PATCH In review Li Zefan 2 participants 2 messages May 27, 2008

Subsystems (2)
SCSI iSCSI
lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 scsi/libiscsi.c: return -errno rather than errno

iscsi_prep_scsi_cmd_pdu() returns EIO in a failing path, but returns -errno in other paths.

Signed-off-by Li Zefan <[email protected]>
---
 drivers/scsi/libiscsi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/libiscsi.c +1 -1
index b43bf1d..d380f46 100644
@@ -307,7 +307,7 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_cmd_task *ctask)
 	hdr->hlength = hdrlength & 0xFF;
 
 	if (conn->session->tt->init_cmd_task(conn->ctask))
-		return EIO;
+		return -EIO;
 
 	conn->scsicmd_pdus_cnt++;
 	debug_scsi("iscsi prep [%s cid %d sc %p cdb 0x%x itt 0x%x "

-- 1.5.4.rc3

#1 lore raw
Quoted 3 lines · Li Zefan

iscsi_prep_scsi_cmd_pdu() returns EIO in a failing path, but returns -errno in other paths.

Thanks for the patch. I fixed this in the patches I sent to James for 2.6.27 already.