Skip to contentSkip to conversation

dvb-usb/gp8psk.c: return -errno rather than errno

PATCH In review Li Zefan 2 participants 3 messages May 27, 2008 – May 28, 2008 Media (V4L/DVB)

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 dvb-usb/gp8psk.c: return -errno rather than errno

gp8psk_power_ctrl() returns -EINVAL in some failing paths, but returns EINVAL in some other paths.

---
 drivers/media/dvb/dvb-usb/gp8psk.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/media/dvb/dvb-usb/gp8psk.c +5 -5
index 9a942af..2653120 100644
@@ -146,24 +146,24 @@ static int gp8psk_power_ctrl(struct dvb_usb_device *d, int onoff)
 		if (gp_product_id == USB_PID_GENPIX_8PSK_REV_1_WARM)
 			if (! (status & bm8pskFW_Loaded)) /* BCM4500 firmware loaded */
 				if(gp8psk_load_bcm4500fw(d))
-					return EINVAL;
+					return -EINVAL;
 
 		if (! (status & bmIntersilOn)) /* LNB Power */
 			if (gp8psk_usb_in_op(d, START_INTERSIL, 1, 0,
 					&buf, 1))
-				return EINVAL;
+				return -EINVAL;
 
 		/* Set DVB mode to 1 */
 		if (gp_product_id == USB_PID_GENPIX_8PSK_REV_1_WARM)
 			if (gp8psk_usb_out_op(d, SET_DVB_MODE, 1, 0, NULL, 0))
-				return EINVAL;
+				return -EINVAL;
 		/* Abort possible TS (if previous tune crashed) */
 		if (gp8psk_usb_out_op(d, ARM_TRANSFER, 0, 0, NULL, 0))
-			return EINVAL;
+			return -EINVAL;
 	} else {
 		/* Turn off LNB power */
 		if (gp8psk_usb_in_op(d, START_INTERSIL, 0, 0, &buf, 1))
-			return EINVAL;
+			return -EINVAL;
 		/* Turn off 8psk power */
 		if (gp8psk_usb_in_op(d, BOOT_8PSK, 0, 0, &buf, 1))
 			return -EINVAL;

-- 1.5.4.rc3

author
#2 lore raw
Quoted 10 lines · Mauro Carvalho Chehab
Quoted 5 lines · On Tue, 27 May 2008 16:01:21 +0800 Li Zefan <[email protected]> wrote:

gp8psk_power_ctrl() returns -EINVAL in some failing paths, but returns EINVAL in some other paths.

---

Thanks Li. However, I've committed a few days ago a similar patch from Marcin.

Good to know this. :)

Quoted 5 lines

Cheers,
Mauro