kmalloc() with GFP_KERNEL while holding spinlock ?
I noticed the following issue in the code:
in drivers/ata/libata-acpi.c:
static void ata_acpi_handle_hotplug(struct ata_port *ap, struct ata_device *dev,
u32 event)
{
...
spin_lock_irqsave(ap->lock, flags);
...
if (dev) {
if (dev->sdev)
kobj = &dev->sdev->sdev_gendev.kobj;
} else
kobj = &ap->dev->kobj;
if (kobj) {
sprintf(event_string, "BAY_EVENT=%d", event);
kobject_uevent_env(kobj, KOBJ_CHANGE, envp);
}
spin_unlock_irqrestore(ap->lock, flags);
...
}and kobject_uevent_env() calls kzalloc(..., GFP_KERNEL);
Hi,
Quoted 26 lines · Li Zefan
I noticed the following issue in the code:
in
drivers/ata/libata-acpi.c:static void ata_acpi_handle_hotplug(struct
ata_port*ap, structata_device*dev,u32 event) { ... spin_lock_irqsave(ap->lock, flags); ... if (dev) { if (dev->sdev) kobj = &dev->sdev->sdev_gendev.kobj; } else kobj = &ap->dev->kobj; if (kobj) { sprintf(event_string, "BAY_EVENT=%d", event); kobject_uevent_env(kobj, KOBJ_CHANGE, envp); } spin_unlock_irqrestore(ap->lock, flags); ... }
Quoted 1 line
and
kobject_uevent_env()callskzalloc(..., GFP_KERNEL);
Fixed by commit ae6c23c4e1ec9720b99e1e6850fe47c6c7fddbb3 "Fixups to ATA ACPI hotplug" by Matthew Garrett.
Hannes
Quoted 3 lines · Johannes Weiner
Fixed by commit
ae6c23c4e1ec9720b99e1e6850fe47c6c7fddbb3"Fixups to ATA ACPI hotplug" by Matthew Garrett.
Thanks. The code I was reading is 2.6.26-rc2-mm1. I should have checked the latest kernel.