ipset 2.3.0 segfault on '-U :all: {:all:|:default:}

Segfault occurs at line 1641 as a result of dereferencing a null pointer while testing the set type for iptreemap.

Patch attached.

Disclaimer: I didn't research the consequences of this patch if there are existing iptreemap sets.

-Tom

Tom Eastep    \ Nothing is foolproof to a sufficiently talented fool
Shoreline,     \ http://shorewall.net
Washington USA  \ [email protected]
PGP Public Key   \ https://lists.shorewall.net/teastep.pgp.key

@@ -1638,7 +1638,7 @@
 	DP("(%s, %s) -> %s", set ? set->name : IPSET_TOKEN_ALL, adt, binding);
 
 	/* Ugly */
-	if (strcmp(set->settype->typename, "iptreemap") == 0)
+	if (set && strcmp(set->settype->typename, "iptreemap") == 0)
 		exit_error(PARAMETER_PROBLEM,
 			"iptreemap type of sets cannot be used at binding operations\n");
 	/* Alloc memory for the data to send */

Thank you the report and the patch: I'll apply it as soon as the svn->git migration of ipset source is ready.

Best regards,
Jozsef
-
E-mail : [email protected], [email protected] PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics

          H-1525 Budapest 114, POB. 49, Hungary

This remains me that I forget to send this little patch to make checkentry static.

Best regards,

Krzysztof Olędzki

@@ -57,7 +57,7 @@
 }
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
-bool
+static bool
 #else
 static int
 #endif

Don't let this stop you, doing a final resync is no problem.