ahci: change the Device IDs of nvidia MCP7B AHCI controller in ahci.c

PATCH Applied peerchen 2 participants 4 messages May 19, 2008 – May 30, 2008 libata

lore

Share & tools

lore

peerchen

author

2008-05-19 06:44 UTC #0 lore raw

PATCH 1/1 ahci: change the Device IDs of nvidia MCP7B AHCI controller in ahci.c

Change the partial Device IDs of nvidia MCP7B AHCI controller in ahci.c

Signed-off-by Peer Chen <[email protected]>

---

drivers/ata/ahci.c renamed from drivers/ata/ahci.c.orig +4 -4

@@ -502,10 +502,10 @@ static const struct pci_device_id ahci_p
 	{ PCI_VDEVICE(NVIDIA, 0x0bcd), board_ahci },		/* MCP7B */
 	{ PCI_VDEVICE(NVIDIA, 0x0bce), board_ahci },		/* MCP7B */
 	{ PCI_VDEVICE(NVIDIA, 0x0bcf), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd0), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd1), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd2), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd3), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc4), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc5), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc6), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc7), board_ahci },		/* MCP7B */
 
 	/* SiS */
 	{ PCI_VDEVICE(SI, 0x1184), board_ahci }, /* SiS 966 */

Jeff Garzik

2008-05-19 19:11 UTC #1 lore raw

Quoted 8 lines · peerchen

Change the partial Device IDs of nvidia MCP7B AHCI controller in ahci.c
Signed-off-by Peer Chen <[email protected]>
---
drivers/ata/ahci.c renamed from drivers/ata/ahci.c.orig +0 -0
@@ -502,10 +502,10 @@ static const struct pci_device_id ahci_p
 	{ PCI_VDEVICE(NVIDIA, 0x0bcd), board_ahci },		/* MCP7B */

drivers/ata/ahci.c static const struct pci_device_id ahci_p · line 508

Quoted 10 lines

drivers/ata/ahci.c renamed from drivers/ata/ahci.c.orig +4 -4

 	{ PCI_VDEVICE(NVIDIA, 0x0bce), board_ahci },		/* MCP7B */
 	{ PCI_VDEVICE(NVIDIA, 0x0bcf), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd0), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd1), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd2), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd3), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc4), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc5), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc6), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc7), board_ahci },		/* MCP7B */

A little bit more patch description, please?

Why is this change needed? A change with a description of (paraphrasing) "do this change" is rather vague ;)

Jeff

peerchen

author

2008-05-20 02:51 UTC #2 lore raw

Re: Re: [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controllerin ahci.c

We make a mistake, the IDs need to be changed are not correct, those IDs belong to other devices.

------------------
peerchen
2008-05-20

-------------------------------------------------------------
发件人：Jeff Garzik
发送日期：2008-05-20 03:11:56
收件人：peerchen
抄送：linux-kernel; linux-ide; akpm
主题：Re: [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controllerin ahci.c

Quoted 8 lines · peerchen

Change the partial Device IDs of nvidia MCP7B AHCI controller in ahci.c
Signed-off-by Peer Chen <[email protected]>
---
drivers/ata/ahci.c renamed from drivers/ata/ahci.c.orig +0 -0
@@ -502,10 +502,10 @@ static const struct pci_device_id ahci_p
 	{ PCI_VDEVICE(NVIDIA, 0x0bcd), board_ahci },		/* MCP7B */

drivers/ata/ahci.c static const struct pci_device_id ahci_p · line 508

Quoted 10 lines

drivers/ata/ahci.c renamed from drivers/ata/ahci.c.orig +4 -4

 	{ PCI_VDEVICE(NVIDIA, 0x0bce), board_ahci },		/* MCP7B */
 	{ PCI_VDEVICE(NVIDIA, 0x0bcf), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd0), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd1), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd2), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd3), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc4), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc5), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc6), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc7), board_ahci },		/* MCP7B */

A little bit more patch description, please?

Why is this change needed? A change with a description of (paraphrasing) "do this change" is rather vague ;)

Jeff

Jeff Garzik

Applied

2008-05-30 22:11 UTC #3 lore raw

In reply to peerchen

Quoted 8 lines · peerchen

Change the partial Device IDs of nvidia MCP7B AHCI controller in ahci.c
Signed-off-by Peer Chen <[email protected]>
---
drivers/ata/ahci.c renamed from drivers/ata/ahci.c.orig +0 -0
@@ -502,10 +502,10 @@ static const struct pci_device_id ahci_p
 	{ PCI_VDEVICE(NVIDIA, 0x0bcd), board_ahci },		/* MCP7B */

drivers/ata/ahci.c static const struct pci_device_id ahci_p · line 508

Quoted 10 lines

drivers/ata/ahci.c renamed from drivers/ata/ahci.c.orig +4 -4

 	{ PCI_VDEVICE(NVIDIA, 0x0bce), board_ahci },		/* MCP7B */
 	{ PCI_VDEVICE(NVIDIA, 0x0bcf), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd0), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd1), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd2), board_ahci },		/* MCP7B */
-	{ PCI_VDEVICE(NVIDIA, 0x0bd3), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc4), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc5), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc6), board_ahci },		/* MCP7B */
+	{ PCI_VDEVICE(NVIDIA, 0x0bc7), board_ahci },		/* MCP7B */

applied